You are missing trading opportunities:
- Free trading apps
- Over 8,000 signals for copying
- Economic news for exploring financial markets
Registration
Log in
You agree to website policy and terms of use
If you do not have an account, please register
Hi,
I tried to debug it.
init() ---> subPrintDetails() ---> subPipProfitTotal()
In the subPipProfitTotal(), you are using:
double PipProfit = (OrderProfit()/OrderLots()/tickvalue);
The ticketvalue is zero when it is initilaized.
To fix the bug, you may simply remove subPrintDetails() in init(). This has no effect on the system since the subPrintDetails() was invoked later in start().Thank you so much,
Will post the fixed version later today.
Kind Regards,
Mikhail
Thank you so much,
Will post the fixed version later today.
Kind Regards,
MikhailMore changes are needed.
In the start(), the line "subPrintDetails()" should be put after the line
tickvalue = MarketInfo(Symbol(),MODE_TICKVALUE);
Thanks!
Scott
More changes are needed.
In the start(), the line "subPrintDetails()" should be put after the line
tickvalue = MarketInfo(Symbol(),MODE_TICKVALUE);
Thanks!
ScottJust attached the EA to GBPJPY. It repeat many times open and delete, reopen and redelete the stop buy and stop sell orders. Haven't looked at the logic. Maybe it is not critical.
2007.01.02 22:29:26 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1: open #18816647 sell stop 0.10 GBPJPYm at 232.5700 sl: 233.3300 ok
2007.01.02 22:29:26 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1: delete #18816643 sell stop 0.10 GBPJPYm at 232.5800 sl: 233.3300 tp: 0.0000 ok
2007.01.02 22:29:25 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1: open #18816646 buy stop 0.10 GBPJPYm at 234.6600 sl: 233.9000 ok
2007.01.02 22:29:25 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1: delete #18816642 buy stop 0.10 GBPJPYm at 234.6500 sl: 233.9000 tp: 0.0000 ok
2007.01.02 22:29:25 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1:
2007.01.02 22:29:22 Ninja Tutle - Sys2 - Beta 4.2 EURUSDm,H1:
2007.01.02 22:29:21 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1: open #18816643 sell stop 0.10 GBPJPYm at 232.5800 sl: 233.3300 ok
2007.01.02 22:29:20 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1: delete #18816641 sell stop 0.10 GBPJPYm at 232.5700 sl: 233.3300 tp: 0.0000 ok
2007.01.02 22:29:20 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1: open #18816642 buy stop 0.10 GBPJPYm at 234.6500 sl: 233.9000 ok
2007.01.02 22:29:20 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1: delete #18816639 buy stop 0.10 GBPJPYm at 234.6600 sl: 233.9000 tp: 0.0000 ok
YES, because version 4.2 takes into consideration your brokers spread, so if the spread changes it also changes the stops.
Mikhail
Just attached the EA to GBPJPY. It repeat many times open and delete, reopen and redelete the stop buy and stop sell orders. Haven't looked at the logic. Maybe it is not critical.
2007.01.02 22:29:26 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1: open #18816647 sell stop 0.10 GBPJPYm at 232.5700 sl: 233.3300 ok
2007.01.02 22:29:26 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1: delete #18816643 sell stop 0.10 GBPJPYm at 232.5800 sl: 233.3300 tp: 0.0000 ok
2007.01.02 22:29:25 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1: open #18816646 buy stop 0.10 GBPJPYm at 234.6600 sl: 233.9000 ok
2007.01.02 22:29:25 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1: delete #18816642 buy stop 0.10 GBPJPYm at 234.6500 sl: 233.9000 tp: 0.0000 ok
2007.01.02 22:29:25 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1:
2007.01.02 22:29:22 Ninja Tutle - Sys2 - Beta 4.2 EURUSDm,H1:
2007.01.02 22:29:21 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1: open #18816643 sell stop 0.10 GBPJPYm at 232.5800 sl: 233.3300 ok
2007.01.02 22:29:20 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1: delete #18816641 sell stop 0.10 GBPJPYm at 232.5700 sl: 233.3300 tp: 0.0000 ok
2007.01.02 22:29:20 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1: open #18816642 buy stop 0.10 GBPJPYm at 234.6500 sl: 233.9000 ok
2007.01.02 22:29:20 Ninja Tutle - Sys2 - Beta 4.2 GBPJPYm,H1: delete #18816639 buy stop 0.10 GBPJPYm at 234.6600 sl: 233.9000 tp: 0.0000 okVersion 4.3 Released
Hello,
4.3 version released fixed bug regarding zero divide issues that happens when terminal is opened then closed, please refer to first post to download new version. Thank you all for your help, pls report any more issues which you may encounter.
Kind Regards,
Mikhail
Stop loss?
I am currently in a trade USDJPY that was in profit ($30) but with the recent downturn is now losing $52 and has also opened another trade which is losing $30.
At the same time I was in profit by $130 trading USDCHF and fortunately manually closed off at $107.
Is there any protection in the way of trailing stop.
I have done very well with this EA by closing manually but recently I thought that the problem had been addressed and only closed off the one trade to observe the workings.
It is all demo but would like to be able to leave the EA without supervision.
The first entry on the attached statement had been in profit earlier and closed $93 down so all the rest of the trades were closed off manually when in profit
Thank you for the work done on this EA it usually gets into profit and I would like to preserve it.
John
I am currently in a trade USDJPY that was in profit ($30) but with the recent downturn is now losing $52 and has also opened another trade which is losing $30.
At the same time I was in profit by $130 trading USDCHF and fortunately manually closed off at $107.
Is there any protection in the way of trailing stop.
I have done very well with this EA by closing manually but recently I thought that the problem had been addressed and only closed off the one trade to observe the workings.
It is all demo but would like to be able to leave the EA without supervision.
The first entry on the attached statement had been in profit earlier and closed $93 down so all the rest of the trades were closed off manually when in profit
Thank you for the work done on this EA it usually gets into profit and I would like to preserve it.
JohnMy test also showed the similar results: many profits ended up with loss.
I have turned on the ATRBreakEven as "true". It still does not protect the profits. My setting are as follows:
extern double
Lots = 0.1; // Assign Fixed Lot Size to be traded,AutoLotSize must be false
extern int
MaxUnits = 3, //Maximum units to trade per Currency Pair
MagicNumber = 11282,
EntryLookBack = 55, //Bars to lookback in calculating breakout prices
ExitLookBack = 20, //Bars to lookback in calculating exit points
ATRPeriod = 20;
extern double
SLMultiple = 2.5, //Multiply ATR by this to calculate StopLoss
ReEntryMultiple = 0.5; //Multiple ATR by this to calculate Re Entry Point
extern bool
ATRBreakEven = true; //if set to true SL will be moved to break even level
extern double
BreakEvenMultiple = 2.5;
extern bool
LockProfit = true;
extern double
PipLockinStart = 50, //$ amount to start lock in
LockinPercent = 30;
My test also showed the similar results: many profits ended up with loss.
I have turned on the ATRBreakEven as "true". It still does not protect the profits.
Same here. This seems to have a great entry strategy, but a bad exit strategy. Looking at the charts in backtesting, it seems most of the trades where in profit for some time before going into a loss.
I was thinking a good trailing stop would work in percentages, but that percentage would decrease as the profits increased. For example, if the position is 10 pips in profit, the trailing stop would be 100% so that it would break even. At 20 pips it would be something like 75% or 15 pips, 30 pips would be 66% or 20 pips, etc etc. This way, the profitable position has some room to work in the more it is in profit, and we could limit it to a fixed amount at some point. It is frustrating to see a position in profit by 25 pips, only to end up with a 50 pip lost. I'd rather have a breakeven trade.
hello all,
doest the pip lock in work? I realeased version 4.3 and it should already be working. Also I understand how you feel, any suggestions on exits that you prefer we include in this EA? I was thinking about takeprofit level, when EA reaches a certain amount in profit it will close all positions. What do you think?
Thank you for pointing out your concerns, would love to hear your suggestions on how we could improve the exit strategy.
Kind Regards,
Mikhail
hello,
If you are already 50 pips in profit EA should lock in 30% of the pips, this is in 4.3 default settings. does it not show a value in piplock in on the upper right side comment?
Regards,
Mikhail
I am currently in a trade USDJPY that was in profit ($30) but with the recent downturn is now losing $52 and has also opened another trade which is losing $30.
At the same time I was in profit by $130 trading USDCHF and fortunately manually closed off at $107.
Is there any protection in the way of trailing stop.
I have done very well with this EA by closing manually but recently I thought that the problem had been addressed and only closed off the one trade to observe the workings.
It is all demo but would like to be able to leave the EA without supervision.
The first entry on the attached statement had been in profit earlier and closed $93 down so all the rest of the trades were closed off manually when in profit
Thank you for the work done on this EA it usually gets into profit and I would like to preserve it.
John