Expert Advisor on Remove, Closing chart

[Anton Christiaan Lombard]

I have written an expert advisor (admittedly first attempt) which uses a canvas as well as a cAppDialog to simulate the TradeView trade visualiser and it works great.

However, when removing the EA using the "Expert List" option on MT5, it also closes the chart to which the EA is bound.

I am clearly missing something basic in the logic and would appreciate guidance.

The code is pretty long but the Init and DeInit functions are as follows but do nothing special:

int OnInit()
  {
//--- Enabling events of mouse movements on the chart window
   ChartSetInteger(0, CHART_EVENT_MOUSE_MOVE, 1);
   buttons[0] = new CChartObjectButton;
   buttons[1] = new CChartObjectButton;
   buttons[0].Create(0, "goLong", 0, 10, 200, 90, 35);
   buttons[1].Create(0, "goShort", 0, 120, 200, 90, 35);
   buttons[0].BackColor(clrGreen);
   buttons[0].Color(clrWhite);
   buttons[1].BackColor(clrRed);
   buttons[1].Color(clrWhite);
   buttons[0].Description("Long");
   buttons[1].Description("Short");
   if(!ve.Visualize(vz)) //ve inherits cAppDialog and will only show when the canvas is double clicked
      return(INIT_FAILED);
//--- run application
   ve.Run();
   ve.Hide();
   EventSetTimer(1);
   ChartRedraw();
   return(INIT_SUCCEEDED);
  }

void OnDeinit(const int reason)
  {
   buttons[0].Delete();
   buttons[1].Delete();
   ve.Destroy(0);
   ChartRedraw();
  }

[Fernando Carreiro]

I have edited your post. In future please use the CODE button when you insert code.

[Anton Christiaan Lombard]

Fernando Carreiro #:

I have edited your post. In future please use the CODE button when you insert code.

Many thanks. Just as an update - not sure how it fixed the problem but I added a button to remove the Expert using the ExpertRemove() function and that did not close the chart, and oddly though, ever since then, removing the EA using MT5 Expert List dialog also does not remove the chart. I realise this does not help anyone but just an update on my process. As a guess, it may be that the debugger did not clean up some condition so it could be that there was no real problem to start with.

[Umair Ahmed]

Anton Christiaan Lombard #:

Many thanks. Just as an update - not sure how it fixed the problem but I added a button to remove the Expert using the ExpertRemove() function and that did not close the chart, and oddly though, ever since then, removing the EA using MT5 Expert List dialog also does not remove the chart. I realise this does not help anyone but just an update on my process. As a guess, it may be that the debugger did not clean up some condition so it could be that there was no real problem to start with.

thanks for this info, it is useful tip, just adding 1 more thing, we should explicitly Destroy() CAppDialog to avoid chart close issue on removing EA

Regads

Umair