I wanted to create my own function library because I often use the same functions in robots - MQL4 and MetaTrader 4

darirunu1 2021.07.12 17:24 #15381

//+------------------------------------------------------------------+
//|                                                  MACD Sample.mq4 |
//|                   Copyright 2005-2014, MetaQuotes Software Corp. |
//|                                              http://www.mql4.com |
//+------------------------------------------------------------------+
#property copyright   "2005-2014, MetaQuotes Software Corp."
#property link        "http://www.mql4.com"
input double TakeProfit    =2190;
input double Lots          =0.5;
input double TrailingStop  =650;
input int OpenLevel =70;
input int CloseLevel=23;
input int    Period =86;
input int    Period1 =87;
int LastBars=0;
extern int Magic1 = 110721;
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
void OnTick(void)
  {
   
 
   int    cnt,ticket,total;
//---
// initial data checks
// it is important to make sure that the expert works with a normal
// chart and the user did not make any mistakes setting external 
// variables (Lots, StopLoss, TakeProfit, 
// TrailingStop) in our case, we check TakeProfit
// on a chart of less than 100 bars
//---
//--- Trade only if new bar has arrived
   if(LastBars!=Bars) LastBars=Bars;
   else return(0);
   if(Bars<100)
     {
      Print("bars less than 100");
      return;
     }
   if(TakeProfit<10)
     {
      Print("TakeProfit less than 10");
      return;
     }
//--- to simplify the coding and speed up access data are put into internal variables
   if(CountOrders("", -1,Magic1)<1)
     
   total=OrdersTotal();
   if(total<1)
     {
      //--- no opened orders identified
      if(AccountFreeMargin()<(1000*Lots))
        {
         Print("We have no money. Free Margin = ",AccountFreeMargin());
         return;
        }
      //--- check for long position (BUY) possibility
     if(iRSI(NULL,0,OpenLevel,PRICE_LOW,Period)>iRSI(NULL,0,CloseLevel,PRICE_HIGH,Period1)) 
        {
         ticket=OrderSend(Symbol(),OP_BUY,Lots,Ask,3,Bid-TakeProfit*Point,Bid+TakeProfit*Point,"GBPCADD",Magic1,0,Green);
         if(ticket>0)
           {
            if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES))
               Print("BUY order opened : ",OrderOpenPrice());
           }
         else
            Print("Error opening BUY order : ",GetLastError());
         return;
        }
      //--- check for short position (SELL) possibility
      if(iRSI(NULL,0,OpenLevel,PRICE_LOW,Period1)<iRSI(NULL,0,CloseLevel,PRICE_HIGH,Period)) 
        {
         ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,3,Ask+TakeProfit*Point,Ask-TakeProfit*Point,"GBPCADD",Magic1,0,Red);
         if(ticket>0)
           {
            if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES))
               Print("SELL order opened : ",OrderOpenPrice());
           }
         else
            Print("Error opening SELL order : ",GetLastError());
        }
      //--- exit from the "no opened orders" block
      return;
     }
//--- it is important to enter the market correctly, but it is more important to exit it correctly...   
   for(cnt=0;cnt<total;cnt++)
     {
      if(!OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES))
         continue;
      if(OrderType()<=OP_SELL &&   // check for opened position 
         OrderSymbol()==Symbol()&& OrderMagicNumber()==Magic1)  // check for symbol
        {
         //--- long position is opened
         if(OrderType()==OP_BUY)
           {
            //--- should it be closed?
              if(iRSI(NULL,0,OpenLevel,PRICE_LOW,Period1)<iRSI(NULL,0,CloseLevel,PRICE_HIGH,Period)) 
              {
               //--- close order and exit
               if(!OrderClose(OrderTicket(),OrderLots(),Bid,3,Violet))
                  Print("OrderClose error ",GetLastError());
               return;
              }
            //--- check for trailing stop
            if(TrailingStop>0)
              {
               if(Bid-OrderOpenPrice()>Point*TrailingStop)
                 {
                  if(OrderStopLoss()<Bid-Point*TrailingStop)
                    {
                     //--- modify order and exit
                     if(!OrderModify(OrderTicket(),OrderOpenPrice(),Bid-Point*TrailingStop,OrderTakeProfit(),0,Green))
                        Print("OrderModify error ",GetLastError());
                     return;
                    }
                 }
              }
           }
         else // go to short position
           {
            //--- should it be closed?
           if(iRSI(NULL,0,OpenLevel,PRICE_LOW,Period)>iRSI(NULL,0,CloseLevel,PRICE_HIGH,Period1)) 
              {
               //--- close order and exit
               if(!OrderClose(OrderTicket(),OrderLots(),Ask,3,Violet))
                  Print("OrderClose error ",GetLastError());
               return;
              }
            //--- check for trailing stop
            if(TrailingStop>0)
              {
               if((OrderOpenPrice()-Ask)>(Point*TrailingStop))
                 {
                  if((OrderStopLoss()>(Ask+Point*TrailingStop)) || (OrderStopLoss()==0))
                    {
                     //--- modify order and exit
                     if(!OrderModify(OrderTicket(),OrderOpenPrice(),Ask+Point*TrailingStop,OrderTakeProfit(),0,Red))
                        Print("OrderModify error ",GetLastError());
                     return;
                    }
                 }
              }
           }
        }
     }
//---
  }
//+------------------------------------------------------------------+
//+----------------------------------------------------------------------------+
//| Подсчет ордеров                                                            |
//+----------------------------------------------------------------------------+
//| -1 - Все типы ордеров                                                      |
//|  0 - ордера типа BUY                                                       |
//|  1 - ордера типа SELL                                                      |
//|  2 - ордера типа BUYLIMIT                                                  |
//|  3 - ордера типа SELLLIMIT                                                 |
//|  4 - ордера типа BUYSTOP                                                   |
//|  5 - ордера типа SELLSTOP                                                  |
//+----------------------------------------------------------------------------+
int CountOrders(string symb="", int or_ty=-1, int magiс=-1) 
  {
   int cnt=0;
   if(symb=="0") symb=_Symbol;
   for(int pos=OrdersTotal()-1;pos>=0;pos--)
     {
      if(OrderSelect(pos,SELECT_BY_POS)==true)
        {
         if((OrderSymbol()==symb || symb=="")&&(or_ty<0 || or_ty==OrderType()))
           {
            if(magiс<0 || OrderMagicNumber()==magiс) cnt++;
           }
        }
     }
   return(cnt);
  }

Is this the right thing to do?

Tretyakov Rostyslav 2021.07.12 19:10 #15382

darirunu1:

Is this the right thing to do?

//--- to simplify the coding and speed up access data are put into internal variables
   if(CountOrders("", -1,Magic1)<1)
     
   total=OrdersTotal();
   if(total<1)

darirunu1 2021.07.13 13:39 #15383

MakarFX:

Thank you. It's complicated. I've made it simpler, just a couple of lines.

Tretyakov Rostyslav 2021.07.13 17:45 #15384

darirunu1:

Thank you. It's complicated. I made it simpler, just a couple of lines.

Interesting to see, if it's not too much trouble.

darirunu1 2021.07.14 01:31 #15385

MakarFX:
interesting to see if

for(i=k; i>=0; i--) {

if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)) {

if(OrderSymbol()==Symbol()) {

if(OrderMagicNumber()== Magic) {

{ if(OrderType()>1) continue;

if(OrderType()==OP_BUY || OrderType()==OP_SELL) total++;

}}}}

//---

// total=OrdersTotal();

if(total<1)

{

Andy Dufresne 2021.07.14 04:21 #15386

Hi all, I wanted to create my own function library because I often use the same functions in my robots. I've done everything right. I created the library, put it in the Libraries folder and plugged it in my indicator using #import

#import "andylib.ex4".

bool KeyPr (long l, string k);

string TestFunc ();

#import

Specified functions in the library with a description. But functions from the library are not called. I tried to put the dialog in the folder of indicators or even directly in the same folder with indicator, that connects to the dialog, without result. What may be the problem?

#import questions Questions from Beginners MQL5 Common data folder for

Vitaly Muzichenko 2021.07.14 05:23 #15387

Евгений Гуцу:

Hi all, I wanted to create my own function library because I often use the same functions in my robots. I've done everything right. I created the library, put it in the Libraries folder and plugged it in my indicator using #import

#import "andylib.ex4".

bool KeyPr (long l, string k);

string TestFunc ();

#import

Specified functions in the library with a description. But functions from the library are not called. I tried to put the dialog in the folder of indicators or even directly in the same folder with indicator, that connects to the dialog, without result. What may be the problem?

include

Документация по MQL5: Основы языка / Препроцессор / Включение файлов (#include)

www.mql5.com

Включение файлов (#include) - Препроцессор - Основы языка - Справочник MQL5 - Справочник по языку алгоритмического/автоматического трейдинга для MetaTrader 5

Tretyakov Rostyslav 2021.07.14 05:29 #15388

darirunu1:

for(i=k; i>=0; i--) {

if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)) {

if(OrderSymbol()==Symbol()) {

if(OrderMagicNumber()== Magic) {

{ if(OrderType()>1) continue;

if(OrderType()==OP_BUY || OrderType()==OP_SELL) total++;

}}}}

//---

// total=OrdersTotal();

if(total<1)

{

What you wrote can't work.

First you calculate "total++" and then you zero out and set "OrdersTotal()", i.e. all orders

Alexey Viktorov 2021.07.14 05:59 #15389

Евгений Гуцу:

Hi all, I wanted to create my own function library because I often use the same functions in my robots. I've done everything right. I created the library, put it in the Libraries folder and plugged it in my indicator using #import

#import "andylib.ex4".

bool KeyPr (long l, string k);

string TestFunc ();

#import

Specified functions in the library with a description. But functions from the library are not called. I tried to put the dialog in the folder of indicators or even directly in the same folder with indicator, that connects to the dialog, without result. What may be the problem?

Did you remember to write export after the function name in the library?

Better yet, don't make a library, but an .mqh file with functions, even without a class, and the compilation will take only those functions that are needed and are called from the EA/indicator.

Passing a struct as [ARCHIVE!] Any rookie question, [ARCHIVE] Any rookie question,

Aleksandr Egorov 2021.07.14 11:58 #15390

How to calculate a commission for open orders in mt5 for each pair separately?

Any questions from newcomers on MQL4 and MQL5, help and discussion on algorithms and codes - page 1539