EA doesnt close partial order, help tell me what is wrong

[mheathcote89]

im trying to close half an order using the below code but it does nothing

[Eleni Anna Branou]

Use the </> button to insert your code, do not insert it as a photo.

[William Roeder]

1. Please edit your (original) post and use the CODE button (Alt-S)! (For large amounts of code, attach it.)
             General rules and best pratices of the Forum. - General - MQL5 programming forum (2019)
             Messages Editor

2. There is no such order № zero.

3. You can't just use OrderLots()/2 because that is not a multiple of LotStep, and you can't close or have remaining less than MinLot.

4. You also must check if you have already done it, to avoid repeated closing. Alternatives:

   • Move SL to Break Even+1 before the partial close. That way, you know that you already did it.

   • Set a flag in persistent storage (files, global variables w/flush)

   • Open two orders initially, and close one (manually or by TP.)

5. Magic number only allows an EA to identify its trades from all others. Using OrdersTotal/OrdersHistoryTotal (MT4) or PositionsTotal (MT5), directly and/or no Magic number/symbol filtering on your OrderSelect / Position select loop means your code is incompatible with every EA (including itself on other charts and manual trading.)
             Symbol Doesn't equal Ordersymbol when another currency is added to another seperate chart . - MQL4 programming forum (2013)
             PositionClose is not working - MQL5 programming forum (2020.02.21)
             MagicNumber: "Magic" Identifier of the Order - MQL4 Articles (2006)
             Orders, Positions and Deals in MetaTrader 5 - MQL5 Articles 2011

   You need one Magic Number for each symbol/timeframe/strategy. Trade current timeframe, one strategy, and filter by symbol requires one MN.

[Carl Schreiber]

1. If you program isn't doing what you want use the debugger: https://www.mql5.com/en/articles/654
2. Use the styler (Ctrl + ,) for your code it's easier to understand.

[mheathcote89]

William Roeder #:

1. Please edit your (original) post and use the CODE button (Alt-S)! (For large amounts of code, attach it.)
             General rules and best pratices of the Forum. - General - MQL5 programming forum (2019)
             Messages Editor

2. There is no such order № zero.

3. You can't just use OrderLots()/2 because that is not a multiple of LotStep, and you can't close or have remaining less than MinLot.

4. You also must check if you have already done it, to avoid repeated closing. Alternatives:

   • Move SL to Break Even+1 before the partial close. That way, you know that you already did it.

   • Set a flag in persistent storage (files, global variables w/flush)

   • Open two orders initially, and close one (manually or by TP.)

5. Magic number only allows an EA to identify its trades from all others. Using OrdersTotal/OrdersHistoryTotal (MT4) or PositionsTotal (MT5), directly and/or no Magic number/symbol filtering on your OrderSelect / Position select loop means your code is incompatible with every EA (including itself on other charts and manual trading.)
             Symbol Doesn't equal Ordersymbol when another currency is added to another seperate chart . - MQL4 programming forum (2013)
             PositionClose is not working - MQL5 programming forum (2020.02.21)
             MagicNumber: "Magic" Identifier of the Order - MQL4 Articles (2006)
             Orders, Positions and Deals in MetaTrader 5 - MQL5 Articles 2011

   You need one Magic Number for each symbol/timeframe/strategy. Trade current timeframe, one strategy, and filter by symbol requires one MN.

Thanks, corrected the issue with int ticket = OrderTicket(); and then used that in the ticket ID.