Indicators: Fibo Bar MT5

New comment
 

Fibo Bar MT5:

Indicator that draws Fibonacci levels based on the last bar.

1

Author: Taras Slobodyanik

 

76.4% is not a valid Fibo level, it should be 78.6%.

176.4% is also not a valid level at all. 

 
Pawel Wojnarowski:

76.4% is not a valid Fibo level, it should be 78.6%.

176.4% is also not a valid level at all. 

Yes, it's not real Fibo levels. Also as 78.6 ;)
The real levels it is 1, 2, 3, 5, 8, 13, 21, 34, 55, 89, 144, 233, 377, 610, 987, …

You can set any, necessary to you, levels.

 

The author uploaded the wrong file.

There are no line colour settings.

Downloaded #property version "1.00"

 
Automated-Trading:

Fibo Bar MT5:

Author: Taras Slobodyanik


Is there a bug in the code?

Apparently it should be like this, then the settings appear

//extern string comm0=""; //- - - -- ---- FIBO ---- -- - - - -

input string comm0=""; //- - - -- ---- FIBO ---- -- - - - -

extern ENUM_TIMEFRAMES Fibo_Bar=PERIOD_D1; //Last Bar for Fibo

//input ENUM_TIMEFRAMES Fibo_Bar=PERIOD_D1; //Last Bar for Fibo

//extern colour fibo_color1=SkyBlue; //Upper colour

input colour fibo_color1=SkyBlue; //Upper colour

//extern colour fibo_color0=LimeGreen; //Main colour

input colour fibo_color0=LimeGreen; //Main colour

//extern colour fibo_color2=Orange; //Lower colour

input colour fibo_color2=Orange; //Lower colour

//extern ENUM_LINE_STYLE fibo_style=STYLE_DOT; //Style lines

input ENUM_LINE_STYLE fibo_style=STYLE_DOT; //Style lines

input int fibo_width=1; //Line Width


But this one is rejected ... why?

input ENUM_TIMEFRAMES Fibo_Bar=PERIOD_D1; //Last Bar for Fibo

 

Yes, the developers removed the "extern" operator from MQL5, it should be replaced with "input".

А на этот ругается ... почему?

delete the 45th line...

ps. I have a more advanced version of this indicator in my products

 
Taras Slobodyanik:

Yes, the developers removed the "extern" operator from MQL5, it should be replaced with "input".

delete the 45th line...

ps. I have a more advanced version of this indicator in my products.


Thanks for the advice! I'm trying to test MT5 and all the time there are some errors.
 
Taras Slobodyanik:

Yes, the developers removed the "extern" operator from MQL5, it should be replaced with "input".

delete the 45th line...

ps. I have a more advanced version of this indicator in my products.


Something in line 45 is this bracket }

41 int OnInit()

42 {

43 if(Fibo_Bar==PERIOD_CURRENT) Fibo_Bar=(ENUM_TIMEFRAMES)Period();

44 return(INIT_SUCCEEDED);

45 }

What should be removed?

 
You need to remove the line that the compiler frowns on - this is line 43.
 
Taras Slobodyanik:
You need to remove the line that the compiler frowns on - it's the 43rd line.


Thank you! I commented out the line.

41 int OnInit()

42 {

43 // if(Fibo_Bar==PERIOD_CURRENT) Fibo_Bar=(ENUM_TIMEFRAMES)Period();

44 return(INIT_SUCCEEDED);

45 }

The indicator worked.

 

I tried to use two indicators, but One Delete the others plots, so only we have to add a random in Label_prefix, and add the variable to the DeleteObjects function. Now you can use two indicators at the same time


int OnInit()

{

Label_prefix = (MathRand()%12 +1) + Label_prefix;

//if (Fibo_Bar==PERIOD_CURRENT) Fibo_Bar=(ENUM_TIMEFRAMES)Period();

return(INIT_SUCCEEDED);

}


void DeleteObjects ()

{

for (int i=ObjectsTotal(0,0,-1)-1;i>=0;i--)

{

string name=ObjectName(0,i,0,-1);

if (StringFind(name,Label_prefix,0)>=0)

ObjectDelete(0,name);

}

}

1234
New comment