Modify and existing EA and to create a addwinner function that increase the position size when position is positive.

MQL4 Indicatori Esperti

Lavoro terminato

Tempo di esecuzione 3 giorni
Feedback del cliente
Simply one of the best programmers that I encountered so far here. He managed to debug my existing EA and added some new features in it.
Feedback del dipendente
Best job. Happy working with him.

Specifiche

I only accept only programmer whose rating is good and also did more than 50 jobs.

I need the source code and also the programmer should allow me to test the code for 2 more days and to make reasonable adjustment if there is any problem with the code.

I need someone to make modification to an existing MQL4 EA

Attached is the EA, this EA is solely use on Dow Jones Industrial Average, NASDAQ and SPX.

//+------------------------------------------------------------------+
//|                                               Moving Average.mq4 |
//|                                                          Zhiming |
//|                         https://www.offshorecapitalsolutions.com |
//+------------------------------------------------------------------+
#property copyright "Zhiming"
#property link      "https://www.offshorecapitalsolutions.com"

//--- Trade Setup Module Inputs

extern string           Note0="Period for Moving Average";
extern int FastMA=5;
extern int FastMaShift=0;
extern ENUM_MA_METHOD      FastMaMethod=0;
extern ENUM_APPLIED_PRICE  FastMaAppliedTo=0;
extern int SlowMA=21;
extern int SlowMaShift=0;
extern ENUM_MA_METHOD      SlowMaMethod=0;
extern ENUM_APPLIED_PRICE  SlowMaAppliedTo=0;

extern string           Note1="ATR period for risk management";
extern int              ATRPeriod=20;
extern int              Number_Of_ATR=4;

//---Risk Reward Stop
extern string           Note2="Percentage at Risk and the Reward Ratio";
extern double           RiskPercent=2;
extern double           Reward_ratio=4;

//--- This part has to go with the Breakeven Module
extern string           Note3="If UseMoveToBreakeven=true, this will activate the Breakeven Stop";
extern bool             UseMoveToBreakeven=TRUE;
extern int              ATRToBreakeven=1;
extern double           ATRToLockIn=0.5;

//--- Trailing Stop Module
extern string           Note4="Trailing stop, UseTrailingStop = true will activate trailing stop";
extern bool             UseTrailingStop=TRUE;
extern double           KTATR=2;


//---Day and Date Filter
extern string           Note5="Day and Date Filter";
extern bool             Sunday = true;
extern bool             Monday = true;
extern bool             Tuesday = true;
extern bool             Wednesday = true;
extern bool             Thursday = true;
extern bool             Friday = true;
extern bool             NFP_Friday = true;
extern bool             NFP_ThursdayBefore = true;
extern bool             ChristmasHolidays = true;
extern double           XMAS_DayBeginBreak = 15;
extern bool             NewYearsHolidays = true;
extern double           NewYears_DayEndBreak = 3;

//---Time Filter Module
extern string           Note6="Time Filter";
extern bool             UseTimeFilter=false;
extern int              start_time_hour=22;
extern int              start_time_minute=0;
extern int              end_time_hour=18;
extern int              end_time_minute=0;
extern int              gmt=0;

//--- Syncronize the Tick Size and Lot Size Inputs
extern string           Note7="Magic Number";
extern int              MagicNumber=21013;

double pips;
bool  OrderModifyResult=false;

//+------------------------------------------------------------------+
//| Expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//---
   double ticksize = MarketInfo(Symbol(),MODE_TICKSIZE); //For FX
   if(ticksize == 0.00001 || Point==0.001)
   pips = ticksize*10;
   else pips = ticksize;
//---
   }
   
//+------------------------------------------------------------------+
//| Expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//---Delete all objects on chart------------------------------------------------------------------------------  

//------------------------------------------------------------------------------------------------------------
  }
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
int start()
  {
//---
if(OpenOrdersThisPair(Symbol())>=1) //Start scanning opportunity to move up breakeven and trailing stop
      {
         if(UseMoveToBreakeven)MoveToBreakeven(); 
         if(UseTrailingStop)AdjustTrail();
      }
   if(UseTimeFilter==1)
      {
         bool time_in_range=is_time_in_range(TimeCurrent(),start_time_hour,start_time_minute,end_time_hour,end_time_minute,gmt);
         if(time_in_range==1)
            {
               if(IsNewCandle())CheckForKTSRTrade();
               return(0);
            }
      } 
else
   
   if(UseTimeFilter==0)
      {
         if(IsNewCandle())CheckForKTSRTrade();
         return(0);
      }        
  } 
  
//+------------------------------------------------------------------+

int OpenOrdersThisPair(string pair) // This has to be include in part of the Order Entry and Modification Modules.
{
   int total=0;
      for(int i=OrdersTotal()-1;i>=0;i--)
      {
         OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
         if(OrderSymbol()==pair) total++;
      }
      return(total);
}   

bool IsNewCandle() //This is to reduce the computer burden
{
   static int BarsOnChart=0;
   if(BarsOnChart == Bars)
   return(false);
   BarsOnChart = Bars;
   return(true);
}

void CheckForKTSRTrade() //Trade Setup Mudule
{
   double PreviousFast = iMA(NULL,0,FastMA,FastMaShift,FastMaMethod,FastMaAppliedTo,2);
   double CurrentFast = iMA(NULL,0,FastMA,FastMaShift,FastMaMethod,FastMaAppliedTo,1);
   double PreviousSlow = iMA(NULL,0,SlowMA,SlowMaShift,SlowMaMethod,SlowMaAppliedTo,2);
   double CurrentSlow = iMA(NULL,0,SlowMA,SlowMaShift,SlowMaMethod,SlowMaAppliedTo,1);   
   if(PreviousFast < PreviousSlow && CurrentFast > CurrentSlow)OrderEntry(0);
   if(PreviousFast > PreviousSlow && CurrentFast < CurrentSlow)OrderEntry(1);
}


void OrderEntry(int direction) // Order Entry and Modification Modules.
{
   double tickvalue=MarketInfo(Symbol(),MODE_TICKVALUE);
   double LotSize=0;
   double Equity=AccountEquity();
   double RiskAmount=(Equity*RiskPercent*0.01)/tickvalue;
   double ATR_Risk=iATR(Symbol(),0,ATRPeriod,1);
   double ATR_Risk_Range=ATR_Risk*Number_Of_ATR;
   double buy_stop_price=Ask-ATR_Risk_Range;
   double pips_to_bsl=Ask-buy_stop_price;
   double buy_takeprofit_price=Ask+pips_to_bsl * Reward_ratio;
   double sell_stop_price=Bid+ATR_Risk_Range;
   double pips_to_ssl=sell_stop_price-Bid;
   double sell_takeprofit_price=Bid-pips_to_ssl* Reward_ratio;
   
if(direction==0)
   {
      double bsl=buy_stop_price;
      double btp=buy_takeprofit_price;
      LotSize = (RiskAmount/ (pips_to_bsl/pips) ) ;
      if(OpenOrdersThisPair(Symbol())==0)int buyticket=OrderSend(Symbol(),OP_BUY,LotSize,Ask,3,bsl,btp,NULL,MagicNumber,0,Green);
         if(buyticket>0)OrderModifyResult=OrderModify(buyticket,OrderOpenPrice(),bsl,btp,0,Green);
   }      
         
if(direction==1)
   {  
      double ssl=sell_stop_price;
      double stp=sell_takeprofit_price;
      LotSize = (RiskAmount/ (pips_to_ssl/pips) ) ; 
      if(OpenOrdersThisPair(Symbol())==0)int sellticket=OrderSend(Symbol(),OP_SELL,LotSize,Bid,3,ssl,stp,NULL,MagicNumber,0,Red);       
         if(sellticket>0)OrderModifyResult=OrderModify(sellticket,OrderOpenPrice(),ssl,stp,0,Red);
   }
}

//--- Trailing Stop Module Function
void AdjustTrail()
{
   int bar=0, i=0;
   double KTBTrailingStop=0.0, KTSTrailingStop=0.0;
   bool ans=false;

//buy order section
   for(int b=OrdersTotal()-1;b>=0;b--)
      {
      if(OrderSelect(b,SELECT_BY_POS,MODE_TRADES))
         if(OrderMagicNumber()==MagicNumber)
            if(OrderSymbol()==Symbol())
               if(OrderType()==OP_BUY)
                  {
                                        bar=iBarShift(Symbol(),0,OrderOpenTime());
                     KTBTrailingStop=iHigh(Symbol(),0, iHighest(Symbol(),0,MODE_HIGH,bar+1,0)) - KTATR * iATR(Symbol(),0,ATRPeriod,iHighest(Symbol(),0,MODE_HIGH,bar,1));
                        if(Bid - KTBTrailingStop > OrderStopLoss())
                        {
                           i=0;ans=false;
                           while(!ans&&i<3)
                           { 
                            if(i>0)Sleep(1000);
                            ans=OrderModify(OrderTicket(),OrderOpenPrice(),KTBTrailingStop,OrderTakeProfit(),0,clrOrange);
                            i++;
                           }//while(!ans&&i<3)
                        }
                   }
                }
  
//sell order section
   for(int s=OrdersTotal()-1;s>=0;s--)
      {
      if(OrderSelect(s,SELECT_BY_POS,MODE_TRADES))
         if(OrderMagicNumber()==MagicNumber)
            if(OrderSymbol()==Symbol())
               if(OrderType()==OP_SELL)
                                        {
                                        bar=iBarShift(Symbol(),0,OrderOpenTime());
                              KTSTrailingStop=iLow(Symbol(),0, iLowest(Symbol(),0,MODE_LOW,bar+1,0) ) + KTATR * iATR(Symbol(),0,ATRPeriod,iLowest(Symbol(),0,MODE_LOW,bar,1));
                              if(OrderStopLoss()> KTSTrailingStop - Ask)
                              {
                                 i=0;ans=false;
                                 while(!ans&&i<3)
                                 { 
                                  if(i>0)Sleep(1000);
                                  ans=OrderModify(OrderTicket(),OrderOpenPrice(),KTSTrailingStop,OrderTakeProfit(),0,clrOrange);
                                  i++;
                                 }
                              }
 
                                        }               
       }                 
}

void MoveToBreakeven() //Breakeven Stop Module
{
   double BEATR=iATR(NULL,0,ATRPeriod,1)*ATRToBreakeven;
   double LockInATR=iATR(NULL,0,ATRPeriod,1) * ATRToLockIn;
   for(int b=OrdersTotal()-1; b >= 0; b--)
      {
      if(OrderSelect(b,SELECT_BY_POS,MODE_TRADES))
         if(OrderMagicNumber()==MagicNumber) //If this is not true, it will not move down further
            if(OrderSymbol()==Symbol())   
               if(OrderType()==OP_BUY)
                  if(Bid-OrderOpenPrice()>BEATR) //This need to add the pips definition from ini init
                     if(OrderOpenPrice()>OrderStopLoss())
                        OrderModifyResult=OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()+(LockInATR),OrderTakeProfit(),0,Lime);                  
      }
   for(int s=OrdersTotal()-1; s >= 0; s--)
      {
      if(OrderSelect(s,SELECT_BY_POS,MODE_TRADES))
         if(OrderMagicNumber()==MagicNumber) //If this is not true, it will not move down further
            if(OrderSymbol()==Symbol())   
               if(OrderType()==OP_SELL)
                  if(OrderOpenPrice()-Ask>BEATR) //This need to add the pips definition from ini init
                     if(OrderOpenPrice()<OrderStopLoss())
                        OrderModifyResult=OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()-(LockInATR),OrderTakeProfit(),0,Lime);                  
      }  
}

//Day and Date Filter-----------------------------------------------------------------------------------------
bool DaytoTrade(){
bool daytotrade = false;

if(DayOfWeek() == 0 && Sunday) daytotrade = true;
if(DayOfWeek() == 1 && Monday) daytotrade = true;
if(DayOfWeek() == 2 && Tuesday) daytotrade = true;
if(DayOfWeek() == 3 && Wednesday) daytotrade = true;
if(DayOfWeek() == 4 && Thursday) daytotrade = true;
if(DayOfWeek() == 5 && Friday) daytotrade = true;
if(DayOfWeek() == 5 && Day() < 8 && !NFP_Friday ) daytotrade = false;
if(DayOfWeek() == 4 && Day() < 8 && !NFP_ThursdayBefore ) daytotrade = false;
if(Month() == 12 && Day() > XMAS_DayBeginBreak && !ChristmasHolidays ) daytotrade = false;
if(Month() == 1 && Day() < NewYears_DayEndBreak && !NewYearsHolidays ) daytotrade = false;

return(daytotrade);}

//------------------------------------------------------------------------------------------------------------

//Time Filter-------------------------------------------------------------------------------------------------
bool is_time_in_range(datetime time,int start_hour,int start_min,int end_hour,int end_min,int gmt_offset=0)
  {
   if(gmt_offset!=0)
     {
      start_hour+=gmt_offset;
      end_hour+=gmt_offset;
     }
   if(start_hour>23) start_hour=(start_hour-23)-1;
   else if(start_hour<0) start_hour=23+start_hour+1;
   if(end_hour>23) end_hour=(end_hour-23)-1;
   else if(end_hour<0) end_hour=23+end_hour+1;
   int hour=TimeHour(time);
   int minute=TimeMinute(time);
   int t = (hour*3600)+(minute*60);
   int s = (start_hour*3600)+(start_min*60);
   int e = (end_hour*3600)+(end_min*60);
   if(s==e)
      return true;
   else if(s<e)
     {
      if(t>=s && t<e)
         return true;
     }
   else if(s>e)
     {
      if(t>=s || t<e)
         return true;
     }
   return false;
  }
  
//------------------------------------------------------------------------------------------------------------

In this EA, the trailing stop is suppose to:

For buy trade, it will look at the highest high bar after the buy trade is initiated. Based on the high of the highest bar and minus off ATR(s) of the previous bar and come out with KTBTrailingStop. If the existing stoploss and the order entry price is below the KTBTrailingStop, then modify the existing stop to KTBTrailingStop. If the KTBTrailingStop is below the order entry price and the existing stop loss price, do not make any changes.

For sell trade, it will look at the lowest low bar after the sell trade is initiated. Based on the low of the lowest bar and plus ATR(s) of the previous bar and come out with KTSTrailingStop. If the existing stoploss and the order entry price is above the KTSTrailingStop, then modify the existing stop to KTSTrailingStop. If the KTSTrailingStop is above the order entry price and the existing stop loss price, do not make any changes.

For the trailing stop, I noticed the existing code did not trigger after the conditions are met. Please see if there are any changes need to be made.

The existing breakeven stop works perfectly but I am not sure if the int start() is correctly written. What I want is:

1.      if the UseMoveToBreakeven=FALSE and the UseTrailingStop=TRUE, the EA should be able to use TrailingStop only and should not be using the BreakevenStop.

2.      if the UseMoveToBreakeven=FALSE and the UseTrailingStop=FALSE, the EA should not be able to use TrailingStop and should not be using the BreakevenStop.

3.      if the UseMoveToBreakeven=TRUE and the UseTrailingStop=FALSE, the EA should not be able to use TrailingStop only and should be using the BreakevenStop.

4.      if the UseMoveToBreakeven=TRUE and the UseTrailingStop=TRUE, the EA should be able to use TrailingStop and the BreakevenStop.

So upon initiate a position, if the price moves to its favour and trigger the breakeven loss function, the stoploss will move toward the level determined by the breakeven function.

If the price did not move in favour and did not trigger the breakeven loss function, the stop loss should stay at the risk level.

After the price triggered the breakeven function, it will depend on the trailing stop function without changing the price target.

For the OrderSend part, I need the EA to do resend the order if there is any error. The resend of order should look something like:

for(int i=OrderTotal()-1; i >=0;i--)
{       
        if(OrderSelect(i,SELECT_BY_POS, MODE_TRADES))
        {
                if(OrderType()==OP-BUY && OrderMagicNumber()==Magic Number)
                {
                        while(true)
                        {
                                bool result = OrderClose(OrderTicket(),OrderLots(),Bid, 3, Red);
                                if(result!= true)
                                {
                                        int err = GetLastError(); Print("LastError = ",err);
                                }
                                else err = 0;
                                switch(err)
                                {
                                        case 135://ERR_PRICE_CHANGED
                                        case 136://ERR_OFF_QUOTES
                                        case 137://ERR_BROKER_BUSY
                                        case 138://ERR_REQUOTE
                                        case 146:sleep(1000);RefreshRates();i++;break;//ERR_TRADE_CONTEXT_BUSY
                                }
                        }
                }
        }
}

Also need to create a function for the EA to add on more position when the existing position is making profit.  This add more winning position function should only be activated when the price moves in favour of the position by 3 ATRs and when a new high is formed after a long position is initiated or a new low is formed after a short position is initiated.

There should be an input to key in the factor (1-10) and for the ATR that moves in the favour of the position as well.  

Since this function is similar with the trailing stop function, it should come in before the trailing stop function. It should add on more position before the EA moves higher for the long trailing stop and before the EA moves lower for the short tailing stop.

The input should have a bool UseAddWinner=TRUE to activate this function and the function should start with AddWinner() just like the way I do it for AdjustTrail()

The example is below.

Long Position

Current long Position 5 contract and average cost is 24,600

Highest high after initiate long position 24,900

Offer price now is 24,871 and the bid price is 24,870.9

Stop loss price is 24,720

Factor = 3

Average price after buy more contract = ((Stop Loss Price – Average Price) * (1/Factor)) + Average Price

((24,720 - 24,600) * (1/3)) + 24,600 = 24,640

Calculation to buy number of contract = Current Long Position / ((Offer Price - Average price after buy more contract) / (Average price after buy more contract - Current Average Price))

5 / ((24,871 - 24,640) / (24,640 - 24,600))

= 0.866

Round down to the nearest 2 decimal place = 0.86

 

Short Position

Current short Position 3.5 contract and average cost is 24,700

Lowest low after initiate long position 24200

Offer price now is 24,351 and the bid price is 24,350.9

Stop loss price is 24,500

Factor = 3

Average price after short more contract = ((Stop Loss Price – Current Average Price) * (1/Factor)) + Current Average Price

((24,500 - 24,700) * (1/3)) + 24,700 = 24,633.33

Calculation to short number of contract = Current Short Position / ((Bid Price - Average price after short more contract)/(Average price after short more contract – Current Average Price))

3.5 / ((24,350.9 - 24,633.33) / (24,633.33 - 24,700))

= 0.826

Round down to the nearest 2 decimal place = 0.82









Con risposta

1
Sviluppatore 1
Valutazioni
(277)
Progetti
334
55%
Arbitraggio
14
36% / 29%
In ritardo
1
0%
Gratuito
Ordini simili
This is yakubu Jnr trading bots I create the trading robots to help my self and others traders to be successful please you can join my live trading bots or subscribe to my trading robots
Nyasco 90+ USD
Fast trading bot for starters less losses which leads to bigger profits made for thousands of people making billions of dollars .be the best trader for your self all the way
Nyasco 30+ USD
Faster robot with less losses which can be used for a long term earning money every day creating a bot for more than thousands of people to earn billions of money
Max amount grid 30+ USD
max amount grid step for magic number do keep deleting .only when it is in negative floating .but when it is profit allow to go over the max and replays to grid step
Apply with a screen of your work . Symbol Specific Logic . Live Chart Optimization Check the Core logic . [back tests as well] Change points to pips . Create buffer for the zone
I will pay 3000+ USD (negotiable) for an EA for existing MT5 that generates a minimum of 15-20% or higher a month consistently (provide source code after final deal) Looking for a highly profitable EA Please send demo version directly subject (Buying profitable EA Budget up to $ 3000 USD), past results and optimal settings so I can test, if it performs in a strategy tester i will also need option to forward test it
EA fx 30+ USD
Hello, I need an already developed EA similar to the one trading XAUUSD, with consistent entries and good risk management. Before we proceed, I would like to verify its performance. Please provide a live or demo account login along with the investor (read-only) password so I can monitor the trading results. I am looking for stable performance, controlled drawdown, and consistent profit on gold (XAUUSD). Once I
The strategy records the highest and lowest prices within a specified duration (default 15 minutes) after the New York market opens, forming the opening range. Post-Formation Breakout: When the price breaks above or below the opening range after its formation, it may indicate the direction of the day’s price movement. Trend Confirmation: The strategy uses two EMAs (default 20-period and 50-period) as trend filters to
Tengo una estrategia basada en divergencia para el oro sobre todo en tf m1 Basado en divergencia con stoch .. confirmando la entrada con ciertos parameteos de entrada Es mejor conversarlo para dar mejor los detalles Cuando entrar, porque o todas las divergencias se debe tomar para entrar en compras o ventas He adjuntado un ejemplo La confrmacion más exacta es el cruce de esos parámetros de stoch edebajo de level de

Informazioni sul progetto

Budget
30+ USD