A function to loop through open positions and make pairs of arrays of tickets then close each pair of array if greater than target profit

MQL4 Experts

Job finished

Execution time 6 minutes
Feedback from customer
very good!
Feedback from employee
Great customer! Thank you for the order!

Specification

This is for an MT4 EA.

I need a function to loop through all open positions and store them in arrays based on price levels.
Then from these arrays (i.e. @ price 1760 there are open orders and @ price 1770 there are open orders and so on).
I want to calculate the ongoing profit of pairs of 2 arrays (i.e. sell array i with buy array i+1     AND    buy array i with sell array i-1).
And if profit is greater than target, close orders of these pairs of arrays. Each array may contain more than 1 ticket and can go up to x tickets, and the function will close the arrays only if the pairs contain minimally an array in each level.
The function will loop through all the arrays crawling from initial price up and down.
An optional function can also close the pairs of arrays if the total tickets in these pairs are x (can be input).
Code is already written, but i currently have problem with :

void CalculateAndCloseOrderGroupsForBuyAndSell() {
    // Loop from the initial_index down to 1 (since i-1 sell for i=0 doesn't exist)
    for (int i = initial_index; i > 0; i--) {
        double totalProfit = 0.0;
        
        if (buyTicketCounts[i] > 0 && sellTicketCounts[i-1] > 0){
           // Calculate profit for all buy tickets at index i
           for (int j = 0; j < buyTicketCounts[i]; j++) {
               int ticket = buyTickets[i][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
   
           // Calculate profit for all sell tickets at index i-1
           for (int j = 0; j < sellTicketCounts[i - 1]; j++) {
               int ticket = sellTickets[i - 1][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
          }

        // If the combined profit meets or exceeds the target, close the tickets and remove them from arrays
        if (totalProfit >= profit_target) {
            // Close and remove buy tickets at index i
            for (int j = buyTicketCounts[i] - 1; j >= 0; j--) {
                CloseOrder(buyTickets[i][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < buyTicketCounts[i] - 1; k++) {
                    buyTickets[i][k] = buyTickets[i][k + 1];
                }
                buyTicketCounts[i]--;
            }

            // Close and remove sell tickets at index i-1
            for (int j = sellTicketCounts[i - 1] - 1; j >= 0; j--) {
                CloseOrder(sellTickets[i - 1][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < sellTicketCounts[i - 1] - 1; k++) {
                    sellTickets[i - 1][k] = sellTickets[i - 1][k + 1];
                }
                sellTicketCounts[i - 1]--;
            }

            Print("Closed and removed orders for buy zone ", i, " and sell zone ", i - 1, " with total profit: ", totalProfit);
        }
    }
}


it always gives me "out of array" error. I will give the whole set of code. the focus is to fix this part to overcome the "out of array" issue/ error.


Thank you.




Responded

1
Developer 1
Rating
(100)
Projects
125
23%
Arbitration
12
0% / 75%
Overdue
22
18%
Free
2
Developer 2
Rating
(72)
Projects
80
10%
Arbitration
38
8% / 58%
Overdue
6
8%
Free
3
Developer 3
Rating
(53)
Projects
91
52%
Arbitration
2
0% / 50%
Overdue
1
1%
Free
4
Developer 4
Rating
(23)
Projects
45
20%
Arbitration
25
28% / 48%
Overdue
12
27%
Free
5
Developer 5
Rating
(67)
Projects
97
35%
Arbitration
11
27% / 45%
Overdue
13
13%
Free
6
Developer 6
Rating
(611)
Projects
712
33%
Arbitration
45
49% / 42%
Overdue
14
2%
Working
7
Developer 7
Rating
(6)
Projects
10
10%
Arbitration
9
0% / 89%
Overdue
1
10%
Free
8
Developer 8
Rating
(69)
Projects
146
34%
Arbitration
13
8% / 62%
Overdue
26
18%
Free
Published: 6 codes
9
Developer 9
Rating
(568)
Projects
641
41%
Arbitration
25
48% / 36%
Overdue
46
7%
Working
Similar orders
Looking for an Experienced MQL4/MQL5 Developer to Build a Professional Scalping Expert Advisor (EA) I am looking for an experienced MQL4/MQL5 developer to build a professional Expert Advisor (EA) for MetaTrader 4 or MetaTrader 5 from scratch. My goal is to develop a high-quality scalping system with strong risk management and long-term profitability potential. I am not looking for unrealistic promises or "100%
void OnTick() { // Check if we already have an open trade if(OrdersTotal() == 0) { // Get the value of a 14-period Moving Average double ma = iMA(Symbol(), 0, 14, 0, MODE_SMA, PRICE_CLOSE, 0); // Basic Condition: If current close price moves above the MA, buy if(Close[0] > ma) { int ticket = OrderSend(Symbol(), OP_BUY, 0.1, Ask, 3, 0, 0, "My First Bot", 0, 0, clrGreen); } } }
i brought an EA called profit hunter killer and the file is not working any more its a scalper type EA can anyone here decomplie the file as i cam not abe to reach the seller i brought it on Shopee malaysian website
Recently I have backtested more than 100 EAs and I have come to a conclusion that in the long-term all of them produce catastrophic results. I used 99.9% data quality and whenever possible decades of data. In the short-term almost all of them can have nice gains. But there is hardly any EA that could survive even just 3-5 years, let alone decades ! This got me thinking: if almost all EAs are unfit for long-term
I need to connect my online store to the NinjaTrader API for automated order fulfillment and license creation/revocation. If you have experience integrating with the NinjaTrader Ecosystem API or implementing vendor licensing, please contact me with your relevant experience and approach
I am looking for an experienced MQL5 developer to convert a TradingView indicator into an MT5 indicator. The objective is to recreate the TradingView indicator in MQL5 so that it produces the same calculations, plots, values, and signals as closely as possible. Requirements: Convert the TradingView Pine Script into an MT5 indicator (.mq5). Ensure the MT5 version matches the TradingView version as accurately as
EA WILL BE FOR GBPUSD ON M5 TIMEFRAME. IT IS A REJECTION/REVERSAL STRATEGY. IT FOCUSES ON BREAK OF LEVEL (M5 CANDLE CLOSE ABOVE HIGH, BELOW LOW (ASIA HIGH/LOW, YESTERDAYS HIGH/LOW, LAST WEEK HIGH/LOW, AND THEN ALSO SWING LEVELS BREAK AND REVERSALS BOTH INSIDE AND OUTSIDE PRICE ACTION) IN THIS STRATEGY WICKS ARE IGNORED, ONLY A SOLID CANDLE BREAK AND CLOSE AND REVERSAL CONSTITUTES AS A VALID TRADE. * EA TIME START +
1) The EA must identity CRT High and CRT Low ,,,,, it must wait for liquidity sweep before entering a trade ,,,to confirm the trade only after sweep and market structure confirmation and support buy and sell trades ,,,,risk. Should be adjustable (default 1% per trade) ,,stop loss should be placed beyond the liquidity sweep ,,take profit should be adjustable with risk reward from 1:2 to 1:5 ,,should allow trading only
Hello, I want a simple bot for NinjaTrader8. I need a bot that operates automatically on Nasdaq (NQ/MNQ). Requirements: open buys and sells following a simple trend strategy, configurable stop loss and take profit, risk per trade of 1 to 2% of capital, if it loses 3% in a day, stop trading until the next day. Compatible with backtesting, delivery of the source code and the working bot in NinjaTrader 8. My initial
a { text-decoration: none; color: #464feb; } tr th, tr td { border: 1px solid #e6e6e6; } tr th { background-color: #f5f5f5; } Project Overview I am looking for an experienced algorithmic trading developer to build a professional Expert Advisor (EA) for MetaTrader 5 and/or cTrader. The objective is to create a robust automated trading system focused exclusively on XAUUSD (Gold) . This project is intended for serious

Project information

Budget
30 - 45 USD