A function to loop through open positions and make pairs of arrays of tickets then close each pair of array if greater than target profit

MQL4 Experts

Job finished

Execution time 6 minutes
Feedback from customer
very good!
Feedback from employee
Great customer! Thank you for the order!

Specification

This is for an MT4 EA.

I need a function to loop through all open positions and store them in arrays based on price levels.
Then from these arrays (i.e. @ price 1760 there are open orders and @ price 1770 there are open orders and so on).
I want to calculate the ongoing profit of pairs of 2 arrays (i.e. sell array i with buy array i+1     AND    buy array i with sell array i-1).
And if profit is greater than target, close orders of these pairs of arrays. Each array may contain more than 1 ticket and can go up to x tickets, and the function will close the arrays only if the pairs contain minimally an array in each level.
The function will loop through all the arrays crawling from initial price up and down.
An optional function can also close the pairs of arrays if the total tickets in these pairs are x (can be input).
Code is already written, but i currently have problem with :

void CalculateAndCloseOrderGroupsForBuyAndSell() {
    // Loop from the initial_index down to 1 (since i-1 sell for i=0 doesn't exist)
    for (int i = initial_index; i > 0; i--) {
        double totalProfit = 0.0;
        
        if (buyTicketCounts[i] > 0 && sellTicketCounts[i-1] > 0){
           // Calculate profit for all buy tickets at index i
           for (int j = 0; j < buyTicketCounts[i]; j++) {
               int ticket = buyTickets[i][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
   
           // Calculate profit for all sell tickets at index i-1
           for (int j = 0; j < sellTicketCounts[i - 1]; j++) {
               int ticket = sellTickets[i - 1][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
          }

        // If the combined profit meets or exceeds the target, close the tickets and remove them from arrays
        if (totalProfit >= profit_target) {
            // Close and remove buy tickets at index i
            for (int j = buyTicketCounts[i] - 1; j >= 0; j--) {
                CloseOrder(buyTickets[i][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < buyTicketCounts[i] - 1; k++) {
                    buyTickets[i][k] = buyTickets[i][k + 1];
                }
                buyTicketCounts[i]--;
            }

            // Close and remove sell tickets at index i-1
            for (int j = sellTicketCounts[i - 1] - 1; j >= 0; j--) {
                CloseOrder(sellTickets[i - 1][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < sellTicketCounts[i - 1] - 1; k++) {
                    sellTickets[i - 1][k] = sellTickets[i - 1][k + 1];
                }
                sellTicketCounts[i - 1]--;
            }

            Print("Closed and removed orders for buy zone ", i, " and sell zone ", i - 1, " with total profit: ", totalProfit);
        }
    }
}


it always gives me "out of array" error. I will give the whole set of code. the focus is to fix this part to overcome the "out of array" issue/ error.


Thank you.




Responded

1
Developer 1
Rating
(100)
Projects
125
23%
Arbitration
12
0% / 75%
Overdue
22
18%
Free
2
Developer 2
Rating
(72)
Projects
80
10%
Arbitration
38
8% / 58%
Overdue
6
8%
Free
3
Developer 3
Rating
(53)
Projects
91
52%
Arbitration
2
0% / 50%
Overdue
1
1%
Free
4
Developer 4
Rating
(23)
Projects
45
20%
Arbitration
25
28% / 48%
Overdue
12
27%
Free
5
Developer 5
Rating
(67)
Projects
97
35%
Arbitration
11
27% / 45%
Overdue
13
13%
Free
6
Developer 6
Rating
(563)
Projects
651
33%
Arbitration
41
41% / 46%
Overdue
11
2%
Busy
7
Developer 7
Rating
(6)
Projects
10
10%
Arbitration
9
0% / 89%
Overdue
1
10%
Free
8
Developer 8
Rating
(69)
Projects
146
34%
Arbitration
13
8% / 62%
Overdue
26
18%
Free
Published: 6 codes
9
Developer 9
Rating
(568)
Projects
641
41%
Arbitration
25
48% / 36%
Overdue
46
7%
Working
Similar orders
* After every loss, It does not increase the lot sizes gradually. For example, after a loss of 0.01, it goes straight to 0.05 lots. It does not follow progressive order. 0.01;0.02;0.03;0.04;0.05... etc. From 0.01, it goes straight to 0.05 * Also If there is a win, it does not return to 0.01 it continues on the last lot size 0.06. After every win the EA should start again at 0.01 * I would also like to adjust the
Società di investimento con attività tra Sanremo e Monaco ricerca un giovane collaboratore con esperienza nell’utilizzo avanzato di MetaTrader 5. Si richiede la conoscenza della lingua italiana e inglese. Attività Il collaboratore si occuperà di: • eseguire backtest di strategie di trading su MT5 • effettuare ottimizzazioni parametri tramite Strategy Tester • analizzare risultati e robustezza delle strategie •
I want to create a loss recovery account.I have a zone recovery EA.It sometimes gives more buy sell entries than the target. This causes a lot of loss. I want to create an EA to reduce that loss by 40% to 50%. Example: My EA has lost $2200 with a buy sell entry. Now the new EA will give an entry that can reduce the loss from $2200 to $700
I am looking for an experienced MT5 developer to build a custom, aggressive XAUUSD scalping EA with structured basket management and momentum continuation logic. This is not a generic EA — it requires careful architecture and proper risk control. Key Requirements: Instrument & Timeframes: XAUUSD only M1 execution chart M5/M15 for directional bias and structure context Execution & Basket Logic: Aggressive basket-style
I need any highly profitable MT5 robot which trades any sythetic indices on deriv very profitably. It should have good risk management and any good strategy The EA should have good risk management and can trade small accounts like 50 - 100USD Developers who have already made robots have higher chance
CHOSEN'S BOT 30 - 50 USD
I need a scalping AI that is based on proper risk management. I want my AI to be 90%-100% profitable, it must be able to analyze the behavior of the market and take trades on it's own as the market goes.My AI must be able to work on the 1min, 5mins,15mins, 30mins and 1hour time frame only. Developer must produce your own strategy ideas for it to be highly profitable. The AI must have SL and TP. This AI must work only
I am seeking an experienced MQL5 developer to build a fully automated Expert Advisor (EA) based on Opening Range Breakout (ORB) and Fair Value Gap (FVG) concepts. The developer must have a strong understanding of these strategies and agree to the following requirements: ✅ Project Requirements & Terms 1. Functional EA Demonstration (Mandatory) The developer must demonstrate a fully functional EA that operates exactly
Mk 30+ USD
I need a fully automated trading robot designed to generate consistent profits while strictly controlling risk and minimizing losses. The robot should use a combination of strategies, including trend-following, scalping, and price action, and must be able to adapt to different market conditions such as trending and ranging markets. It should analyze the market using indicators like Moving Averages, RSI, MACD, and
Seeking developer service to code an EA. Interested developer must have good experience and understanding on how ORB and FVG works, and agreed to the terms below : 1. Shall demonstrate a fully functional EA that operates as specified in the requirement and function automatically as requested in real-time environment (forward test - demo/live), regardless of good results obtained in strategy-tester. Backtesting
Hey guys, looking for a crazy good EA / Indicator that can either help me for futures trading (eg. Topstep, Lucid Trading etc) https://t.me/nqsniperz - telegram Or looking for a CFD EA that i can run on personal accounts Budget is very high and negotiable. https://t.me/nqsniperz

Project information

Budget
30 - 45 USD