A function to loop through open positions and make pairs of arrays of tickets then close each pair of array if greater than target profit

MQL4 Experts

Job finished

Execution time 6 minutes
Feedback from employee
Great customer! Thank you for the order!
Feedback from customer
very good!

Specification

This is for an MT4 EA.

I need a function to loop through all open positions and store them in arrays based on price levels.
Then from these arrays (i.e. @ price 1760 there are open orders and @ price 1770 there are open orders and so on).
I want to calculate the ongoing profit of pairs of 2 arrays (i.e. sell array i with buy array i+1     AND    buy array i with sell array i-1).
And if profit is greater than target, close orders of these pairs of arrays. Each array may contain more than 1 ticket and can go up to x tickets, and the function will close the arrays only if the pairs contain minimally an array in each level.
The function will loop through all the arrays crawling from initial price up and down.
An optional function can also close the pairs of arrays if the total tickets in these pairs are x (can be input).
Code is already written, but i currently have problem with :

void CalculateAndCloseOrderGroupsForBuyAndSell() {
    // Loop from the initial_index down to 1 (since i-1 sell for i=0 doesn't exist)
    for (int i = initial_index; i > 0; i--) {
        double totalProfit = 0.0;
        
        if (buyTicketCounts[i] > 0 && sellTicketCounts[i-1] > 0){
           // Calculate profit for all buy tickets at index i
           for (int j = 0; j < buyTicketCounts[i]; j++) {
               int ticket = buyTickets[i][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
   
           // Calculate profit for all sell tickets at index i-1
           for (int j = 0; j < sellTicketCounts[i - 1]; j++) {
               int ticket = sellTickets[i - 1][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
          }

        // If the combined profit meets or exceeds the target, close the tickets and remove them from arrays
        if (totalProfit >= profit_target) {
            // Close and remove buy tickets at index i
            for (int j = buyTicketCounts[i] - 1; j >= 0; j--) {
                CloseOrder(buyTickets[i][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < buyTicketCounts[i] - 1; k++) {
                    buyTickets[i][k] = buyTickets[i][k + 1];
                }
                buyTicketCounts[i]--;
            }

            // Close and remove sell tickets at index i-1
            for (int j = sellTicketCounts[i - 1] - 1; j >= 0; j--) {
                CloseOrder(sellTickets[i - 1][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < sellTicketCounts[i - 1] - 1; k++) {
                    sellTickets[i - 1][k] = sellTickets[i - 1][k + 1];
                }
                sellTicketCounts[i - 1]--;
            }

            Print("Closed and removed orders for buy zone ", i, " and sell zone ", i - 1, " with total profit: ", totalProfit);
        }
    }
}


it always gives me "out of array" error. I will give the whole set of code. the focus is to fix this part to overcome the "out of array" issue/ error.


Thank you.




Responded

1
Developer 1
Rating
(100)
Projects
125
23%
Arbitration
12
0% / 75%
Overdue
22
18%
Free
2
Developer 2
Rating
(72)
Projects
80
10%
Arbitration
38
8% / 58%
Overdue
6
8%
Free
3
Developer 3
Rating
(53)
Projects
91
52%
Arbitration
2
0% / 50%
Overdue
1
1%
Free
4
Developer 4
Rating
(23)
Projects
45
20%
Arbitration
25
28% / 48%
Overdue
12
27%
Free
5
Developer 5
Rating
(67)
Projects
97
35%
Arbitration
11
27% / 45%
Overdue
13
13%
Free
6
Developer 6
Rating
(641)
Projects
749
34%
Arbitration
50
52% / 38%
Overdue
14
2%
Working
7
Developer 7
Rating
(6)
Projects
10
10%
Arbitration
9
0% / 89%
Overdue
1
10%
Free
8
Developer 8
Rating
(69)
Projects
146
34%
Arbitration
13
8% / 62%
Overdue
26
18%
Free
Published: 6 codes
9
Developer 9
Rating
(568)
Projects
641
41%
Arbitration
25
48% / 36%
Overdue
46
7%
Working
Similar orders
Bestehenden MT5-EA prüfen und Wartungsfunktion ergänzen Mein selbst entwickelter EA „MARC HybridTrend“ hat einen dauerhaft gespeicherten Peak-Halt und keine eingebaute Wiederfreigabefunktion. Vollständiger MQL5-Quellcode und eine Funktionsspezifikation sind vorhanden. Gewünscht ist eine ausdrücklich bestätigte Wartungsfunktion mit Integritätsprüfung, Wiederholungsschutz und nachvollziehbarer Protokollierung
EA Application & MT5 Account Verification Requirements To apply, you must already have your EA running on an active MT5 trading account connected to the market. The account must have genuine trading history that can be independently reviewed and verified. EA Requirements 1. Prop-Firm Compatible Risk Management - The EA must include daily and overall drawdown protection. - Required inputs: "MaxDailyLoss = 5%"
Seeking Experienced Forex EA Developer – Currency Strength Meter Strategy Optimization (MT4/MT5) I am looking for an experienced Forex EA developer and quantitative trading strategist to help improve, optimize, and professionally test my existing Expert Advisor (EA). My EA is based on a Currency Strength Meter strategy, which identifies strong and weak currencies and automatically executes trades by pairing a strong
I need someone to develop a simple EA that makes random orders. Just random orders no indicators needed. I should be able to set my TP and SL of choice
Project Overview We are looking for talented and experienced programmers, MQL5 developers, algorithmic traders, Forex automation specialists and trading system developers for an MT5 Gold (XAUUSD) Scalping EA development project. We welcome applications from developers with different backgrounds in automated trading, Expert Advisors, algorithmic strategies, trading indicators and financial technology. Our objective is
EA RE 200+ USD
EA Application & MT5 Account Verification Requirements To apply, you must already have your EA running on an active MT5 trading account connected to the market. The account must have genuine trading history that can be independently reviewed and verified. EA Requirements 1. Prop-Firm Compatible Risk Management - The EA must include daily and overall drawdown protection. - Required inputs: "MaxDailyLoss = 5%"
Smart Fibo indicator 30 - 100 USD
Can you create a Smart Tool Like a Smart Fib Just one click on where you position your highest point or the Low to high. with color for each percent
the job underlying algorithms. An algorithm is a set of actions that need to be performed in response to certain events. For example, the most common task in algo trading is the identification of the "New bar" event . When the event occurs, the robot checks the emergence of trading signals and acts accordingly. Before you decide to program or order a trading robot, you need to formulate a trading system with clear
I have an existing C# trading strategy that I’d like to integrate into Quantower’s Strategy Manager so I can manage, configure, and execute it directly within the platform. I’m looking for a developer familiar with Quantower C# to handle the integration
I am looking for a quantitative strategy researcher and MQL5 developer to help research, validate and prototype a fast automated XAUUSD trading system for MT5. The target is tick-level trading with positions typically held for seconds, closely spaced entries, and configurable bursts of multiple positions during a qualifying opportunity. IMPORTANT: We do not yet have a validated profitable strategy. I need someone who

Project information

Budget
30 - 45 USD