A function to loop through open positions and make pairs of arrays of tickets then close each pair of array if greater than target profit

MQL4 Experts

Job finished

Execution time 6 minutes
Feedback from customer
very good!
Feedback from employee
Great customer! Thank you for the order!

Specification

This is for an MT4 EA.

I need a function to loop through all open positions and store them in arrays based on price levels.
Then from these arrays (i.e. @ price 1760 there are open orders and @ price 1770 there are open orders and so on).
I want to calculate the ongoing profit of pairs of 2 arrays (i.e. sell array i with buy array i+1     AND    buy array i with sell array i-1).
And if profit is greater than target, close orders of these pairs of arrays. Each array may contain more than 1 ticket and can go up to x tickets, and the function will close the arrays only if the pairs contain minimally an array in each level.
The function will loop through all the arrays crawling from initial price up and down.
An optional function can also close the pairs of arrays if the total tickets in these pairs are x (can be input).
Code is already written, but i currently have problem with :

void CalculateAndCloseOrderGroupsForBuyAndSell() {
    // Loop from the initial_index down to 1 (since i-1 sell for i=0 doesn't exist)
    for (int i = initial_index; i > 0; i--) {
        double totalProfit = 0.0;
        
        if (buyTicketCounts[i] > 0 && sellTicketCounts[i-1] > 0){
           // Calculate profit for all buy tickets at index i
           for (int j = 0; j < buyTicketCounts[i]; j++) {
               int ticket = buyTickets[i][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
   
           // Calculate profit for all sell tickets at index i-1
           for (int j = 0; j < sellTicketCounts[i - 1]; j++) {
               int ticket = sellTickets[i - 1][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
          }

        // If the combined profit meets or exceeds the target, close the tickets and remove them from arrays
        if (totalProfit >= profit_target) {
            // Close and remove buy tickets at index i
            for (int j = buyTicketCounts[i] - 1; j >= 0; j--) {
                CloseOrder(buyTickets[i][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < buyTicketCounts[i] - 1; k++) {
                    buyTickets[i][k] = buyTickets[i][k + 1];
                }
                buyTicketCounts[i]--;
            }

            // Close and remove sell tickets at index i-1
            for (int j = sellTicketCounts[i - 1] - 1; j >= 0; j--) {
                CloseOrder(sellTickets[i - 1][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < sellTicketCounts[i - 1] - 1; k++) {
                    sellTickets[i - 1][k] = sellTickets[i - 1][k + 1];
                }
                sellTicketCounts[i - 1]--;
            }

            Print("Closed and removed orders for buy zone ", i, " and sell zone ", i - 1, " with total profit: ", totalProfit);
        }
    }
}


it always gives me "out of array" error. I will give the whole set of code. the focus is to fix this part to overcome the "out of array" issue/ error.


Thank you.




Responded

1
Developer 1
Rating
(100)
Projects
125
23%
Arbitration
12
0% / 75%
Overdue
22
18%
Free
2
Developer 2
Rating
(72)
Projects
80
10%
Arbitration
38
8% / 58%
Overdue
6
8%
Free
3
Developer 3
Rating
(53)
Projects
91
52%
Arbitration
2
0% / 50%
Overdue
1
1%
Free
4
Developer 4
Rating
(23)
Projects
45
20%
Arbitration
25
28% / 48%
Overdue
12
27%
Free
5
Developer 5
Rating
(67)
Projects
97
35%
Arbitration
11
27% / 45%
Overdue
13
13%
Free
6
Developer 6
Rating
(568)
Projects
657
32%
Arbitration
41
41% / 46%
Overdue
11
2%
Busy
7
Developer 7
Rating
(6)
Projects
10
10%
Arbitration
9
0% / 89%
Overdue
1
10%
Free
8
Developer 8
Rating
(69)
Projects
146
34%
Arbitration
13
8% / 62%
Overdue
26
18%
Free
Published: 6 codes
9
Developer 9
Rating
(568)
Projects
641
41%
Arbitration
25
48% / 36%
Overdue
46
7%
Working
Similar orders
Hello, I’m reaching out regarding my TradingView project. I’d like to know if you’re familiar with the Chrome extension for Pine Script optimization. I’m looking for a developer with a premium account who can help optimize some Pine Script code. Please I actually need someone who has a premium account of the chrome extension TradeTuning to optimize Pinescripts (for some specific data they give in their reports). Do
I need an MT5 Expert Advisor for Gold (XAUUSD) on M15 timeframe. Strategy Rules: Trade only after breakout and retest of support/resistance. Also include trendline breakout and retest entry. Only one trade at a time. High accuracy trades only. Stop Loss: fixed SL (developer make input adjustable). Take Profit: next support/resistance level. Trade should hold until trend change. Close trade when Higher Low or Lower
Hello, I’m looking for an experienced developer who can help convert an existing cTrader indicator into a fully functional Quantower indicator . I already have the complete source code for the cTrader indicator (written in C#) , and I would like the same logic, behavior, and visual output to be accurately replicated in Quantower
REQUIREMENTS SPECIFICATION FOR MT5 EXPERT ADVISOR - NAS100 1. GENERAL INFORMATION 1.1 Platform: MetaTrader 5 1.2 Symbol: Nas100 1.3 Timeframe: M5 1.4 Account Type: Hedge 1.5 Broker: Must work on Khwezi Trade / ATFX broker 2. ENTRY RULES - ALL 3 MUST ALIGN ON CLOSED CANDLE 2.1 Trend: Price above 50 EMA for Buy, below 50 EMA for Sell 2.2 Momentum: RSI(14) > 50 for Buy, < 50 for Sell 2.3 Confirmation: MACD line above
Hi i need an expert to built a automated trading bot for ninja trader platform like sniper auto trader bot If you can develop or build automated bot for ninjatrader, let me know
Hello programmers. I am looking and searching for Chrome extension that automates parameter optimization for TradingView strategies, not''TradingView Premium'' itself. Can you please get back to me? do you know the chrome extension. I am looking for someone with a premium account so I can optimize some pinescript with it
I’m looking for a developer (or AI-savvy builder) who is experienced in using tools like Claude.ai (e.g. Claude Code, Claude CoWork) to build a Forex-related website. The platform will include features such as: Tracking trading account performance Broker reviews and comparisons This is just a high-level overview — the main goal is to find someone who truly understands how to leverage AI tools and write effective
Hello, I’m reaching out regarding my TradingView project. I’d like to know if you’re familiar with the Chrome extension for Pine Script optimization. I’m looking for a developer with a premium account who can help optimize some Pine Script code. Please let me know if this is something you can assist with
Hello every developer here, I'm contacting you regarding my tradingview. Can you please get back to me? do you know the chrome extension. I am looking for someone with a premium account so I can optimize some pinescript with it
Hi, I am looking to purchase a MT5 Hedging EA that can show consistent profitability with drawdown less than 15%. I am not ready to build a new one from scratch as i do not have the strategy in mind yet so i do not want to take the risk of building one but not sure if it works. Only apply if you have an existing proven and tested Hedging EA that can sell to me together with the source code. Before i make the

Project information

Budget
30 - 45 USD