A function to loop through open positions and make pairs of arrays of tickets then close each pair of array if greater than target profit

MQL4 Experts

Job finished

Execution time 6 minutes
Feedback from customer
very good!
Feedback from employee
Great customer! Thank you for the order!

Specification

This is for an MT4 EA.

I need a function to loop through all open positions and store them in arrays based on price levels.
Then from these arrays (i.e. @ price 1760 there are open orders and @ price 1770 there are open orders and so on).
I want to calculate the ongoing profit of pairs of 2 arrays (i.e. sell array i with buy array i+1     AND    buy array i with sell array i-1).
And if profit is greater than target, close orders of these pairs of arrays. Each array may contain more than 1 ticket and can go up to x tickets, and the function will close the arrays only if the pairs contain minimally an array in each level.
The function will loop through all the arrays crawling from initial price up and down.
An optional function can also close the pairs of arrays if the total tickets in these pairs are x (can be input).
Code is already written, but i currently have problem with :

void CalculateAndCloseOrderGroupsForBuyAndSell() {
    // Loop from the initial_index down to 1 (since i-1 sell for i=0 doesn't exist)
    for (int i = initial_index; i > 0; i--) {
        double totalProfit = 0.0;
        
        if (buyTicketCounts[i] > 0 && sellTicketCounts[i-1] > 0){
           // Calculate profit for all buy tickets at index i
           for (int j = 0; j < buyTicketCounts[i]; j++) {
               int ticket = buyTickets[i][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
   
           // Calculate profit for all sell tickets at index i-1
           for (int j = 0; j < sellTicketCounts[i - 1]; j++) {
               int ticket = sellTickets[i - 1][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
          }

        // If the combined profit meets or exceeds the target, close the tickets and remove them from arrays
        if (totalProfit >= profit_target) {
            // Close and remove buy tickets at index i
            for (int j = buyTicketCounts[i] - 1; j >= 0; j--) {
                CloseOrder(buyTickets[i][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < buyTicketCounts[i] - 1; k++) {
                    buyTickets[i][k] = buyTickets[i][k + 1];
                }
                buyTicketCounts[i]--;
            }

            // Close and remove sell tickets at index i-1
            for (int j = sellTicketCounts[i - 1] - 1; j >= 0; j--) {
                CloseOrder(sellTickets[i - 1][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < sellTicketCounts[i - 1] - 1; k++) {
                    sellTickets[i - 1][k] = sellTickets[i - 1][k + 1];
                }
                sellTicketCounts[i - 1]--;
            }

            Print("Closed and removed orders for buy zone ", i, " and sell zone ", i - 1, " with total profit: ", totalProfit);
        }
    }
}


it always gives me "out of array" error. I will give the whole set of code. the focus is to fix this part to overcome the "out of array" issue/ error.


Thank you.




Responded

1
Developer 1
Rating
(100)
Projects
125
23%
Arbitration
12
0% / 75%
Overdue
22
18%
Free
2
Developer 2
Rating
(72)
Projects
80
10%
Arbitration
38
8% / 58%
Overdue
6
8%
Free
3
Developer 3
Rating
(53)
Projects
91
52%
Arbitration
2
0% / 50%
Overdue
1
1%
Free
4
Developer 4
Rating
(23)
Projects
45
20%
Arbitration
25
28% / 48%
Overdue
12
27%
Free
5
Developer 5
Rating
(67)
Projects
97
35%
Arbitration
11
27% / 45%
Overdue
13
13%
Free
6
Developer 6
Rating
(598)
Projects
692
33%
Arbitration
43
47% / 44%
Overdue
12
2%
Working
7
Developer 7
Rating
(6)
Projects
10
10%
Arbitration
9
0% / 89%
Overdue
1
10%
Free
8
Developer 8
Rating
(69)
Projects
146
34%
Arbitration
13
8% / 62%
Overdue
26
18%
Free
Published: 6 codes
9
Developer 9
Rating
(568)
Projects
641
41%
Arbitration
25
48% / 36%
Overdue
46
7%
Working
Similar orders
Hello, I am interested in working . I have several strategies that I want to automate. However, I need a developer beforehand to explain the strategies and discuss the next steps
Title: MT4 One Click Trader EA (Custom Development) I am looking for an experienced MQL4 developer to build a custom One Click Trader Expert Advisor for MetaTrader 4. The objective is a fast, reliable, execution-focused trading panel with minimal visual clutter and robust operation on both standard and offline charts. Requirements Trade Panel The EA must provide a simple trading panel containing: Buy button Sell
Project Name EliavTrade – Supply & Demand Prop Firm Trading System Executive Summary EliavTrade is an MT5 Expert Advisor designed to trade funded accounts and personal retail accounts using a rule-based Supply and Demand methodology combined with institutional risk management. The EA's primary objective is capital preservation and consistent account growth rather than aggressive returns. The system must be capable
Description: I am looking for a highly experienced MT5 developer to build a manual‑execution Expert Advisor called Chain Flow . This project is not suitable for beginners , indicator‑only developers, or anyone who has not previously built complex object‑based systems. The EA relies heavily on chart objects , state machines , and clean UI panel logic . Project Overview (High‑Level): Chain Flow is a manual execution EA
I'm after a solid, ready-to-use indicator (already built — not looking to commission from scratch) with the following: Clear BUY / SELL signals — clean and easy to read on the chart Around 75% accuracy (backtested / proven results preferred) Clear labeling directly on the chart for every signal Built-in Stop Loss levels Smart Take Profit targets (multiple TPs ideal) Fast-reacting — picks up moves quickly without
Hello, I am interested in working . I have several strategies that I want to automate. However, I need a developer beforehand to explain the strategies and discuss the next steps
Read signal and enter trade and close trade at good profits and open trade again. Either bullish or bearish signals at 0.1 on XAUUSD. Maximum trade a day should be 4-5 times with good opens and close signals. Looking foward to a long cooperation and also a honest and genuine person
Strategy Overview: I am looking for a professional MQL5 developer to create an Expert Advisor named "AURAE". The EA is based on a hybrid strategy that combines trend momentum analysis with volatility filters to identify high-probability entry points. Core Requirements: Logic: The EA should analyze trend direction using Moving Averages and confirm momentum using RSI. Entry Rules: * Buy: When the price closes above
AlphaGreen 150 - 200 USD
Hello, I need a professional MT5 Expert Advisor (EA) developed for a custom indicator-based strategy. Strategy Logic: Determine the trend direction: Uptrend = Buy opportunities only. Downtrend = Sell opportunities only. Entry Conditions: The indicator has 4 lines: 2 Green lines, 1 Red line, and 1 Blue line. Open a Buy trade when both Green lines move inside/between the Red and Blue lines during an uptrend. Open a
Robot trading 30+ USD
A trading robot that operates with a balance of $20 to $50, with a loss of $5 and a profit of $10, and a maximum of three trades per day

Project information

Budget
30 - 45 USD