A function to loop through open positions and make pairs of arrays of tickets then close each pair of array if greater than target profit

MQL4 Experts

Job finished

Execution time 6 minutes
Feedback from customer
very good!
Feedback from employee
Great customer! Thank you for the order!

Specification

This is for an MT4 EA.

I need a function to loop through all open positions and store them in arrays based on price levels.
Then from these arrays (i.e. @ price 1760 there are open orders and @ price 1770 there are open orders and so on).
I want to calculate the ongoing profit of pairs of 2 arrays (i.e. sell array i with buy array i+1     AND    buy array i with sell array i-1).
And if profit is greater than target, close orders of these pairs of arrays. Each array may contain more than 1 ticket and can go up to x tickets, and the function will close the arrays only if the pairs contain minimally an array in each level.
The function will loop through all the arrays crawling from initial price up and down.
An optional function can also close the pairs of arrays if the total tickets in these pairs are x (can be input).
Code is already written, but i currently have problem with :

void CalculateAndCloseOrderGroupsForBuyAndSell() {
    // Loop from the initial_index down to 1 (since i-1 sell for i=0 doesn't exist)
    for (int i = initial_index; i > 0; i--) {
        double totalProfit = 0.0;
        
        if (buyTicketCounts[i] > 0 && sellTicketCounts[i-1] > 0){
           // Calculate profit for all buy tickets at index i
           for (int j = 0; j < buyTicketCounts[i]; j++) {
               int ticket = buyTickets[i][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
   
           // Calculate profit for all sell tickets at index i-1
           for (int j = 0; j < sellTicketCounts[i - 1]; j++) {
               int ticket = sellTickets[i - 1][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
          }

        // If the combined profit meets or exceeds the target, close the tickets and remove them from arrays
        if (totalProfit >= profit_target) {
            // Close and remove buy tickets at index i
            for (int j = buyTicketCounts[i] - 1; j >= 0; j--) {
                CloseOrder(buyTickets[i][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < buyTicketCounts[i] - 1; k++) {
                    buyTickets[i][k] = buyTickets[i][k + 1];
                }
                buyTicketCounts[i]--;
            }

            // Close and remove sell tickets at index i-1
            for (int j = sellTicketCounts[i - 1] - 1; j >= 0; j--) {
                CloseOrder(sellTickets[i - 1][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < sellTicketCounts[i - 1] - 1; k++) {
                    sellTickets[i - 1][k] = sellTickets[i - 1][k + 1];
                }
                sellTicketCounts[i - 1]--;
            }

            Print("Closed and removed orders for buy zone ", i, " and sell zone ", i - 1, " with total profit: ", totalProfit);
        }
    }
}


it always gives me "out of array" error. I will give the whole set of code. the focus is to fix this part to overcome the "out of array" issue/ error.


Thank you.




Responded

1
Developer 1
Rating
(100)
Projects
125
23%
Arbitration
12
0% / 75%
Overdue
22
18%
Free
2
Developer 2
Rating
(72)
Projects
80
10%
Arbitration
38
8% / 58%
Overdue
6
8%
Free
3
Developer 3
Rating
(53)
Projects
91
52%
Arbitration
2
0% / 50%
Overdue
1
1%
Free
4
Developer 4
Rating
(23)
Projects
45
20%
Arbitration
25
28% / 48%
Overdue
12
27%
Free
5
Developer 5
Rating
(67)
Projects
97
35%
Arbitration
11
27% / 45%
Overdue
13
13%
Free
6
Developer 6
Rating
(555)
Projects
642
33%
Arbitration
41
41% / 46%
Overdue
11
2%
Busy
7
Developer 7
Rating
(6)
Projects
10
10%
Arbitration
9
0% / 89%
Overdue
1
10%
Free
8
Developer 8
Rating
(69)
Projects
146
34%
Arbitration
13
8% / 62%
Overdue
26
18%
Free
Published: 6 codes
9
Developer 9
Rating
(568)
Projects
641
41%
Arbitration
25
48% / 36%
Overdue
46
7%
Working
Similar orders
SMA 30+ USD
You are an expert AI Trading Analyst specializing in Simple Moving Average (SMA) Trend Following strategies. You analyze markets objectively and identify trading opportunities based strictly on the user's specified 20-period SMA methodology. Adapt your analysis to match the user's trend-following style. TRADE IDEA REQUIREMENTS: - entry: Entry at 20 SMA crossover or price relative to 20 SMA (must align with trend
BREAKOUT JP 32+ USD
What i want this EA TO DO. Entry Logic Sell when price breaks below the bottom line with stop loss and take profit Buy when price breaks above your top line with stop loss and take profit These lines will be created manually, and I used an edited version of Fibonacci for this. Can you create something similar? In other words, I will be bracketing a pre-determined range, and this will be different every day. If I go
1. Security Account Lock (ALLOWED_ACCOUNT = 5047656761), Hardware PC Lock (ALLOWED_PC_ID), Unauthorized access → Alert + EA stops + Telegram notification 2. Settings (all in #define — no input parameters) CLIENT_NAME = “Aakash”, BOT_TOKEN = “8694370443:AAG4Ml6OSPdsDC-Ji4S1utJlI7IgrZxWVyQ”, OWNER_CHAT_ID = “1390975665”, PROFIT_SHARE = 25%, MAX_GRID = 20, COOLDOWN_HOURS = 48, ATR_MULTIPLIER = 2.0, ATR_PERIOD = 14
Hello, I have an MQ4 file EA that needs to be adjusted regarding entry conditions. ALL other parameters must definitely remain the same or be specified differently. I am attaching it herewith. The stop-loss type in the new EA have to be ALWAYS a Fixed Stop-loss. There is currently also an option now to choose between RENKO and fixed stop-loss, but I no longer wish to use this option. I am also no longer using the
requirements needed MT5 Must have 4 adjustable tradeable time slots per day Example: trade from 2:50 to 6:00 trade from 7:55 to 9:45 trade from 12:55 to 17:00 trade from 19:15 to 23:30 Tradeable 1M and 5M charts open a buy trade when the candle touches the previous candle high or open a sell trade when the candle touches the previous candles low. (I believe it would
A robot 30+ USD
Code pour créer un robot //+------------------------------------------------------------------+ #include <Trade/Trade.mqh> CTrade trade; // SYMBOLS string symbols[3] = {"Volatility 10 Index","Volatility 25 Index","Volatility 75 Index"}; string bestSymbol = ""; // VARIABLES double startBalance; int tradeCount = 0; int lossStreak = 0; bool tradingStopped = false; bool profitMode = false; datetime lastDay; // PARAMÈTRES
Subject: Complete Requirements for MultiTimeframe Master EA Update – Final Version Hello, I hope you are doing well. After careful consideration, I have simplified my requirements. Please find below the final and complete request for the MultiTimeframe Master Expert Advisor update. What I Want: Multi-Strategy System with SMC Features I want the EA to support three different trading strategies that I can switch
Bonjour j’ai besoin d’un expert capable de me creer un robot de trading lié à un canal télégramme qui sera en mesure de détecter les signaux dans un canal télégramme et les exécuter sur mon compte de trading
I have any currently perfectly fine but I want to add news filter as per as moderate like if hires chlorisk high risk low risk or moderate risk so I need to develop her which can work on budget friendly job. Budget fixed 30 usd
Hi Im working with a Crypto trading company and we want to branch out with our indicator, i'm researching the bot automation and need some hands on board. i i want to hear your opinion about the indicator that i would like you to build. in the PDF i explain the whole indicator and how it need to look like. happy to hear form you

Project information

Budget
30 - 45 USD