A function to loop through open positions and make pairs of arrays of tickets then close each pair of array if greater than target profit

MQL4 Experts

Job finished

Execution time 6 minutes
Feedback from customer
very good!
Feedback from employee
Great customer! Thank you for the order!

Specification

This is for an MT4 EA.

I need a function to loop through all open positions and store them in arrays based on price levels.
Then from these arrays (i.e. @ price 1760 there are open orders and @ price 1770 there are open orders and so on).
I want to calculate the ongoing profit of pairs of 2 arrays (i.e. sell array i with buy array i+1     AND    buy array i with sell array i-1).
And if profit is greater than target, close orders of these pairs of arrays. Each array may contain more than 1 ticket and can go up to x tickets, and the function will close the arrays only if the pairs contain minimally an array in each level.
The function will loop through all the arrays crawling from initial price up and down.
An optional function can also close the pairs of arrays if the total tickets in these pairs are x (can be input).
Code is already written, but i currently have problem with :

void CalculateAndCloseOrderGroupsForBuyAndSell() {
    // Loop from the initial_index down to 1 (since i-1 sell for i=0 doesn't exist)
    for (int i = initial_index; i > 0; i--) {
        double totalProfit = 0.0;
        
        if (buyTicketCounts[i] > 0 && sellTicketCounts[i-1] > 0){
           // Calculate profit for all buy tickets at index i
           for (int j = 0; j < buyTicketCounts[i]; j++) {
               int ticket = buyTickets[i][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
   
           // Calculate profit for all sell tickets at index i-1
           for (int j = 0; j < sellTicketCounts[i - 1]; j++) {
               int ticket = sellTickets[i - 1][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
          }

        // If the combined profit meets or exceeds the target, close the tickets and remove them from arrays
        if (totalProfit >= profit_target) {
            // Close and remove buy tickets at index i
            for (int j = buyTicketCounts[i] - 1; j >= 0; j--) {
                CloseOrder(buyTickets[i][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < buyTicketCounts[i] - 1; k++) {
                    buyTickets[i][k] = buyTickets[i][k + 1];
                }
                buyTicketCounts[i]--;
            }

            // Close and remove sell tickets at index i-1
            for (int j = sellTicketCounts[i - 1] - 1; j >= 0; j--) {
                CloseOrder(sellTickets[i - 1][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < sellTicketCounts[i - 1] - 1; k++) {
                    sellTickets[i - 1][k] = sellTickets[i - 1][k + 1];
                }
                sellTicketCounts[i - 1]--;
            }

            Print("Closed and removed orders for buy zone ", i, " and sell zone ", i - 1, " with total profit: ", totalProfit);
        }
    }
}


it always gives me "out of array" error. I will give the whole set of code. the focus is to fix this part to overcome the "out of array" issue/ error.


Thank you.




Responded

1
Developer 1
Rating
(100)
Projects
125
23%
Arbitration
12
0% / 75%
Overdue
22
18%
Free
2
Developer 2
Rating
(72)
Projects
80
10%
Arbitration
38
8% / 58%
Overdue
6
8%
Free
3
Developer 3
Rating
(53)
Projects
91
52%
Arbitration
2
0% / 50%
Overdue
1
1%
Free
4
Developer 4
Rating
(23)
Projects
45
20%
Arbitration
25
28% / 48%
Overdue
12
27%
Free
5
Developer 5
Rating
(67)
Projects
97
35%
Arbitration
11
27% / 45%
Overdue
13
13%
Free
6
Developer 6
Rating
(611)
Projects
713
33%
Arbitration
45
49% / 42%
Overdue
14
2%
Working
7
Developer 7
Rating
(6)
Projects
10
10%
Arbitration
9
0% / 89%
Overdue
1
10%
Free
8
Developer 8
Rating
(69)
Projects
146
34%
Arbitration
13
8% / 62%
Overdue
26
18%
Free
Published: 6 codes
9
Developer 9
Rating
(568)
Projects
641
41%
Arbitration
25
48% / 36%
Overdue
46
7%
Working
Similar orders
Forex robot 30+ USD
Hello… need an MT5 expert advisor that scans up to five user-selected symbols for bullish and bearish engulfing patterns on a chosen timeframe, displays a signal dashboard with pattern strength scores, and automatically enters trades with risk-based lot sizing, fixed stop-loss and take-profit tied to the engulfing candle’s high or low
Mt5 ea 30+ USD
I have a fast execution ea that need a little touch, it trade on gold and my problem is about the risk ratio the tp is 3pip and stop loss 20 but i cannot get it right to make the average win larger and average loss lower. I would like to know if i can get help to get it right without touching the tragedy and the trade frequency. Those two pictures I attached is the example of what my bot actually do like i explained
Sane 50+ USD
we make money ,we print money I want to help averyone to start making money so if he purchase it you can start earning up 1000 dollars pair week which is enough to help your family and friends
Requirements Specification Here is an example of Requirements Specification for the development of the MACD Sample Expert Advisor, which is available in the MetaTrader 5 standard package. 1. The idea of the trading system is as follows : market entries are performed when MACD's main and signal lines intersect in the current trend direction . 2. Trend is determined based on the Exponential Moving Average with
REWARD! 35 - 200 USD
I will pay you a REWARD, if you find / create an EA that fits ALL the below criteria! Platform : MT4 ONLY! NOT MT5, I repeat: NOT MT5!! Timeframe : doesn’t matter Pair : doesn’t matter Strategy : doesn’t matter Drawdown : no more than 25% Return : minimum 5%, every month Lot sizing : dynamic lots I will backtest the EA with 99.9% tick data accuracy for a period of 20+ years . If the EA can produce minimum 5% returns
Hello, I am looking for an existing MT5 EA for XAUUSD (Gold). I do not want a custom EA from scratch. I need a high-frequency breakout scalping EA with: Buy Stop & Sell Stop (OCO) Fixed Stop Loss Automatic Break-even Tick-by-tick Trailing Stop One trade at a time If you already have such an EA, please send live results, demo, pricing, and videos
KOKIE FX 30 - 200 USD
PROGRAM: PSMI Market Intelligence Engine v1.0 OBJECTIVE: Analyse the market from higher timeframes to lower timeframes, build a market narrative, and only allow execution when every condition is confirmed. ========================================================= STEP 1 LOAD DATA ========================================================= Read: Monthly (future) Daily H4 H1 M15 M5
Hello, I am looking for someone to Run and Monitor the EA and Signals in the account. Should be able to monitor daily and fix any issue in the signal Copying and EA running. The Settings and configuration to be checked and updated periodically. Should be available to report and update on daily basis. Tell me the cost and your previous experience for the same. Thanks
void OnTick() { // Check if we already have an open trade if(OrdersTotal() == 0) { // Get the value of a 14-period Moving Average double ma = iMA(Symbol(), 0, 14, 0, MODE_SMA, PRICE_CLOSE, 0); // Basic Condition: If current close price moves above the MA, buy if(Close[0] > ma) { int ticket = OrderSend(Symbol(), OP_BUY, 0.1, Ask, 3, 0, 0, "My First Bot", 0, 0, clrGreen); } } }
i brought an EA called profit hunter killer and the file is not working any more its a scalper type EA can anyone here decomplie the file as i cam not abe to reach the seller i brought it on Shopee malaysian website

Project information

Budget
30 - 45 USD