A function to loop through open positions and make pairs of arrays of tickets then close each pair of array if greater than target profit

MQL4 Experts

Job finished

Execution time 6 minutes
Feedback from customer
very good!
Feedback from employee
Great customer! Thank you for the order!

Specification

This is for an MT4 EA.

I need a function to loop through all open positions and store them in arrays based on price levels.
Then from these arrays (i.e. @ price 1760 there are open orders and @ price 1770 there are open orders and so on).
I want to calculate the ongoing profit of pairs of 2 arrays (i.e. sell array i with buy array i+1     AND    buy array i with sell array i-1).
And if profit is greater than target, close orders of these pairs of arrays. Each array may contain more than 1 ticket and can go up to x tickets, and the function will close the arrays only if the pairs contain minimally an array in each level.
The function will loop through all the arrays crawling from initial price up and down.
An optional function can also close the pairs of arrays if the total tickets in these pairs are x (can be input).
Code is already written, but i currently have problem with :

void CalculateAndCloseOrderGroupsForBuyAndSell() {
    // Loop from the initial_index down to 1 (since i-1 sell for i=0 doesn't exist)
    for (int i = initial_index; i > 0; i--) {
        double totalProfit = 0.0;
        
        if (buyTicketCounts[i] > 0 && sellTicketCounts[i-1] > 0){
           // Calculate profit for all buy tickets at index i
           for (int j = 0; j < buyTicketCounts[i]; j++) {
               int ticket = buyTickets[i][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
   
           // Calculate profit for all sell tickets at index i-1
           for (int j = 0; j < sellTicketCounts[i - 1]; j++) {
               int ticket = sellTickets[i - 1][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
          }

        // If the combined profit meets or exceeds the target, close the tickets and remove them from arrays
        if (totalProfit >= profit_target) {
            // Close and remove buy tickets at index i
            for (int j = buyTicketCounts[i] - 1; j >= 0; j--) {
                CloseOrder(buyTickets[i][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < buyTicketCounts[i] - 1; k++) {
                    buyTickets[i][k] = buyTickets[i][k + 1];
                }
                buyTicketCounts[i]--;
            }

            // Close and remove sell tickets at index i-1
            for (int j = sellTicketCounts[i - 1] - 1; j >= 0; j--) {
                CloseOrder(sellTickets[i - 1][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < sellTicketCounts[i - 1] - 1; k++) {
                    sellTickets[i - 1][k] = sellTickets[i - 1][k + 1];
                }
                sellTicketCounts[i - 1]--;
            }

            Print("Closed and removed orders for buy zone ", i, " and sell zone ", i - 1, " with total profit: ", totalProfit);
        }
    }
}


it always gives me "out of array" error. I will give the whole set of code. the focus is to fix this part to overcome the "out of array" issue/ error.


Thank you.




Responded

1
Developer 1
Rating
(100)
Projects
125
23%
Arbitration
12
0% / 75%
Overdue
22
18%
Free
2
Developer 2
Rating
(72)
Projects
80
10%
Arbitration
38
8% / 58%
Overdue
6
8%
Free
3
Developer 3
Rating
(53)
Projects
91
52%
Arbitration
2
0% / 50%
Overdue
1
1%
Free
4
Developer 4
Rating
(23)
Projects
45
20%
Arbitration
25
28% / 48%
Overdue
12
27%
Free
5
Developer 5
Rating
(67)
Projects
97
35%
Arbitration
11
27% / 45%
Overdue
13
13%
Free
6
Developer 6
Rating
(556)
Projects
643
33%
Arbitration
41
41% / 46%
Overdue
11
2%
Busy
7
Developer 7
Rating
(6)
Projects
10
10%
Arbitration
9
0% / 89%
Overdue
1
10%
Free
8
Developer 8
Rating
(69)
Projects
146
34%
Arbitration
13
8% / 62%
Overdue
26
18%
Free
Published: 6 codes
9
Developer 9
Rating
(568)
Projects
641
41%
Arbitration
25
48% / 36%
Overdue
46
7%
Working
Similar orders
I need a professional MQL4/MQL5 developer to build a custom hybrid scalping Expert Advisor for EURUSD M5, with aggressive but controlled risk, using fixed TP/SL, no martingale, no grid, and a hybrid entry engine (price action + indicators). The EA must be delivered in both MT4 (MQL4) and MT5 (MQL5) versions, with identical logic. 1. Platform & symbol - MT4 (MQL4) and MT5 (MQL5) - Symbol: EURUSD - Timeframe: M5 - EA
Hello i need an EA automated using Supply & Demand + Shooting Star/Hammer Bot: Timeframes: H1 main, M5/M15 for entry Indicators: ATR(14 ≥0.80), Supply/Demand zones, Candlestick patterns Short Entry: 1. Price enters supply zone 2. Shooting star forms (small body, long upper wick ≥2× body) 3. ATR ≥0.80 4. Sell below shooting star low Stop Loss: above upper wick Take Profit: next support zone or 1:2 R:R Trailing Stop
HFT Directional Grid Scalper (Simple, Training Project) Overview We are looking for a developer to create a high-frequency grid scalper with a simple, deterministic logic. This is not a complex bot — the goal is to have a clean implementation for training, testing, and educational purposes. The bot should: Continually open trades in one direction only (BUY or SELL) Use ATR-based grid spacing Maintain a fixed lot size
Looking to buy an EA which is good, profitable and takes many trades, good for IB broker comissions, Any strategy or martingale is fine, send me a demo license file, I will backtest and purchase immediately if my team like it
Hi, Before ordering, I want to verify the quality of your ICT/SMC logic. Do you have an existing indicator or strategy (your own work) that I can test on TradingView? If yes, please provide: 1. A demo (invite-only script or video) 2. Proof it is NON-repainting (explained clearly) 3. Live or replay demonstration (not static screenshots) Specifically I want to see: * Clean swing structure (no consecutive highs/lows) *
Indicator 125+ USD
Hi guys looking for a buy sell indicator not necessarily for trading solely based on it but more for getting an indication of market dynamic and direction. If you believe you have or have a good strategy or idea for such an indicator drop a message. I will want to test it before making deposit as this is such an open order woth so many options. Waiting to hear from you. Flexible with price
Looking to work woth manualtraders who have a proved existing strategy. To be clear, this is not a request to develop or design a new strategy. If you already trading and have strategy that is proven, consistent, and production-ready, with at least 6 months of history performance I’m open to reviewing it immediately. Please apply only if you meet all the requirements below. Submissions without a proper introduction
Scalping EA 30+ USD
Hello, I am looking for an Expert Advisor (EA) that focuses on account preservation and consistent growth , rather than aggressive or risky strategies. My requirements are: Target: at least ~1% weekly return Strategy: low-risk, controlled drawdown Must NOT use martingale or grid systems that can blow the account Prefer quality trades over quantity like 100–200 trades per day Consistency is more important than high
Looking for a good EA 2000 - 5000 USD
Hello coders ,I am looking for a good already established MT5 EA ,that doesnt blow account, with maximum 10 percent drowdown,I need to backtest by myself,after that i select the developer
Hello i need bot 30 - 100 USD
I need a trading bot (Expert Advisor) that can send alerts to mobile, Telegram, and the MT5 desktop platform. The bot should work as a market scanner for all symbols available in my MetaTrader 5 Market Watch. It must analyze multiple indicators and convert their signals into a point-based scoring system, then send alerts based on those scores. Requirements: Send notifications to: Mobile (push notifications) Telegram

Project information

Budget
30 - 45 USD