A function to loop through open positions and make pairs of arrays of tickets then close each pair of array if greater than target profit

MQL4 Experts

Job finished

Execution time 6 minutes
Feedback from customer
very good!
Feedback from employee
Great customer! Thank you for the order!

Specification

This is for an MT4 EA.

I need a function to loop through all open positions and store them in arrays based on price levels.
Then from these arrays (i.e. @ price 1760 there are open orders and @ price 1770 there are open orders and so on).
I want to calculate the ongoing profit of pairs of 2 arrays (i.e. sell array i with buy array i+1     AND    buy array i with sell array i-1).
And if profit is greater than target, close orders of these pairs of arrays. Each array may contain more than 1 ticket and can go up to x tickets, and the function will close the arrays only if the pairs contain minimally an array in each level.
The function will loop through all the arrays crawling from initial price up and down.
An optional function can also close the pairs of arrays if the total tickets in these pairs are x (can be input).
Code is already written, but i currently have problem with :

void CalculateAndCloseOrderGroupsForBuyAndSell() {
    // Loop from the initial_index down to 1 (since i-1 sell for i=0 doesn't exist)
    for (int i = initial_index; i > 0; i--) {
        double totalProfit = 0.0;
        
        if (buyTicketCounts[i] > 0 && sellTicketCounts[i-1] > 0){
           // Calculate profit for all buy tickets at index i
           for (int j = 0; j < buyTicketCounts[i]; j++) {
               int ticket = buyTickets[i][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
   
           // Calculate profit for all sell tickets at index i-1
           for (int j = 0; j < sellTicketCounts[i - 1]; j++) {
               int ticket = sellTickets[i - 1][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
          }

        // If the combined profit meets or exceeds the target, close the tickets and remove them from arrays
        if (totalProfit >= profit_target) {
            // Close and remove buy tickets at index i
            for (int j = buyTicketCounts[i] - 1; j >= 0; j--) {
                CloseOrder(buyTickets[i][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < buyTicketCounts[i] - 1; k++) {
                    buyTickets[i][k] = buyTickets[i][k + 1];
                }
                buyTicketCounts[i]--;
            }

            // Close and remove sell tickets at index i-1
            for (int j = sellTicketCounts[i - 1] - 1; j >= 0; j--) {
                CloseOrder(sellTickets[i - 1][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < sellTicketCounts[i - 1] - 1; k++) {
                    sellTickets[i - 1][k] = sellTickets[i - 1][k + 1];
                }
                sellTicketCounts[i - 1]--;
            }

            Print("Closed and removed orders for buy zone ", i, " and sell zone ", i - 1, " with total profit: ", totalProfit);
        }
    }
}


it always gives me "out of array" error. I will give the whole set of code. the focus is to fix this part to overcome the "out of array" issue/ error.


Thank you.




Responded

1
Developer 1
Rating
(100)
Projects
125
23%
Arbitration
12
0% / 75%
Overdue
22
18%
Free
2
Developer 2
Rating
(72)
Projects
80
10%
Arbitration
38
8% / 58%
Overdue
6
8%
Free
3
Developer 3
Rating
(53)
Projects
91
52%
Arbitration
2
0% / 50%
Overdue
1
1%
Free
4
Developer 4
Rating
(23)
Projects
45
20%
Arbitration
25
28% / 48%
Overdue
12
27%
Free
5
Developer 5
Rating
(67)
Projects
97
35%
Arbitration
11
27% / 45%
Overdue
13
13%
Free
6
Developer 6
Rating
(598)
Projects
692
33%
Arbitration
43
47% / 44%
Overdue
12
2%
Working
7
Developer 7
Rating
(6)
Projects
10
10%
Arbitration
9
0% / 89%
Overdue
1
10%
Free
8
Developer 8
Rating
(69)
Projects
146
34%
Arbitration
13
8% / 62%
Overdue
26
18%
Free
Published: 6 codes
9
Developer 9
Rating
(568)
Projects
641
41%
Arbitration
25
48% / 36%
Overdue
46
7%
Working
Similar orders
Robot trading 30+ USD
A trading robot that operates with a balance of $20 to $50, with a loss of $5 and a profit of $10, and a maximum of three trades per day
Prop Firm EA 30 - 40 USD
I am looking for an MT5 Expert Advisor specifically designed to help meet common prop-firm evaluation requirements while prioritizing consistency, low drawdown, and strong risk management. The EA should use a robust trend-following and market structure-based strategy with multi-timeframe confirmation, momentum filtering, and optional news filtering to avoid low-quality trades. It must include configurable risk
The bot uses: RSI MA(2/7) crossover for entry signals Price Bollinger Bands as trend filter RSI Bands(34) as confirmation London/NY session filter (M5 only) ATR-based SL/TP Gap bridge between sessions Here's your EA. Here's what it replicates from the Pine Script bot: Strategy logic RSI MA(2) crosses MA(7) for entry signals Price Bollinger Bands(20) as trend filter RSI Bands(34) as confirmation filter ATR-based SL/TP
UltraTrend EA 40+ USD
An Executive Assistant provides comprehensive administrative and operational support to senior leaders, ensuring efficient management of schedules, communications, meetings, and projects. They act as a key point of contact, coordinate business activities, maintain confidentiality, and help executives focus on strategic priorities while supporting organizational effectiveness
I need a simple bot for opening range. Simple Entry / Exit rules, to be able to customize the timeframe, time zone (entry candle) and other normal settings like size, etc
Hello, I am searching profitable, 0/1 rules strategy. Only serious offers please, I am expecting longer co-operation, I am open for your propositions, ideas. Have a nice day! I hope I will find here honest person
Need an Expert Advisor designed specifically for XAUUSD (Gold) , based on liquidity sweep + breakout confirmation logic. Market Focus Instrument: XAUUSD only Optimized for high volatility and intraday expansion behavior typical for Gold. Strategy Concept The EA is based on liquidity sweep of previous day levels followed by market structure shift and continuation in the confirmed direction. Daily Levels Previous Day
Can we do this 2 Indicatos at once NOTES 1. Step MA are on HTF, So values to be used are for Time frame that have closed 2. Pairs that are to be displayed for 2 STEP MA TREND DISPLAY are to be arranged in alphabetical order 3. Pairs in Bullish Weak trend are to be displayed in Green 4. Pairs in Bearish Weak Trend are to be displayed in Red 5. Position for displayed to be adjustable
GoldTrade EA 50 - 100 USD
Evening. I need a programme who will be patient with my EA specifications as it consists of +/- 30 sections ..but before we can start I want us to agree on these terms ...are as follows...the programmer should follow these order .[.Market regiom > trend bias > Lequidity > Smc > Momentum > Session > Risk > Entry > Exit ] and also should help me with these prototype request phase 1=Logicframework . phase 2=Entry engine
Hello everyone, I am looking for a profitable Expert Advisor (EA) that has already been developed and tested for use on the Deriv platform, particularly for Boom, Crash, Volatility Indices, Step Indices, and other synthetic indices offered by Deriv. I am interested in EAs with proven performance and verifiable results. If you have an EA that is already built and operational, I would be happy to discuss its strategy

Project information

Budget
30 - 45 USD