A function to loop through open positions and make pairs of arrays of tickets then close each pair of array if greater than target profit

MQL4 Experts

Job finished

Execution time 6 minutes
Feedback from customer
very good!
Feedback from employee
Great customer! Thank you for the order!

Specification

This is for an MT4 EA.

I need a function to loop through all open positions and store them in arrays based on price levels.
Then from these arrays (i.e. @ price 1760 there are open orders and @ price 1770 there are open orders and so on).
I want to calculate the ongoing profit of pairs of 2 arrays (i.e. sell array i with buy array i+1     AND    buy array i with sell array i-1).
And if profit is greater than target, close orders of these pairs of arrays. Each array may contain more than 1 ticket and can go up to x tickets, and the function will close the arrays only if the pairs contain minimally an array in each level.
The function will loop through all the arrays crawling from initial price up and down.
An optional function can also close the pairs of arrays if the total tickets in these pairs are x (can be input).
Code is already written, but i currently have problem with :

void CalculateAndCloseOrderGroupsForBuyAndSell() {
    // Loop from the initial_index down to 1 (since i-1 sell for i=0 doesn't exist)
    for (int i = initial_index; i > 0; i--) {
        double totalProfit = 0.0;
        
        if (buyTicketCounts[i] > 0 && sellTicketCounts[i-1] > 0){
           // Calculate profit for all buy tickets at index i
           for (int j = 0; j < buyTicketCounts[i]; j++) {
               int ticket = buyTickets[i][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
   
           // Calculate profit for all sell tickets at index i-1
           for (int j = 0; j < sellTicketCounts[i - 1]; j++) {
               int ticket = sellTickets[i - 1][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
          }

        // If the combined profit meets or exceeds the target, close the tickets and remove them from arrays
        if (totalProfit >= profit_target) {
            // Close and remove buy tickets at index i
            for (int j = buyTicketCounts[i] - 1; j >= 0; j--) {
                CloseOrder(buyTickets[i][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < buyTicketCounts[i] - 1; k++) {
                    buyTickets[i][k] = buyTickets[i][k + 1];
                }
                buyTicketCounts[i]--;
            }

            // Close and remove sell tickets at index i-1
            for (int j = sellTicketCounts[i - 1] - 1; j >= 0; j--) {
                CloseOrder(sellTickets[i - 1][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < sellTicketCounts[i - 1] - 1; k++) {
                    sellTickets[i - 1][k] = sellTickets[i - 1][k + 1];
                }
                sellTicketCounts[i - 1]--;
            }

            Print("Closed and removed orders for buy zone ", i, " and sell zone ", i - 1, " with total profit: ", totalProfit);
        }
    }
}


it always gives me "out of array" error. I will give the whole set of code. the focus is to fix this part to overcome the "out of array" issue/ error.


Thank you.




Responded

1
Developer 1
Rating
(100)
Projects
125
23%
Arbitration
12
0% / 75%
Overdue
22
18%
Free
2
Developer 2
Rating
(72)
Projects
80
10%
Arbitration
38
8% / 58%
Overdue
6
8%
Free
3
Developer 3
Rating
(53)
Projects
91
52%
Arbitration
2
0% / 50%
Overdue
1
1%
Free
4
Developer 4
Rating
(23)
Projects
45
20%
Arbitration
25
28% / 48%
Overdue
12
27%
Free
5
Developer 5
Rating
(67)
Projects
97
35%
Arbitration
11
27% / 45%
Overdue
13
13%
Free
6
Developer 6
Rating
(633)
Projects
741
34%
Arbitration
49
53% / 39%
Overdue
15
2%
Working
7
Developer 7
Rating
(6)
Projects
10
10%
Arbitration
9
0% / 89%
Overdue
1
10%
Free
8
Developer 8
Rating
(69)
Projects
146
34%
Arbitration
13
8% / 62%
Overdue
26
18%
Free
Published: 6 codes
9
Developer 9
Rating
(568)
Projects
641
41%
Arbitration
25
48% / 36%
Overdue
46
7%
Working
Similar orders
Staddle 30+ USD
"10 * 0.01, 10 * 0.03, 10 * 0.05. Place a limit order one dollar above the market price, a sell-side limit order below the market price, and a trailing stop loss. The goal is to safely book profits incrementally as the market moves." Agar aapko is poore concept ya strategy ko kisi MQL5 code comment ke liye ya apne trading plan mein document karne ke liye ek formal description chahiye, toh aap yeh bhi use kar sakte
SELINA 30+ USD
1. Delta: choose the contract Calls: delta between +0.45 and +0.60 . Puts: delta between −0.45 and −0.60 . Prefer liquid contracts with tight spreads. Skip if no contract fits the risk budget. 2. Gamma: control rapid changes in exposure Read the contract’s live gamma and monitor it each minute. Reject contracts with missing or stale Greeks. Flag high gamma near the strike, especially as expiry approaches. If gamma
Hello developers,I am looking for an experienced MQL5 developer to create an EA based on Moving Average retest strategy with advanced recovery system.The concept is simple: Entry is based on MA close and retest. Initial trade has small TP and no SL.If price goes against the initial position, the EA should manage it using:Opposite hedge tradePending limit grid systemBasket take profitMartingale lot multiplier after
Hi Traders, I am an MQL5 Developer with a strong background in building custom MetaTrader 5 Expert Advisors (EAs). I have developed an efficient, high-precision entry & exit logic that focuses on clean execution and smart risk management. Whether you want to consult on strategy design, integrate this logic into your trading setup, or turn your own system into a fully automated EA, I am here to help! I am currently
Hi! I have an optimized MQL5 entry and exit logic ready to be coded into a custom EA. It focuses on precision timing, proper risk management, and clean execution. If you are interested in discussing or integrating this into your trading setup, feel free to drop me a message
Professional MQL5 developer available for custom Expert Advisor (EA) and Indicator development on MetaTrader 5. What I can build: Custom EA based on your strategy rules (SMC, FVG, Price Action, Indicators) Risk & Money Management modules (Auto Lot, Daily Loss Limit, Trailing Stop) Real-time Alerts (Telegram, Email, Mobile Push Notification) Code Optimization & Bug Fixing for existing MQL5 programs Workflow: Please
Thujkkds 30 - 200 USD
Me and I will be there thank you for your help and sub and sub and sub in the morning to get the season and the screen is on the way home now and I will motho
I’m looking for an experienced MQL5 developer to create a high-frequency trading bot similar to those used for passing prop firm challenges , customised to my requirements. The EA should support ultra-fast entries and exits, hundreds of trades within short sessions, and advanced pending-order strategies. I have reference videos showing the exact trading style I want. Budget: $100–$200 (negotiable). Only experienced
Goldn zon 30+ USD
Hello, I am looking for a developer. I have a robust strategy based on Fibonacci, which I call "Goldn Zon." I tested it myself throughout the month of September, and now I would like to have a bot implement it so that it can trade continuously
Hello, I am looking for an experienced MQL5 developer to design, develop, and test one very fast, aggressive ultra-scalping Expert Advisor exclusively for MetaTrader 5 (MT5). I do not have a predefined trading strategy, so I need someone who can independently research and develop a suitable strategy rather than simply code existing instructions. My requirements include: Strategy research, design, and MQL5 development

Project information

Budget
30 - 45 USD