A function to loop through open positions and make pairs of arrays of tickets then close each pair of array if greater than target profit

MQL4 Experts

Job finished

Execution time 6 minutes
Feedback from customer
very good!
Feedback from employee
Great customer! Thank you for the order!

Specification

This is for an MT4 EA.

I need a function to loop through all open positions and store them in arrays based on price levels.
Then from these arrays (i.e. @ price 1760 there are open orders and @ price 1770 there are open orders and so on).
I want to calculate the ongoing profit of pairs of 2 arrays (i.e. sell array i with buy array i+1     AND    buy array i with sell array i-1).
And if profit is greater than target, close orders of these pairs of arrays. Each array may contain more than 1 ticket and can go up to x tickets, and the function will close the arrays only if the pairs contain minimally an array in each level.
The function will loop through all the arrays crawling from initial price up and down.
An optional function can also close the pairs of arrays if the total tickets in these pairs are x (can be input).
Code is already written, but i currently have problem with :

void CalculateAndCloseOrderGroupsForBuyAndSell() {
    // Loop from the initial_index down to 1 (since i-1 sell for i=0 doesn't exist)
    for (int i = initial_index; i > 0; i--) {
        double totalProfit = 0.0;
        
        if (buyTicketCounts[i] > 0 && sellTicketCounts[i-1] > 0){
           // Calculate profit for all buy tickets at index i
           for (int j = 0; j < buyTicketCounts[i]; j++) {
               int ticket = buyTickets[i][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
   
           // Calculate profit for all sell tickets at index i-1
           for (int j = 0; j < sellTicketCounts[i - 1]; j++) {
               int ticket = sellTickets[i - 1][j];
               totalProfit += ComputeProfitForOrder(ticket);
           }
          }

        // If the combined profit meets or exceeds the target, close the tickets and remove them from arrays
        if (totalProfit >= profit_target) {
            // Close and remove buy tickets at index i
            for (int j = buyTicketCounts[i] - 1; j >= 0; j--) {
                CloseOrder(buyTickets[i][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < buyTicketCounts[i] - 1; k++) {
                    buyTickets[i][k] = buyTickets[i][k + 1];
                }
                buyTicketCounts[i]--;
            }

            // Close and remove sell tickets at index i-1
            for (int j = sellTicketCounts[i - 1] - 1; j >= 0; j--) {
                CloseOrder(sellTickets[i - 1][j]);
                // Shift tickets to remove the closed ticket from the array
                for (int k = j; k < sellTicketCounts[i - 1] - 1; k++) {
                    sellTickets[i - 1][k] = sellTickets[i - 1][k + 1];
                }
                sellTicketCounts[i - 1]--;
            }

            Print("Closed and removed orders for buy zone ", i, " and sell zone ", i - 1, " with total profit: ", totalProfit);
        }
    }
}


it always gives me "out of array" error. I will give the whole set of code. the focus is to fix this part to overcome the "out of array" issue/ error.


Thank you.




Responded

1
Developer 1
Rating
(100)
Projects
125
23%
Arbitration
12
0% / 75%
Overdue
22
18%
Free
2
Developer 2
Rating
(72)
Projects
80
10%
Arbitration
38
8% / 58%
Overdue
6
8%
Free
3
Developer 3
Rating
(53)
Projects
91
52%
Arbitration
2
0% / 50%
Overdue
1
1%
Free
4
Developer 4
Rating
(23)
Projects
45
20%
Arbitration
25
28% / 48%
Overdue
12
27%
Free
5
Developer 5
Rating
(67)
Projects
97
35%
Arbitration
11
27% / 45%
Overdue
13
13%
Free
6
Developer 6
Rating
(570)
Projects
661
32%
Arbitration
42
45% / 45%
Overdue
12
2%
Loaded
7
Developer 7
Rating
(6)
Projects
10
10%
Arbitration
9
0% / 89%
Overdue
1
10%
Free
8
Developer 8
Rating
(69)
Projects
146
34%
Arbitration
13
8% / 62%
Overdue
26
18%
Free
Published: 6 codes
9
Developer 9
Rating
(568)
Projects
641
41%
Arbitration
25
48% / 36%
Overdue
46
7%
Working
Similar orders
I have Renko EA, but is a bug, please fix it, thank you in advance, have a nice day, thay you for your patience and attention, Programmers with previous experience in RENKO I prefer
Gold Edge Pro 30 - 150 USD
Create a fully working Expert Advisor (EA) for MetaTrader 5, designed exclusively for GOLD (XAUUSD only). This is a high‑probability trend‑following breakout strategy built specifically for passing 2‑step prop firm challenges — it delivers a ~60–65% win rate, uses a strict 1:3 risk/reward ratio, and is optimised to pass both phases in roughly 1–2 weeks total. --- ⚙️ USER INPUTS — FULLY FLEXIBLE RISK --- All main
Buy a profitable MT5 EA 100 - 2999 USD
I need a profitable system with live account trade or demo that can be back-tested for 10 years with good profits. I can increase amount only when proof is shown with good proof. Pls consider drawdown to be low and ea to handle low equity to trade. source code will be provided at the end. Very important sending 10 days demo first ,after we can negociate price , thank you
This EA is for trading XAUUSD. There are 2 trade logics. One based on trend reversal (with 5 trade opening conditions). The second is based on trend continuation (with 1-2 conditions)
I want the bot to be fully automated trading key levels of (support and resistance ) from the higher-timeframe with atleast a 70% win rate. Experienced developer with atleast 3-4 years THANK YOU
Patricia Ukawilu 6:43 PM I need help creating an EA to optimize my trade. I already have a preliminary pine script which I will want optimized and create an EA from it to optimize my trade on MT4. I also subscribed to a signal app. I’m looking to automate the execution of the signal from the app so as not to miss out on good trades
HFT Directional Grid Scalper (Simple, Training Project) Overview We are looking for a developer to create a high-frequency grid scalper with a simple, deterministic logic. This is not a complex bot — the goal is to have a clean implementation for training, testing, and educational purposes. The bot should: Continually open trades in one direction only (BUY or SELL) Use ATR-based grid spacing Maintain a fixed lot size
Looking for a profitable EA, send demo version for at least 1 week or more so I can test it in a strategy tester and also forward test on demo account. Note- EA should be SL/TP based only, drawdown should be minimum, consistently profitable, never use grid or martingale method
I am looking for an experienced MQL5 developer with Python/data analysis skills. I have my own MT5 Strategy Tester reports, exported trade history, and market CSV data. I need help analyzing these files and developing a new independent Expert Advisor based on clearly defined, statistically tested, and validated trading rules. Tasks: Analyze my MT5 Strategy Tester reports and exported trade history. Compare historical
PROJECT TITLE: MT5 Expert Advisor for Gold (XAUUSD) – Scalping Trend Pullback Strategy PROJECT DESCRIPTION: I need a professional MQL5 developer to create a fully automated Expert Advisor (EA) specifically optimized for trading Gold (XAUUSD) on MetaTrader 5. The EA must be designed for scalping and capable of handling the high volatility and spread conditions of gold. TRADING PAIR: XAUUSD

Project information

Budget
30 - 45 USD