Problems with DSToffsets when creating News Filters

 

I am at a total loss of understanding. I read this thread: https://www.mql5.com/en/forum/326554 and tried using the news.mqh file and couldn't get it to draw lines properly, so then I have tried using Rene Balke's CalendarHistory.mqh file and it seems to correctly save all the values in a script but when I actually try to read them to draw lines they are always off by one hour whether its summer or winter. Does anybody have any experience in fixing something like this? Are there any other methods that are far better for saving and storing calendar values? I don't even need the data from the event I just the the time it occurs at so I can stop trading like 1 hour before and after in an EA. 

I've tried literally everything at this point to fix this. I have tried removing everything related to DST, changed every single parameter related to daylight savings time, hardcoded time offsets (which work for drawing regular lines but not news event lines for some reason),  and so far nothing as even worked to shift any of the lines at all and I'm totally confused as to why. 

I've attached the script I use to save the events and then the EA. I'm not going to attach the CalendarHistory.mqh file because I'm not sure if Rene would be comfortable with me doing that. I've also attached screenshots just to prove that its saving the calendar values at the right time but then drawling the lines wrong.

Please if anyone has any advice at all on this I would love to hear it. 


(Also in the screenshots 15:30 is 8:30am EST when most news happens)

MQL5 Economic Calendar / CalendarValueHistory in backtest - How to access the built-in economic calendar during backtest
MQL5 Economic Calendar / CalendarValueHistory in backtest - How to access the built-in economic calendar during backtest
  • 2019.11.15
  • Eric Emmrich
  • www.mql5.com
Hi all, is there any way to access the built-in economic calendar during backtest. Honestly, it's far from any code that i'm proud of, i did very little in the field of news trading over the past months and in retrospect i would do it in a better organized way
 
Also if 15:30 is always 8:30am EST (so 30 min after NY 8am open) and is always this way during both summer and winter months then does that mean my broker's customer support doesn't know what their talking about and they actually operate on a no DST schedule?
 
Please try to use this one.
Economic Calendar Monitor and Cache for Backtesting on History
Economic Calendar Monitor and Cache for Backtesting on History
  • www.mql5.com
This indicator displays current events on the chart and allows you to export the calendar to archives for backtesting, automatically fixing time discrepancies between the history of bars and the history of events. This is an improved version of CalendarMonitorCached indicator from the algotrading book.
 
Stanislav Korotky #:
Please try to use this one.

I figured it out, just hardcode something until it works lol, its mostly due to my inexperience with modifying class folders that I didn't understand somethings