Why my close all buys function is closing other pairs also?

 

Hello everyone,


I got an issue with my close all function. Some days it will close other pairs also, i have no idea why because i check on magic AND pair.


Note;

The other pair that gets closed has another magic and another pair ofcourse.


int closeAllBuys() {
   
   bool result = NO_ERROR;
   
   for (int i = OrdersTotal()-1; i >= 0; i--) {
      if (OrderSelect(i, SELECT_BY_POS)) {
         
         if (OrderSymbol() == Symbol() && OrderMagicNumber() == Magic) {
            if (OrderType() == OP_BUY) {
               RefreshRates();
               if (!OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, clrNONE)) {
                  result = AT_LEAST_ONE_FAILED;
               }
            }
            
            if (OrderType() == OP_BUYLIMIT) {
               if (!OrderDelete(OrderTicket())) {
                  result = AT_LEAST_ONE_FAILED;
               }
            }
         }
      }
   }
   
   Print("Closed all buys");
   
   return result;
}


Anyone an idea how to fix the issue?

 

Anyone an idea how to fix the issue?

int closeAllBuys() {
   
   bool result = NO_ERROR;
   
   for (int i = 0; i <OrdersTotal(); i++) {
      if (OrderSelect(i, SELECT_BY_POS)) {
         
         if (OrderSymbol() == Symbol() && OrderMagicNumber() == Magic) {
            if (OrderType() == OP_BUY) {
               RefreshRates();
               if (!OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, clrNONE)) {
                  result = AT_LEAST_ONE_FAILED;
               }
               else i--;
            }
            
            if (OrderType() == OP_BUYLIMIT) {
               if (!OrderDelete(OrderTicket())) {
                  result = AT_LEAST_ONE_FAILED;
               }
               else i--;
            }
         }
      }
   }
   
   Print("Closed all buys");
   
   return result;
}

I cannot be sure this will solve the problem. But I gave it a try.

 
  1.    for (int i = 0; i <OrdersTotal(); i++) if(
          OrderSelect(i, SELECT_BY_POS)
       && OrderMagicNumber() == Magic
       && OrderSymbol()      == _Symbol
    ){

    In the presence of multiple orders (one EA multiple charts, multiple EAs, manual trading), while you are waiting for the current operation (closing, deleting, modifying) to complete, any number of other operations on other orders could have concurrently happened and changed the position indexing and order count:

    1. For non-FIFO (non-US brokers), (or the EA only opens one order per symbol), you can simply count down, in an index loop, and you won't miss orders. Get in the habit of always counting down.
                Loops and Closing or Deleting Orders - MQL4 programming forum

    2. For In First Out (FIFO rules — US brokers), and you (potentially) process multiple orders per symbol, you must find the earliest order (count up), close it, and on a successful operation, reprocess all positions (from zero).
                CloseOrders by FIFO Rules - Strategy Tester - MQL4 programming forum - Page 2 #16
                MetaTrader 5 platform beta build 2155: MQL5 scope, global Strategy Tester and built-in Virtual Hosting updates - Best Expert Advisors - General - MQL5 programming forum #1.11

    3. and check OrderSelect in case later positions were deleted.
                What are Function return values ? How do I use them ? - MQL4 programming forum
                Common Errors in MQL4 Programs and How to Avoid Them - MQL4 Articles

    4. and if you (potentially) process multiple orders, must call RefreshRates() after server calls if you want to use, on the next order / server call, the Predefined Variables (Bid/Ask.) Or instead, be direction independent and just use OrderClosePrice().

  2. Arjan Hazewinkel: i have no idea why because i check on magic AND pair.

    Then your problem is elsewhere.

  3. Yashar Seyyedin #: I cannot be sure this will solve the problem. But I gave it a try.

    Decrementing by one solves nothing. Per № 1 "any number of other operations".