Modifies the SL and TP correctly in strategy tester but does not modify on live testing.

New comment
  
// open a sell
                  double openPrice = iClose(Symbol(), PERIOD_M1, 0);
                   double valueToRisk = acc_size * risk_perc / 100;
                  double sl = iHigh(Symbol(), PERIOD_D1, 0) + pips_from_swing*_Point*10;
                  double tp;
                  double tickSize = MarketInfo(Symbol(), MODE_TICKSIZE);
                  tp = openPrice - tp_multiplier*(sl - openPrice);
                  
                                 
   double tickCount = MathAbs(openPrice-sl)/tickSize;
   double tickValue = MarketInfo(Symbol(), MODE_TICKVALUE);
  
   double positionSize = (tickCount * tickValue) != 0 ? valueToRisk/(tickCount * tickValue) : 0;
   Print(positionSize);
   positionSize = NormalizeDouble(positionSize, 2);
                  
                 int ticket =OrderSend(Symbol(), OP_SELL, positionSize, openPrice,50, 0, 0);
                 
               if(ticket<0)
     {
      Print("OrderSend failed with error #",GetLastError());
     }
   else{
   Print("OrderSend placed successfully");
  bool res=  OrderModify(ticket,NormalizeDouble( openPrice  ,  Digits),NormalizeDouble (sl,Digits ),NormalizeDouble (tp, Digits),0,Blue);
   if(!res)
               Print("Error in OrderModify. Error code=",GetLastError());
            else
               Print("Order modified successfully.");
                  }
               }

Any help will be appreciated.

 

  1. Why did you post your MT4 question in the MT5 EA section instead of the MQL4 section, (bottom of the Root page)?
              General rules and best pratices of the Forum. - General - MQL5 programming forum? (2017)
    Next time, post in the correct place. The moderators will likely move this thread there soon.

  2.                   double openPrice = iClose(Symbol(), PERIOD_M1, 0);
                  ⋮
                 int ticket =OrderSend(Symbol(), OP_SELL, positionSize, openPrice,50, 0, 0);

    You can't open at anything other than at the Ask/Bid.

  3. lljustll: but does not modify on live testing. 
      bool res=  OrderModify(ticket,NormalizeDouble( openPrice  ,  Digits),NormalizeDouble (sl,Digits ),NormalizeDouble (tp, Digits),0,Blue);

    You can not modify the open price after it is open. Think slippage. Use the real value.

  4. You used NormalizeDouble, It's use is usually wrong, as it is in your case.

    1. Floating point has a infinite number of decimals, it's your not understanding floating point and that some numbers can't be represented exactly. (like 1/10.)
                Double-precision floating-point format - Wikipedia, the free encyclopedia

      See also The == operand. - MQL4 programming forum (2013)

    2. Print out your values to the precision you want with DoubleToString - Conversion Functions - MQL4 Reference.

    3. SL/TP (stops) need to be normalized to tick size (not Point) — code fails on non-currencies.
                On 5Digit Broker Stops are only allowed to be placed on full pip values. How to find out in mql? - MQL4 programming forum (2011)

      And abide by the limits Requirements and Limitations in Making Trades - Appendixes - MQL4 Tutorial and that requires understanding floating point equality Can price != price ? - MQL4 programming forum (2012)

    4. Open price for pending orders need to be adjusted. On Currencies, Point == TickSize, so you will get the same answer, but it won't work on non-currencies. So do it right.
                Trailing Bar Entry EA - MQL4 programming forum (2013)
                Bid/Ask: (No Need) to use NormalizeDouble in OrderSend - MQL4 programming forum (2012)

    5. Lot size must also be adjusted to a multiple of LotStep and check against min and max. If that is not a power of 1/10 then NormalizeDouble is wrong. Do it right.
                (MT4 2013)) (MT5 2022))

    6. MathRound() and NormalizeDouble() are rounding in a different way. Make it explicit.
                MT4:NormalizeDouble - MQL5 programming forum (2017)
                How to Normalize - Expert Advisors and Automated Trading - MQL5 programming forum (2017)

    7. Prices you get from the terminal are already correct (normalized).

    8. PIP, Point, or Tick are all different in general.
                What is a TICK? - MQL4 programming forum (2014)

  5. There is no need to open an order and then set the stops. Simplify your code - do it in one step. TP/SL on OrderSend has been fine for years.
              Build 500 № 9 (2013)
              Is OrderSend() function now able to send ECN trades (with SL and TP) by itself? - MQL4 programming forum (2013)
              OP_BUY the same on Instant Execution and Market Execution? - MQL4 programming forum #2 (2014)
              Need help me mql4 guru add take profit to this EA - MQL4 programming forum #8 (2017)

New comment