It may help to first search the forum for similar situations ... https://www.mql5.com/en/search#!keyword=OrderClose%20error%20138
The forum is filled with posts asking about the "requote" error. It has been asked many times and answered even more times.
Here are some I've answered before:
Forum on trading, automated trading systems and testing trading strategies
Fernando Carreiro, 2022.04.22 15:08
First you should research what a "re-quote" is. You should learn what execution policies are and the difference between "Instant" and "Market" execution policies.
You should also learn about maximum deviation (slippage) and how to set it in your order placement. You should also decide how you should handle re-quotes according to your trading strategy.
And then finally, once you understand all that, then you can go back to your MQL code and apply that logic to it.
Forum on trading, automated trading systems and testing trading strategies
Avoid Slippage without Pending Orders.
Fernando Carreiro, 2021.07.26 22:56
As I have already explained, for "Market Execution" policy, the opening price is ignored and you will get whatever price is available at the time.
With "Instant Execution" policy, then the price is important and if it deviates too far away from the current price, you will get a "requote" error.
Remember that Buy orders open at the Ask price and close at the Bid price, and Sell orders open at the Bid price and close at the Ask price.
EDIT: Also read the following:
- Instant Execution Policy
- Market Execution Policy
- Request Execution Policy (I know nothing about this one. I've never encountered it before)
- Exchange Execution Policy (I also have no experience with this one)
Forum on trading, automated trading systems and testing trading strategies
Getting Error Code 138 in Backtesting
Fernando Carreiro, 2022.02.19 09:34
Did you search the forum for other threads and posts about OrderSend Error 138? You would have found many, many threads and posts on it!
Did you make the effort to look at the MQL4 documentation to see what Error 138 means? It means there was a "requote"!
Do you know what a "requote" is? Did you search the web for the meaning of a "Requote"? It means that the price you are requesting is not accepted by the broker at that time.
The reason is that you are trying to buy at the bid price, but the market will only allow you to buy it at the ask price.
Why do you not know this? Because you did not read the documentation: Requirements and Limitations in Making Trades
The rules are that you enter a Buy at the market Ask price and exit at the Bid price. For a Sell you enter at the market Bid price and exit at the Ask price.
Thanks Fernando,
I actually did read them and i should have mentioned that.
While i'm at it, is should have also mentioned i get the error with backtesting.
My bewilderment is caused by the fact that while using the EXACT SAME OrderClose() parameters, i DO get errors when ticket has been selected using SELECT_BY_TICKET and that i do NOT get get them when selecting the ticket using SELECT_BY_POS.
AFAIK this issue in not in the posts i read on Error 138, nor did i figure this could be a RefreshRates() issue, given the error goes away by changing the selection method and that i'm not using Bid or Ask, but OrderClosePrice() instead.
I suspect that your problem is this
if(OrderSelect(ticket_long,SELECT_BY_TICKET)) //here we use SELECT_BY_TICKET which brings (and causes?) error 138 { if(OrderCloseTime()==0) { ri="Long"; pr_open=OrderOpenPrice(); } }
Now, supposing this order is not closed yet, ri="Long" correct?
Then you follow with this code
if(OrderSelect(ticket_short,SELECT_BY_TICKET)) { if(OrderCloseTime()==0) { ri="Short"; pr_open=OrderOpenPrice(); } }
and let's say that this order has closed already. ri still equals "Long". Correct?
So as it stands, ri="Long" but you have selected the closed short order.
So when you move on to
if(ri=="Long" and some condition based on technical indictors and order open price) { if(OrderClose(ticket_long,lots,OrderClosePrice(),100,clrGreen)==TRUE) ri="Cash"; }
You are trying to close the long with the price that the short order was closed at.
You should re-select the order first.
if(ri=="Long" and some condition based on technical indictors and order open price) { //Reselect the long order here. if(OrderClose(ticket_long,lots,OrderClosePrice(),100,clrGreen)==TRUE) ri="Cash"; }
if(OrderClose(ticket_long,lots,OrderClosePrice(),100,clrGreen)==TRUE)
You have exited the select loop. If the first order position (0) was not processed, say different symb or magic, OrderClosePrice is not related to ticket_xxx.
Drop your ri variable and move that code into the loop.
Excellent! Thank you guys.
will correct the (now very obvious!) mistake..
Obviously i was wrong.
![Documentation on MQL5: Trade Functions / OrderSelect Documentation on MQL5: Trade Functions / OrderSelect](https://c.mql5.com/36/56/documentation-on-mql5-trade-functions__5.png)
- www.mql5.com
Excellent! Thank you guys.
will correct the (now very obvious!) mistake..
Obviously i was wrong.
You must always study the documentation, don't assume anything.
I know that the documentation is often not very clear, but in this case it leaves no doubt whatsoever.
OrderClosePrice
Returns close price of the currently selected order.
double OrderClosePrice(); |
Returned value
The close price of currently selected order.
Note
The order must be previously selected by the OrderSelect() function.
Example:
if(OrderSelect(10,SELECT_BY_POS,MODE_HISTORY)==true) |
Yes - so much is clear now.
Begs the questions why "0" can not be used for OrderClose() as after all ,the OrderClosePrice() for a not yet closed order is "0", right?
![MQL5 - Language of trade strategies built-in the MetaTrader 5 client terminal](https://c.mql5.com/i/registerlandings/logo-2.png)
- Free trading apps
- Over 8,000 signals for copying
- Economic news for exploring financial markets
You agree to website policy and terms of use
Hi there,
i have an issue with OrderClose() command generating error code 138
This seems to work OK, that is: No 138 errors
But when the look up is done by Ticket (see below), which i find more efficient, i get the 138 error.
Also, i get is sometimes, not all the time.
I'm sure i'm overlooking something, but what?
(note that a long and short can never be open at the same time - it's either/or)