I'm trying to add a trade reversal to the Owl; There are two cycles on the same cycle in one cycle, right - MQL4 and MetaTrader 4

Alexey Viktorov 2021.07.29 17:53 #15481

MakarFX:

It's good to talk when you know what to do...

help me with advice on how to "get as much useful information out as you can".

I've said it all quite clearly. Well for you personally, let me ask.

Here are two functions and both go through historical orders

//+------------------------------------------------------------------+
//|  Возвращает пункты убытка закрытых ордеров с начала цикла        |
//+------------------------------------------------------------------+

//+------------------------------------------------------------------+
//|  Возвращает кол-во серии убыточных ордеров                       |
//+------------------------------------------------------------------+

Two cycles on the same orders. You cannot get everything that these functions return in one cycle, right?

Any rookie question, so [WARNING CLOSED!] Any newbie [Archive!] Any rookie question,

законопослушный гражданин 2021.07.29 18:19 #15482

hello!

I'm trying to add a trade reversal to the owl. I am doing it as described in the instructions: https://www.mql5.com/ru/forum/128200

I have no errors when compiling, but flip does not work in tester.

The log gives an error:

2021.07.29 20:06:34.316 2015.01.08 22:10:00 SMA with flip through code AUDUSD,M5: OrderSend error 130

2021.07.29 20:06:34.316 2015.01.08 22:05:45 SMA with reversal via AUDUSD,M5: OrderSend error 4107

2021.07.29 20:06:34.316 2015.01.08 22:05:45 SMA with flip via AUDUSD,M5: invalid stoploss for OrderSend function

Could you please tell me what is the problem here?

I myself think that the variables specified in

int ReversOrderSend (string symbol,int cmd,double volume,double price,int slippage,double stoploss,double takeprofit,string comment,int magic=0,datetime expiration=0,color arrow_color=CLR_NONE)

Are not related to the main code.

I've tried it in different terminals, 4 and 5 signs.

here's the whole code:

//+-----------------------------------------------------------------------------------------------+
//|                                                                     Simple Moving Average.mq4 |
//|                                                                 Copyright 2016, Andrey Minaev |
//|                                                     https://www.mql5.com/ru/users/id.scorpion |
//+-----------------------------------------------------------------------------------------------+
#property copyright "Copyright 2016, Andrey Minaev"
#property link      "https://www.mql5.com/ru/users/id.scorpion"
#property version   "1.00"
#property strict

// Параметры советника
extern string sParametersEA = "";     // Параметры советника
extern double dLots         = 0.01;   // Количество лотов
extern int    iStopLoss     = 30;     // Уровень убытка (в пунктах)
extern int    iTakeProfit   = 30;     // Уровень прибыли (в пунктах)
extern int    iSlippage     = 3;      // Проскальзование (в пунктах)
extern int    iMagic        = 1;      // Индентификатор советника
extern double K_Martin     = 2.0;
extern int    OrdersClose  = 5;
extern int    DigitsLot    = 2;
extern int    ReversOrder  = 0;             // Переворот сделок 1-да; 0-нет;
// Параметры индикатора
extern string sParametersMA = "";     // Параметры индикатора
extern int    iPeriodMA     = 14;     // Период усреднения
// Глобальные переменные
double dMA;
//+-----------------------------------------------------------------------------------------------+
int OnInit()
  {
// Если брокер использует 3 или 5 знаков после запятой, то умножаем на 10
   if(Digits == 3 || Digits == 5)
     {
      iStopLoss   *= 10;
      iTakeProfit *= 10;
      iSlippage   *= 10;
     }

   return(INIT_SUCCEEDED);
  }
//+-----------------------------------------------------------------------------------------------+
void OnDeinit(const int reason)
  {

  }
//+-----------------------------------------------------------------------------------------------+
void OnTick()
  {
// Получим значение индикатора
   dMA = iMA(Symbol(), 0, iPeriodMA, 0, MODE_SMA, PRICE_CLOSE, 0);

// Если нет открытых ордеров, то входим в условие
   if(bCheckOrders() == true)
     {
      // Если появился сигнал на покупку, то откроем ордер на покупку
      if(bSignalBuy() == true)
         vOrderOpenBuy();

      // Если появился сигнал на продажу, то откроем ордер на продажу
      if(bSignalSell() == true)
         vOrderOpenSell();
     }
  }
//+-----------------------------------------------------------------------------------------------+
//|                                                             Функция проверки открытых оредров |
//+-----------------------------------------------------------------------------------------------+
bool bCheckOrders()
  {
// Переберем в цикле ордера, для проверки открытых ордеров данным советником
   for(int i = 0; i <= OrdersTotal(); i++)
      if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
         if(OrderSymbol() == Symbol() && OrderMagicNumber() == iMagic)
            return(false);

   return(true);
  }
//+-----------------------------------------------------------------------------------------------+
//|                                                             Функция поиска сигнала на покупку |
//+-----------------------------------------------------------------------------------------------+
bool bSignalBuy()
  {
   if(dMA > Open[1] && dMA < Close[1])
      return(true);

   return(false);
  }
//+-----------------------------------------------------------------------------------------------+
//|                                                             Функция поиска сигнала на продажу |
//+-----------------------------------------------------------------------------------------------+
bool bSignalSell()
  {
   if(dMA < Open[1] && dMA > Close[1])
      return(true);

   return(false);
  }
//+-----------------------------------------------------------------------------------------------+
//|                                                            Функция открытия ордера на покупку |
//+-----------------------------------------------------------------------------------------------+
void vOrderOpenBuy()
  {
   int iOTi = 0;   // Тикет ордера

   iOTi = ReversOrderSend(Symbol(), OP_BUY, LOT(), Ask, iSlippage, 0, 0, "", iMagic, 0, clrNONE);

// Проверим открылся ли ордер
   if(iOTi > 0)
      // Есди да, то выставим уровни убытка и прибыли
      vOrderModify(iOTi);
   else
      // Если нет, то получим ошибку
      vError(GetLastError());
  }
//+-----------------------------------------------------------------------------------------------+
//|                                                            Функция открытия ордера на продажу |
//+-----------------------------------------------------------------------------------------------+
void vOrderOpenSell()
  {
   int iOTi = 0;   // Тикет ордера

   iOTi = ReversOrderSend(Symbol(), OP_SELL, LOT(), Bid, iSlippage, 0, 0, "", iMagic, 0, clrNONE);

// Проверим открылся ли ордер
   if(iOTi > 0)
      // Есди да, то выставим уровни убытка и прибыли
      vOrderModify(iOTi);
   else
      // Если нет, то получим ошибку
      vError(GetLastError());
  }
//+-----------------------------------------------------------------------------------------------+
//|                                                                    Функция модификации ордера |
//+-----------------------------------------------------------------------------------------------+
void vOrderModify(int iOTi)
  {
   int    iOTy = -1;   // Тип ордера
   double dOOP = 0;    // Цена открытия ордера
   double dOSL = 0;    // Стоп Лосс
   int    iMag = 0;    // Идентификатор советника

   double dSL = 0;     // Уровень убытка
   double dTP = 0;     // Уровень прибыли

// Выберем по тикету открытый ордер, получим некоторые значения
   if(OrderSelect(iOTi, SELECT_BY_TICKET, MODE_TRADES))
     {
      iOTy = OrderType();
      dOOP = OrderOpenPrice();
      dOSL = OrderStopLoss();
      iMag = OrderMagicNumber();
     }

// Если ордер открыл данный советник, то входим в условие
   if(OrderSymbol() == Symbol() && OrderMagicNumber() == iMag)
     {
      // Если Стоп Лосс текущего ордера равен нулю, то модифицируем ордер
      if(dOSL == 0)
        {
         if(iOTy == OP_BUY)
           {
            dSL = NormalizeDouble(dOOP - iStopLoss * Point, Digits);
            dTP = NormalizeDouble(dOOP + iTakeProfit * Point, Digits);

            bool bOM = OrderModify(iOTi, dOOP, dSL, dTP, 0, clrNONE);
           }

         if(iOTy == OP_SELL)
           {
            dSL = NormalizeDouble(dOOP + iStopLoss * Point, Digits);
            dTP = NormalizeDouble(dOOP - iTakeProfit * Point, Digits);

            bool bOM = OrderModify(iOTi, dOOP, dSL, dTP, 0, clrNONE);
           }
        }
     }
  }
//+-----------------------------------------------------------------------------------------------+
//|                                                                      Функция обработки ошибок |
//+-----------------------------------------------------------------------------------------------+
void vError(int iErr)
  {
   switch(iErr)
     {
      case 129:   // Неправильная цена
      case 135:   // Цена изменилась
      case 136:   // Нет цен
      case 138:   // Новые цены
         Sleep(1000);
         RefreshRates();
         break;

      case 137:   // Брокер занят
      case 146:   // Подсистема торговли занята
         Sleep(3000);
         RefreshRates();
         break;
     }
  }
//+-----------------------------------------------------------------------------------------------+

//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
double LOT()
  {
   int n=0;
   double OL=dLots;
   for(int j = OrdersHistoryTotal()-1; j >= 0; j--)
     {
      if(OrderSelect(j, SELECT_BY_POS,MODE_HISTORY))
        {
         if(OrderSymbol() == Symbol() && OrderMagicNumber() == iMagic)
           {
            if(OrderProfit()<0)
              {
               if(n==0)
                  OL=NormalizeDouble(OrderLots()*K_Martin,DigitsLot);
               n++;
               if(n>=OrdersClose)
                 {
                  Comment("1");
                  return(dLots);
                 }
              }
            else
              {
               if(n==0)
                 {
                  Comment("2");
                  return(dLots);
                 }
               else
                 {
                  Comment("3");
                  return(OL);
                 }
              }
           }
        }
     }
   return(OL);
  }
//------------------------------------------------------------------
int ReversOrderSend (string symbol,int cmd,double volume,double price,int slippage,double stoploss,double takeprofit,string comment,int magic=0,datetime expiration=0,color arrow_color=CLR_NONE)
{
int Ret=0;
double sprd=MarketInfo(symbol,MODE_SPREAD)*Point;
//Print ("----------------------------",sprd);
if (ReversOrder==0) // Открываем ордера без разворота
{
Ret=OrderSend (symbol,cmd,volume,price,slippage,stoploss,takeprofit,comment,magic,expiration,arrow_color);
}
if (ReversOrder==1)
{
///////////////
if (cmd==OP_SELLSTOP) // Переворачиваем ордера OP_SELLSTOP
{
Ret=OrderSend (symbol,OP_BUYLIMIT,volume,price+sprd,slippage,takeprofit-sprd,stoploss-sprd,comment,magic,expiration,arrow_color);
}
if (cmd==OP_BUYSTOP) // Переворачиваем ордера OP_BUYSTOP
{
Ret=OrderSend (symbol,OP_SELLLIMIT,volume,price-sprd,slippage,takeprofit+sprd,stoploss+sprd,comment,magic,expiration,arrow_color);
}
///////////////
if (cmd==OP_SELL) // Переворачиваем ордера OP_SELL
{
Ret=OrderSend (symbol,OP_BUY,volume,price+sprd,slippage,takeprofit-sprd,stoploss-sprd,comment,magic,expiration,arrow_color);
}
if (cmd==OP_BUY) // Переворачиваем ордера OP_BUY
{
Ret=OrderSend (symbol,OP_SELL,volume,price-sprd,slippage,takeprofit+sprd,stoploss+sprd,comment,magic,expiration,arrow_color);
}
//////////////
if (cmd==OP_SELLLIMIT) // Переворачиваем ордера OP_SELLLIMIT
{
Ret=OrderSend (symbol,OP_BUYSTOP,volume,price+sprd,slippage,takeprofit-sprd,stoploss-sprd,comment,magic,expiration,arrow_color);
}
if (cmd==OP_BUYLIMIT) // Переворачиваем ордера OP_BUYLIMIT
{
Ret=OrderSend (symbol,OP_SELLSTOP,volume,price-sprd,slippage,takeprofit+sprd,stoploss+sprd,comment,magic,expiration,arrow_color);
}
}
return (Ret);
}

Предлагаю функцию реверса ордеров, для сливающих советников.

2010.08.24
www.mql5.com

Помню, поначалу сталкивался с вопросом, как грамотно "перевернуть" ордера с покупки на продажу и наоборот...

[Archive!] Any rookie question, Please why doesnt this [WARNING CLOSED!] Any newbie

Tretyakov Rostyslav 2021.07.29 18:21 #15483

Alexey Viktorov:

I've already said it clearly enough. I'll ask you a personal question.

Here are two functions and they both cycle through historical orders

There are two loops on the same orders. You cannot obtain everything that these functions return in one cycle, right?

Alexei, I already wrote, I know you are a good programmer!

But I am not a programmer, and what is "clear enough" for you is not so clear for me...

As for the two loops, for me"In one loop get everything" is not possible, because they return different types of data.

The perfect mechanical trading Beta version of MetaTrader Questions from Beginners MQL5

Valeriy Yastremskiy 2021.07.29 18:24 #15484

MakarFX:

Alexey, I already wrote, I know that you are a good programmer!

But I'm not a programmer and what is "clear enough" for you is dark forest for me...

As for the two loops, for me"get everything in one loop" is not possible, because they return different data types.

The returned types have nothing to do with it. If there are 2 loops on the same data with different checks and filters, you can always put everything in one loop, but the code will not read so clear, but it should work faster) At the stage of debugging I don't do everything in one loop. It is easier to look for bugs in different ones.

EA makes no trades How I assemble my Get the number of

Alexey Viktorov 2021.07.29 20:09 #15485

MakarFX:

Alexey, I already wrote, I know that you are a good programmer!

But I'm not a programmer and what is "clear enough" for you is dark forest for me...

As for the two loops, for me"In one loop to get everything" is not possible, because they return different types of data.

I have two variants.

Make variables at the global level. Then they will be available in all functions.

Pass the local variable by reference. Then if you change this variable, the local variable will be changed.

/********************Script program start function*******************/
void OnStart()
 {
  int a = 0;
  f_0(a);
  Print(a);
 }/******************************************************************/

void f_0(int & b)
 {
  b = 100;
 }

And there may be up to 64 such variables, God forbid I should lie. If I'm wrong, someone can correct me.

Read the documentation more attentively. It is written there in great detail.

Questions from Beginners MQL5 [ARCHIVE]Any rookie question, so Errors, bugs, questions

SGarnov 2021.07.30 05:35 #15486

MakarFX:

I have a conflict between pending orders.

First result. There is a conflict between currency pairs and EA has a conflict on pending order placement. For example, I have placed a pending order for EURUSD, EA has followed the algorithm (buy at 1.18901, open position, EA has set stop at 1.18751, take profit at 1.19051 and sell order at 1.18751) everything is ok as per plans.

But now it is time to open a deal at GBPUSD where the prices are different and the EA is doing everything right, except for setting a pending order. A Sell order at 1.39393 has triggered and the EA tried to open it, set a stop at 1.39633 and take 1.39153 but the buy order at 1.39633 was duplicated from EURUSD and the sell order was set at 1.18751)

I have just found another problem: a stop at 1.18751 and a sell pending order at 1.18901 and take 1.18595 were opened on EURUSD. The Expert Advisor didn't add the triggered stop, which is in the history.

These are the problems.

I will write an ea does not work Some help needed

SGarnov 2021.07.30 05:46 #15487

законопослушный гражданин:

hello!

I'm trying to screw in a flip of the trades to the owl.

What do you mean? A certain range of prices from which you buy/sell?

Alexey Viktorov 2021.07.30 06:20 #15488

SGarnov:

Good afternoon. Help with the EA. According to the strategy, if a stop triggered, then the EA should add (the number of points) to the next set takeaway
from the history by ID, but it does not do it for some reason.

What is wrong in the code?

if(isLimitOn && OrderSelect(OrderMagicNumber(), SELECT_BY_TICKET, MODE_HISTORY)){
            tpc += stop_loss;
            if(OrderSelect(lastMagic, SELECT_BY_TICKET)){
               if(OrderType() == OP_BUY) {
                  double tp_price = NormalizeDouble((OrderOpenPrice() + Point() * (tp + tpc)), Digits);
                  if(!OrderModify(OrderTicket(), OrderOpenPrice(), OrderStopLoss(), tp_price, OrderExpiration()))
                     Print("Ошибка модификации ордера:", GetLastError());
               }else if(OrderType() == OP_SELL){
                  double tp_price = NormalizeDouble((OrderOpenPrice() - Point() * (tp + tpc)), Digits);
                  if(!OrderModify(OrderTicket(), OrderOpenPrice(), OrderStopLoss(), tp_price, OrderExpiration()))
                     Print("Ошибка модификации ордера:", GetLastError());
               }
            }
               
            isLimitOn = false;
         }

Makar correctly pointed to OrderMagicNumber(), but misunderstood the error. Read the documentation for the syntax of this function... it should be either the index in the list of orders or the ticket of a certain order, but not a magik. And OrderTicket() will not help here. Do not try to put it there.

Any rookie question, so [ARCHIVE] Any rookie question, enum or switch? -

законопослушный гражданин 2021.07.30 06:35 #15489

SGarnov:

What do you mean? A certain price range from which you buy/sell?

The author of the code, as I understand it, suggested the following:

if owl opens a buy trade with stop and take, then his piece of code opens a sell trade at the same time in the same place (taking into account the spread) also with stop and take instead of a buy trade.

thus the logic of search for an entry point of the EA does not change, and only the direction with spread taken into account changes.

this is exactly what i need

Searching for market patterns I will write an how much does a

законопослушный гражданин 2021.07.30 06:47 #15490

MakarFX:

Describe in a nutshell what you want from this EA (the logic of operation),

I think you have a lot of unnecessary things in your code or I don't understand something.

owls should open trades according to their own algorithm

if the stop, the next trade with a Martin, and so on until the number of multiplications I specified (function -OrdersClose = .....;).

Further, if owl is disabled along with the terminal, just press "auto-trade" button with another owl, then the next trade will start with the starting lot, not with the last one increased by a martingale.

It would also be nice to attach a schedule to it, but this idea has only just occurred to me.

For example: it was activated at 10-00 on Monday with starting lot, then it was switched off during the day when some result was achieved, and on Tuesday morning it was activated again at 10-00 and started with starting lot again.

Everything.

Any rookie question, so Can anyone add a I will write a

Any questions from newcomers on MQL4 and MQL5, help and discussion on algorithms and codes - page 1549