Bot Closes trades immediately it gets into them why?

[[Deleted]]

I have a bot that is working fine in the backtesting, but in live trades, it closes trades immediately its opened closing them in losses, why is this? Kindly help and thanks in advance. Below is the code

[amando]

without code impossible

[William Roeder]

1. string symbol= Symbol();
   int ticket= OrderTicket();

   Those are not assignments; they are initialization of a common (globally declared), or static variable with a constant. They work exactly the same way in MT4/MT5/C/C++.

   1. They are initialized once on program load.

   2. They don't update unless you assign to them.

   3. In C/C++ you can only initialize them with constants, and they default to zero. In MTx you should only initialize them with constants. There is no default in MT5, or MT4 with strict (which you should always use).

      MT4/MT5 actually compiles with non-constants, but the order that they are initialized is unspecified and

      Don't try to use any price (or indicator) or server related functions in OnInit (or on load or in OnTimer before you've received a tick), as there may be no connection/chart yet:

      1. Terminal starts.
      2. Indicators/EAs are loaded. Static and globally declared variables are initialized. (Do not depend on a specific order.)
      3. OnInit is called.
      4. For indicators OnCalculate is called with any existing history.
      5. Human may have to enter password, connection to server begins.
      6. New history is received, OnCalculate called again.
      7. New tick is received, OnCalculate/OnTick is called. Now TickValue, TimeCurrent, account information and prices are valid.

   4. Unlike indicators, EAs are not reloaded on chart change, so you must reinitialize them, if necessary.
                external static variable - MQL4 programming forum #2 (2013)

2. Jones John:  it closes trades immediately its opened closing them in losses, why is this?
   

   Use the debugger or print out your variables, including _LastError and prices and find out why. Do you really expect us to debug your code for you?
             Code debugging - Developing programs - MetaEditor Help
             Error Handling and Logging in MQL5 - MQL5 Articles (2015)
             Tracing, Debugging and Structural Analysis of Source Code - MQL5 Articles (2011)
             Introduction to MQL5: How to write simple Expert Advisor and Custom Indicator - MQL5 Articles (2010)

3.        if(OrderType()==OP_SELL)
            OrderClose(OrderTicket(),OrderLots(),PriceBid,0,NULL);
          if(OrderType()==OP_BUY)
            OrderClose(OrderTicket(),OrderLots(),PriceAsk,0,NULL);

   You can use OrderClosePrice() instead of Bid/Ask and be direction independent — no need to check order type to get the close price.