I need coding help (hedge ea)

Priit Sink 2020.02.10 02:36

Why is this ea not opening any trades when all the parameters are reached.

I wish to combine this ea with my other ea but can not figure out the problem with the code.

Original code from here: https://www.forexfactory.com/showthread.php?t=325991
I fixed all the warnings in original ea but still it is not opening any trades.

Thank you for helping me in advance!

//+------------------------------------------------------------------+
//|            Profit Protection, Stop Loss Hedge Balance Trader.mq4 |
//|                                    Copyright © 2011, DancingPhil |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2011, DancingPhil"
#property link      "bad-boy-phil@hotmail.com"

extern int    Magic        = 6996;
extern int    LookBack     = 3;     // Bars back from current open to look for a Fractal
extern int    Slippage     = 0;
extern int    TakeprofitHP = 30;
extern int    TakeprofitML = 1000; //TakeProfitML is the pips in profit this trade can be closed at
extern int    TakeprofitFM = 30;
extern double FM           = 0.30;
extern int    Stoploss     = 0;
extern int    TrailingStop = 300;
extern double MaxLoss      = 0.25;
extern double HeapsProfit  = 0.26;


string     Comments = "";
double     LowestFreeMargin=1000000;
double     StartingEquity=0;
double     WorstEquity=0;
double     BestEquity=0;
double     TargetBestEquity=0;
bool       buyFlag = false, sellFlag = false;
datetime   barStart = 0;
bool       dummyResult;
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {

//----
   StartingEquity=AccountEquity();
   
   if(Digits == 5)
   {
      TakeprofitML = TakeprofitML * 10;
      TakeprofitHP = TakeprofitHP * 10;
      TakeprofitFM = TakeprofitFM * 10;            
      Stoploss = Stoploss * 10;
      
   }   
   
//----
   return(0);
  }
  
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
//----
/*if (barStart < Time[0]) //start of new bar
{
barStart = Time[0];
buyFlag = false;
sellFlag = false;
}
*/
   double total_selllots =0;   //define variable total_sellots, starting at =0
   double total_buylots =0;   //define variable total_buylots, starting at =0
   double lotdifference=0;
   int t;

      double   upfractal = GetFractal(MODE_UPPER),
               dnfractal = GetFractal(MODE_LOWER);

   //Calculate total_buylots
 
   for (int i = OrdersTotal()-1; i >=0; i--)   //scanning all trades
   {
      if (! OrderSelect(i, SELECT_BY_POS, MODE_TRADES)) { Sleep(10); continue; }
      if(OrderSymbol() == Symbol() ) //check the currency and magic number are correct
      {         
         if (OrderType() == OP_BUY)  //with OP_BUY trades
         {
            total_buylots = total_buylots + OrderLots();  //add them up and keep a tally of them
 
         }
   //Calculate total_selllots
 
         if (OrderType() == OP_SELL) //with the OP_SELL trades
         {
            total_selllots = total_selllots + OrderLots();    //add them up and keep a tally of them too
         }

      }
   }
   if (LowestFreeMargin>AccountFreeMargin())
   {
   LowestFreeMargin=AccountFreeMargin();
   }   
   if (BestEquity<AccountEquity())
   {
   BestEquity=AccountEquity();
   }
   string strTotalLots;
   strTotalLots="Total BUY  LOTS = " + DoubleToStr(total_buylots,2) + "\n";
   strTotalLots=strTotalLots+"Total SELL LOTS = " + DoubleToStr(total_selllots,2) + "\n";
   strTotalLots=strTotalLots+"Total ALL  LOTS = " + DoubleToStr(total_selllots+total_buylots,2) + "\n";
   strTotalLots=strTotalLots+"StartingEquity = " + DoubleToStr(StartingEquity,2) + "\n";
   strTotalLots=strTotalLots+"BestEquity = " + DoubleToStr(BestEquity,2) + "\n";
   strTotalLots=strTotalLots+"Max Loss = " + DoubleToStr((1-MaxLoss)*BestEquity,2) + "\n";
   strTotalLots=strTotalLots+"Target Profit = " + DoubleToStr((1+HeapsProfit)*StartingEquity,2) + "\n";
   strTotalLots=strTotalLots+"CurrentEquity = " + DoubleToStr(AccountEquity(),2) + "\n";
   strTotalLots=strTotalLots+"Lowest Free Margin = " + DoubleToStr(LowestFreeMargin,2) + "\n";
   Comment(strTotalLots); 
   //--------------------------------------------------------------------------------------------------------------------------------
   if( total_buylots<total_selllots)
   if (AccountEquity()<((1-MaxLoss)*BestEquity))

   {

      lotdifference = total_selllots - total_buylots; //Check difference in lots, if buylots is smaller then we will buy
      t = OrderSend(Symbol(),OP_BUY,lotdifference,Ask,Slippage,0,0,Comments + "BuyOnMaxLoss",Magic,0,Blue);
      BestEquity=AccountEquity();
      if (t > 1){
      if (OrderSelect(t, SELECT_BY_TICKET))dummyResult=OrderModify(OrderTicket(),OrderOpenPrice(),0,Ask + TakeprofitML*Point,0,Blue ); 
      else Print("OrderModify() ticket=",t," failed with error code ",GetLastError());
      }
      else Print("OrderSend ticket=",t," failed with error code ",GetLastError()); 
  
   }
   if( total_buylots>total_selllots)
   if (AccountEquity()<((1-MaxLoss)*BestEquity))
   
   {

      lotdifference = total_buylots - total_selllots; //Check difference in lots, if buylots is smaller then we will sell
      t = OrderSend(Symbol(),OP_SELL,lotdifference,Bid,Slippage,0,0,Comments + "SellOnMaxLoss",Magic,0,Blue);
      BestEquity=AccountEquity();
      if (t > 1){
      if (OrderSelect(t, SELECT_BY_TICKET))dummyResult=OrderModify(OrderTicket(),OrderOpenPrice(),0,Bid - TakeprofitML*Point,0,Red ); 
      else Print("OrderModify() ticket=",t," failed with error code ",GetLastError());
      }
      else Print("OrderSend ticket=",t," failed with error code ",GetLastError());    
   }
   if( total_buylots<total_selllots)
   if (AccountEquity()>((1+HeapsProfit)*StartingEquity))

   {

      lotdifference = total_selllots - total_buylots; //Check difference in lots, if buylots is smaller then we will buy
      t = OrderSend(Symbol(),OP_BUY,lotdifference,Ask,Slippage,0,0,Comments + "BuyOnHeapsProfit",Magic,0,Red);
      StartingEquity=AccountEquity();
      if (t > 1){
      if (OrderSelect(t, SELECT_BY_TICKET))dummyResult=OrderModify(OrderTicket(),OrderOpenPrice(),0,Ask + TakeprofitHP*Point,0,Blue ); 
      else Print("OrderModify() ticket=",t," failed with error code ",GetLastError());
      }
      else Print("OrderSend ticket=",t," failed with error code ",GetLastError()); 
  
   }
   if( total_buylots>total_selllots)
   if (AccountEquity()>((1+HeapsProfit)*StartingEquity))
   
   {

      lotdifference = total_buylots - total_selllots; //Check difference in lots, if buylots is smaller then we will sell
      t = OrderSend(Symbol(),OP_SELL,lotdifference,Bid,Slippage,0,0,Comments + "SellOnHeaps",Magic,0,Red);
      StartingEquity=AccountEquity();
      if (t > 1){
      if (OrderSelect(t, SELECT_BY_TICKET))dummyResult=OrderModify(OrderTicket(),OrderOpenPrice(),0,Bid - TakeprofitHP*Point,0,Red ); 
      else Print("OrderModify() ticket=",t," failed with error code ",GetLastError());
      }
      else Print("OrderSend ticket=",t," failed with error code ",GetLastError());    
   }
   if( total_buylots<total_selllots)
   if (AccountFreeMargin()<(FM*BestEquity))

   {

      lotdifference = total_selllots - total_buylots; //Check difference in lots, if buylots is smaller then we will buy
      t = OrderSend(Symbol(),OP_BUY,(lotdifference*0.5),Ask,Slippage,0,0,Comments + "Hedge Trade",Magic,0,Green);

      if (t > 1){
      if (OrderSelect(t, SELECT_BY_TICKET))dummyResult=OrderModify(OrderTicket(),OrderOpenPrice(),0,0,0,Blue ); 
      else Print("OrderModify() ticket=",t," failed with error code ",GetLastError());
      }
      else Print("OrderSend ticket=",t," failed with error code ",GetLastError()); 
  
   }
   if( total_buylots>total_selllots)
   if (AccountFreeMargin()<(FM*BestEquity))
   
   {

      lotdifference = total_buylots - total_selllots; //Check difference in lots, if buylots is smaller then we will sell
      t = OrderSend(Symbol(),OP_SELL,(lotdifference*0.5),Bid,Slippage,0,0,Comments + "Hedge Trade",Magic,0,Green);

      if (t > 1){
      if (OrderSelect(t, SELECT_BY_TICKET))dummyResult=OrderModify(OrderTicket(),OrderOpenPrice(),0,0,0,Red ); 
      else Print("OrderModify() ticket=",t," failed with error code ",GetLastError());
      }
      else Print("OrderSend ticket=",t," failed with error code ",GetLastError());    
   }   
   
//----
   return(0);
  }
//+------------------------------------------------------------------+

double GetFractal(int mode)
   {
      double tempup=0, tempdn=0, fup=0, fdn=0;
      tempup = iFractals(Symbol(), 0, MODE_UPPER, LookBack);
      tempdn = iFractals(Symbol(), 0, MODE_LOWER, LookBack);
      if(tempup != 0) fup = tempup;
      if(tempdn != 0) fdn = tempdn;

      if ( fup != 0 && fdn == 0 && mode == MODE_UPPER ) return(fup);
      if ( fdn != 0 && fup == 0 && mode == MODE_LOWER ) return(fdn);
      return(0);
   }
   
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick()
{
    CalculateLots();        //display lots on chart
    
    if (OrdersTotal() > 0) {
        TrailStops();      //trailing stop
        return;
    }
    

}
//+------------------------------------------------------------------+
//+------------------------------------------------------------------+
//| Trailing stop function                                           |
//+------------------------------------------------------------------+
void TrailStops()
{
    //int trailingStop = 300;

    for (int i = 0; i < OrdersTotal(); i++) {
        //if((!OrderSelect(i,SELECT_BY_POS,MODE_TRADES))) {
        if((!OrderSelect(i,SELECT_BY_POS,MODE_TRADES))&&(OrderMagicNumber()==Magic)) {
            continue;
        }
        
        if (OrderSymbol() != Symbol()) {
            continue;
        }
        
        if (OrderType() == OP_BUY) {
            if (Bid - OrderOpenPrice() > TrailingStop * Point && OrderStopLoss() < Bid - TrailingStop * Point) {
                if (!OrderModify(OrderTicket(), OrderOpenPrice(), Bid - TrailingStop * Point, OrderTakeProfit(), 0, Green)) {
                    Print("OrderModify error ",GetLastError());
                }
                return;
            }
        } else if (OrderType() == OP_SELL) {
            if (OrderOpenPrice() - Ask > TrailingStop * Point && OrderStopLoss() > Ask + TrailingStop * Point) {
                if (!OrderModify(OrderTicket(), OrderOpenPrice(), Ask + TrailingStop * Point, OrderTakeProfit(), 0, Green)) {
                    Print("OrderModify error ",GetLastError());
                }
                return;
            }
        }
    }
}
//+------------------------------------------------------------------+
//| Expert initialization function                                   | 
//+------------------------------------------------------------------+
void PrintText(string object, string text, int x, int y) 
{
   ObjectCreate(object, OBJ_LABEL, 0, 0, 0);
   ObjectSetText(object, text, 9, "Verdana", Yellow);
   ObjectSet(object, OBJPROP_CORNER, 0); 
   ObjectSet(object, OBJPROP_XDISTANCE, x);
   ObjectSet(object, OBJPROP_YDISTANCE, y);
}

//+------------------------------------------------------------------+
//| Lot calculator function                                          | 
//+------------------------------------------------------------------+
void CalculateLots() 
{
      double totalBuyLots = 0;
      double totalSellLots = 0;
      
      for(int i=0; i < OrdersTotal(); i++) 
      {
         if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES) == true)
         {
            //if(OrderSymbol() == Symbol()) 
            {
               if(OrderType() == OP_BUY)
                  totalBuyLots += OrderLots(); 
               if(OrderType() == OP_SELL)
                  totalSellLots += OrderLots(); 
            }
         }    
      }
      
      string sBuyText = "Total Buy = "; 
      sBuyText += DoubleToString(totalBuyLots, 2);
      string sSellText = "Total Sell = ";
      sSellText += DoubleToString(totalSellLots, 2); 
      
      PrintText("BuyObject", sBuyText, 20, 20);
      PrintText("SellObject", sSellText, 20, 40); 
}

Files:

Equity_and_Free_Margin_Manager_fix.mq4 26 kb

William Roeder 2020.02.10 14:15 #1

int init()
⋮
int deinit()
⋮
int start()
⋮
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick()
{
    CalculateLots();        //display lots on chart

Use the old or start using the new Event Handling Functions.
Event Handling Functions - Functions - Language Basics - MQL4 Reference

Do not use both.

Use the debugger or print out your variables, including _LastError and prices and . Do you really expect us to debug your code for you?

Your code	double GetFractal(int mode) { double tempup=0, tempdn=0, fup=0, fdn=0; tempup = iFractals(Symbol(), 0, MODE_UPPER, LookBack); tempdn = iFractals(Symbol(), 0, MODE_LOWER, LookBack); if(tempup != 0) fup = tempup; if(tempdn != 0) fdn = tempdn; if ( fup != 0 && fdn == 0 && mode == MODE_UPPER ) return(fup); if ( fdn != 0 && fup == 0 && mode == MODE_LOWER ) return(fdn); return(0); }
Simplified	double GetFractal(int mode) { double temp= iFractals(Symbol(), 0, mode, LookBack); return temp==EMPTYVALUE ? 0 : temp; }

Your code

double GetFractal(int mode)
   {
      double tempup=0, tempdn=0, fup=0, fdn=0;
      tempup = iFractals(Symbol(), 0, MODE_UPPER, LookBack);
      tempdn = iFractals(Symbol(), 0, MODE_LOWER, LookBack);
      if(tempup != 0) fup = tempup;
      if(tempdn != 0) fdn = tempdn;

      if ( fup != 0 && fdn == 0 && mode == MODE_UPPER ) return(fup);
      if ( fdn != 0 && fup == 0 && mode == MODE_LOWER ) return(fdn);
      return(0);
   }

Simplified

double GetFractal(int mode)
   {
      double temp= iFractals(Symbol(), 0, mode, LookBack);
      return temp==EMPTYVALUE ? 0 : temp;
   }

New comment