stop repeating orders in same point

[Ma1991Lak7]

How i can stop Duplicate Transactions in EA 

Please help me 

bool OrderIsActive(int ordertype)

{

  for(int i=0;i<OrdersTotal();i++) {

        OrderSelect(i, SELECT_BY_POS, MODE_TRADES);

        if (OrderMagicNumber()==MagicNumber && Symbol()==OrderSymbol() && OrderType()==ordertype)

           return(true);

  }

  return(false);

}

Is this true ??? If not, what is correct

[Carl Schreiber]

1. Please use SRC button if you post code
2. Here it is not necessary but make it your habit: count the orders down (in case you want to close one or more!)
   
3. Check OrderSelect():
   

   bool OrderIsActive(int ordertype)
   {
     for(int i=OrdersTotal()-1;i>=0;i--) {
           if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES)) continue;
           if (OrderMagicNumber()==MagicNumber && Symbol()==OrderSymbol() && OrderType()==ordertype)
   
              return(true);
     }
     return(false);
   }

   
   

But this shouldn't be the problem - I guess it is somewhere else.

[William Roeder]

Carl Schreiber: I guess it is somewhere else.

In the presence of multiple orders (one EA multiple charts, multiple EA's, manual trading) You must count down when closing/deleting/modifying in a position loop. Get in the habit of always counting down. Loops and Closing or Deleting Orders - MQL4 forum and check OrderSelect. What are Function return values ? How do I use them ? - MQL4 forum and Common Errors in MQL4 Programs and How to Avoid Them - MQL4 Articles You must RefreshRates after sleep and between multiple server calls if you want to use the Predefined Variables (Bid/Ask) or OrderClosePrice() instead.