Sendmail problems..
Hello again folks,
I have written an indicator which looks for a pinbar after a moving average cross over and have been trying in every spare minute for the last week to reliably get it to send me an email when conditions are satisfied. I have searched and read posts and documentation and the best i can come up with is what i will post below. My drama is that it sends way too many mails. I have currently got it set to a possible solution i read on one of raptorUKs replies to a similar problem...only send emails when looking at the 1st few bars. The way i have programmed it seems to work ok sometimes but not others (still starts sending bulk emails). Any help or push in the right direction would be greatly appreciated. Thanks.
Isn't buyemail a bool ? why this ?
if(buyemail > 0)
why is this test inside your loop ?
When do you want the email ? under what conditions ? when do you want it not to repeat ? under what conditions ? when do you want it to restart sending emails ?
buypin=(bar1C>=bar1H-pinrange/2.5 && bar1O>=bar1H-pinrange/2.5); // if(bar1C>=bar1H-pinrange/2.5 && bar1O>=bar1H-pinrange/2.5) // buypin=(true); // else // buypin=(false);
Isn't buyemail a bool ? why this ?
why is this test inside your loop ?
When do you want the email ? under what conditions ? when do you want it not to repeat ? under what conditions ? when do you want it to restart sending emails ?
OK raptor, thanks for that im guessing i just have to write some code to read current time, and indicator signal time etc, etc.. i can see how that will work...ill give it a try...more learning to do! Oh yeah and i thought instead of writing buyemail=(true) that >0 would do the same thing...0 being false...that not good practice?? Could it be misinterpreted?
OK raptor, thanks for that im guessing i just have to write some code to read current time, and indicator signal time etc, etc.. i can see how that will work...ill give it a try...more learning to do! Oh yeah and i thought instead of writing buyemail=(true) that >0 would do the same thing...0 being false...that not good practice?? Could it be misinterpreted?
You could just write . . .
if(buyemail)
. . . . and then it's clear to everyone that buyemail is a bool.
Simply your bools
I
Ha...yeah i am aware that the else is unnecessary..and it doesnt look great....its only there because i started with this indicator as my very 1st indicator and ive added and changed heaps to make it do different things as ive being going...thats been there since the beginning and i havent tidied it up...ill get better ..the last programming i did was basic on a zx spectrum in 1980 something!
You could just write . . .
. . . . and then it's clear to everyone that buyemail is a bool.
Ah simple as that ....cool thanks... so would i be correct in thinking i could also tidy up a stament such as
if(bar2fastMAvalue>bar2slowMAvalue && bar1fastMAvalue<bar1slowMAvalue) bar1xdn=(true);
to
if(bar2fastMAvalue>bar2slowMAvalue && bar1fastMAvalue<bar1slowMAvalue)
bar1xdn;
...simple basic stuff i know but once i know for definite i wont forget...
Ah simple as that ....cool thanks... so would i be correct in thinking i could also tidy up a stament such as
to
...simple basic stuff i know but once i know for definite i wont forget...
Not quite . . . you could do this . . .
bar1xdn = (bar2fastMAvalue > bar2slowMAvalue && bar1fastMAvalue < bar1slowMAvalue);
. . . and it would be set to true or false, if you didn't want it to take a false value then you would do this . . .
if(bar2fastMAvalue > bar2slowMAvalue && bar1fastMAvalue < bar1slowMAvalue) bar1xdn = true;
Not quite . . . you could do this . . .
. . . and it would be set to true or false, if you didn't want it to take a false value then you would do this . . .
Ha yeah of course why didnt i think of that!? Just one more query on the subject of if statements raptor, after the test line can i tell it to do more than one thing eg some how make the following just one test line with multiple assignments after...do i use curly brackets or something like that...?
if(buypin>0 && bar1xup>0 || bar2xup>0 || bar3xup>0 || bar4xup>0 || bar5xup>0 || bar6xup>0 || bar7xup>0 || bar8xup>0 || bar9xup>0) ExtMapBuffer1[i]=Low[i]-80*Point; if(buypin>0 && bar1xup>0 || bar2xup>0 || bar3xup>0 || bar4xup>0 || bar5xup>0 || bar6xup>0 || bar7xup>0 || bar8xup>0 || bar9xup>0) buyemail=(true);
Ha yeah of course why didnt i think of that!? Just one more query on the subject of if statements raptor, after the test line can i tell it to do more than one thing eg some how make the following just one test line with multiple assignments after...do i use curly brackets or something like that...?
Yep, curly braces is exactly what you need . . .
if(buypin > 0 && bar1xup > 0 || bar2xup > 0 || bar3xup > 0 || bar4xup > 0 || bar5xup > 0 || bar6xup > 0 || bar7xup > 0 || bar8xup > 0 || bar9xup > 0) { ExtMapBuffer1[i] = Low[i] - 80 * Point; buyemail = true; }
One other thing to note, be careful with your precedence, to avoid misunderstanding use ( ) brackets . . . some things are changing currently with MetaEditor and the Terminal with AND and OR precedence. Also, be consistent with your indenting, you can see my preference, pick your favoured style and apply it consistently.
- Free trading apps
- Over 8,000 signals for copying
- Economic news for exploring financial markets
You agree to website policy and terms of use
Hello again folks,
I have written an indicator which looks for a pinbar after a moving average cross over and have been trying in every spare minute for the last week to reliably get it to send me an email when conditions are satisfied. I have searched and read posts and documentation and the best i can come up with is what i will post below. My drama is that it sends way too many mails. I have currently got it set to a possible solution i read on one of raptorUKs replies to a similar problem...only send emails when looking at the 1st few bars. The way i have programmed it seems to work ok sometimes but not others (still starts sending bulk emails). Any help or push in the right direction would be greatly appreciated. Thanks.