Whats wrong with this Fisher Indicator?

New comment
 

Hi All,

I came across this Fisher indicator recently, however it does not work like a typical indicator. When I add it to a chart, it looks different as from the backtest. Any idea how to get them to line up properly and how to call this indicator properly in iCustom? The funny thing about this indicator is that when I click to edit its properties (on the backtest indicator window) and without making any changes if I press OK, it reverts to the lower indicator pattern. Very odd.

 

 

 

Here is the code ...

#property  indicator_separate_window
#property  indicator_buffers 3
#property  indicator_color1  Black
#property  indicator_color2  Lime
#property  indicator_color3  Red
 
extern int period=10;

double         ExtBuffer0[];
double         ExtBuffer1[];
double         ExtBuffer2[];


int init()
  {
   
   
   SetIndexStyle(0,DRAW_HISTOGRAM,STYLE_SOLID,2,Red);
   SetIndexStyle(1,DRAW_HISTOGRAM,STYLE_SOLID,2,Lime);
   SetIndexStyle(2,DRAW_HISTOGRAM);
   IndicatorDigits(Digits+1);

   SetIndexBuffer(0,ExtBuffer0);
   SetIndexBuffer(1,ExtBuffer1);
   SetIndexBuffer(2,ExtBuffer2);

   IndicatorShortName("Fisher");
   SetIndexLabel(1,NULL);
   SetIndexLabel(2,NULL);

   return(0);
  }


int start()
  {
   //int     period=10;
   int    limit;
   int    counted_bars=IndicatorCounted();
   double prev,current,old;
   double Value=0,Value1=0,Value2=0,Fish=0,Fish1=0,Fish2=0;
   double price;
   double MinL=0;
   double MaxH=0;  
   

   if(counted_bars>0) counted_bars--;
   limit=Bars-counted_bars;


   for(int i=0; i<limit; i++)
    {  MaxH = High[Highest(NULL,0,MODE_HIGH,period,i)];
       MinL = Low[Lowest(NULL,0,MODE_LOW,period,i)];
      price = (High[i]+Low[i])/2;
      Value = 0.33*2*((price-MinL)/(MaxH-MinL)-0.5) + 0.67*Value1;     
      Value=MathMin(MathMax(Value,-0.999),0.999); 
      ExtBuffer0[i]=0.5*MathLog((1+Value)/(1-Value))+0.5*Fish1;
      Value1=Value;
      Fish1=ExtBuffer0[i];
      
    }


   bool up=true;
   for(i=limit-2; i>=0; i--)
     {
      current=ExtBuffer0[i];
      prev=ExtBuffer0[i+1];
           
      if (((current<0)&&(prev>0))||(current<0))   up= false;    
      if (((current>0)&&(prev<0))||(current>0))   up= true;
      
      if(!up)
        {
         ExtBuffer2[i]=current;
         ExtBuffer1[i]=0.0;
        }
        
       else
         {
          ExtBuffer1[i]=current;
          ExtBuffer2[i]=0.0;
         }
     }

   return(0);
  }

 Thx

 
cool_dude:

Hi All,

I came across this Fisher indicator recently, however it does not work like a typical indicator. When I add it to a chart, it looks different as from the backtest. Any idea how to get them to line up properly and how to call this indicator properly in iCustom? 

Not all Indicators work correctly in the Strategy Tester, see here:  https://www.mql5.com/en/forum/143310/page2#753302

You should replace Highest and Lowest they are obsolete functions. 

iCustom,  read here:  Detailed explanation of iCustom - MQL4 forum 

 
  1. The indicator repaints. It uses future values on previous bars
       for(int i=0; i<limit; i++){  
      :
      Value = 0.33*2*((price-MinL)/(MaxH-MinL)-0.5) + 0.67*Value1; <-- Value from bar 0 used in bar 1
      :
      Value1=Value;
    Always count down.
  2. Contradictory information on IndicatorCounted() - MQL4 forum

New comment