Why my code not run

New comment
  
//+-----------------------------------------------------------------+
#define MAGICMA  20050610

extern double Lots               = 0.1;
extern double MaximumRisk        = 0.02;
extern double DecreaseFactor     = 3;
extern double MovingPeriod       = 12;
extern double MovingShift        = 6;
extern double MovingPeriod1       = 100;
extern double MovingShift1        = 0;
//+------------------------------------------------------------------+
//| Calculate open positions                                         |
//+------------------------------------------------------------------+
int CalculateCurrentOrders(string symbol)
  {
   int buys=0,sells=0;
//----
   for(int i=0;i<OrdersTotal();i++)
     {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
      if(OrderSymbol()==Symbol() && OrderMagicNumber()==MAGICMA)
        {
         if(OrderType()==OP_BUY)  buys++;
         if(OrderType()==OP_SELL) sells++;
        }
     }
//---- return orders volume
   if(buys>0) return(buys);
   else       return(-sells);
  }
//+------------------------------------------------------------------+
//| Calculate optimal lot size                                       |
//+------------------------------------------------------------------+
double LotsOptimized()
  {
   double lot=Lots;
   int    orders=HistoryTotal();     // history orders total
   int    losses=0;                  // number of losses orders without a break
//---- select lot size
   lot=NormalizeDouble(AccountFreeMargin()*MaximumRisk/1000.0,1);
//---- calcuulate number of losses orders without a break
   if(DecreaseFactor>0)
     {
      for(int i=orders-1;i>=0;i--)
        {
         if(OrderSelect(i,SELECT_BY_POS,MODE_HISTORY)==false) { Print("Error in history!"); break; }
         if(OrderSymbol()!=Symbol() || OrderType()>OP_SELL) continue;
         //----
         if(OrderProfit()>0) break;
         if(OrderProfit()<0) losses++;
        }
      if(losses>1) lot=NormalizeDouble(lot-lot*losses/DecreaseFactor,1);
     }
//---- return lot size
   if(lot<0.1) lot=0.1;
   return(lot);
  }
//+------------------------------------------------------------------+
//| Check for  order conditions                                  |
//+------------------------------------------------------------------+
void CheckForOpen()
  {
   double ma;
   double ma1;
   int    res;
//---- go trading only for first tiks of new bar
   if(Volume[0]>1) return;
//---- get Moving Average 
   ma=iMA(NULL,0,MovingPeriod,MovingShift,MODE_SMA,PRICE_CLOSE,0);
   ma1=iMA(NULL,0,MovingPeriod1,MovingShift1,MODE_SMA,PRICE_CLOSE,0);
//---- sell conditions
   if(ma<ma1)  
     {
      res=OrderSend(Symbol(),OP_SELL,LotsOptimized(),Bid,3,20,20,"",MAGICMA,0,Red);
      return;
     }
//---- buy conditions
   if(ma<ma1)  
     {
      res=OrderSend(Symbol(),OP_BUY,LotsOptimized(),Ask,3,20,20,"",MAGICMA,0,Blue);
      return;
     }
//---- calculate open orders by current symbol
   if(CalculateCurrentOrders(Symbol())==0) CheckForOpen();
   return;
   
//----
  }
//+------------------------------------------------------------------+
 
phipho:

Why my code not run

Where is your start() function ?
 
phipho:

Why don't you use your old code https://www.mql5.com/en/forum/142274 and please don't double post.
  
//+------------------------------------------------------------------+
//| Start function                                                   |
//+------------------------------------------------------------------+
void start()
  {
//---- check for history and trading
   if(Bars<100 || IsTradeAllowed()==false) return;
//---- calculate open orders by current symbol
   if(CalculateCurrentOrders(Symbol())==0) CheckForOpen();
   
//----
  }
//+------------------------------------------------------------------+ when i put start it not run . I can't find mistake
 
phi.nuts:
Tại sao bạn không sử dụng mã cũ của bạn  https://www.mql5.com/en/forum/142274  và xin vui lòng không bài đôi.

i old code can't use takeprofit and stop loss. and i must write new code
 
phipho:

when i put start it not run . I can't find mistake

Add some debugging Print();  messages/statements so you can tell what parts of your code are being executed . . . for example print your MA values
New comment