Error in code

New comment
 

Hello friends this is checkmail and have an Indicator which is to display up and down arrows on adr levels but its not displaying it when attached to charts.

Could anyone correct the code.

Here is the code : 

//+------------------------------------------------------------------+
//|                                                          adr.mq4 |
//|                      Copyright © 2011, MetaQuotes Software Corp. |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2011, MetaQuotes Software Corp."
#property link      "http://www.metaquotes.net"

#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 Blue
#property indicator_color2 Red
//---- input parameters
extern int AdrLimit=10;
//---- buffers
double ExtMapBuffer1[];
double ExtMapBuffer2[];
//----
double adrdel,adrdelb4,adrdelb4b4;
int    nShift;   
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
//---- indicators
    SetIndexStyle(0, DRAW_ARROW, 0, 1);
    SetIndexArrow(0, 233);
    SetIndexBuffer(0, ExtMapBuffer1);
//----
    SetIndexStyle(1, DRAW_ARROW, 0, 1);
    SetIndexArrow(1, 234);
    SetIndexBuffer(1, ExtMapBuffer2);
//---- name for DataWindow and indicator subwindow label
    IndicatorShortName("ADr(" +AdrLimit  + ")");
    SetIndexLabel(0, "ADRcrUp");
    SetIndexLabel(1, "ADRcrDn"); 
//----
    switch(Period())
      {
        case     1: nShift = 1;   break;    
        case     5: nShift = 3;   break; 
        case    15: nShift = 5;   break; 
        case    30: nShift = 10;  break; 
        case    60: nShift = 15;  break; 
        case   240: nShift = 20;  break; 
        case  1440: nShift = 80;  break; 
        case 10080: nShift = 100; break; 
        case 43200: nShift = 200; break;               
      }
//----
    return(0);
  }
//+------------------------------------------------------------------+
//| Custor indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//----
    return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
  {
    int limit;
    int counted_bars = IndicatorCounted();
//---- check for possible errors
    if(counted_bars < 0) 
        return(-1);
//---- last counted bar will be recounted
    if(counted_bars > 0) 
        counted_bars--;
    limit = Bars - counted_bars;
//----
    for(int i = 0; i < limit; i++)
      {
        adrdel=iCustom(NULL,0,"adrdeltshistorical",0,i);
         adrdelb4=iCustom(NULL,0,"adrdeltshistorical",0,i+1);
          adrdelb4b4=iCustom(NULL,0,"adrdeltshistorical",0,i+2);
          
        //----
        if(adrdel>AdrLimit&& adrdelb4b4>AdrLimit&& adrdel>adrdelb4)
            ExtMapBuffer1[i] = Low[i] - nShift*Point;
        //----
          if(adrdel<-1*AdrLimit&& adrdelb4b4<AdrLimit&& adrdel<adrdelb4)
            ExtMapBuffer2[i] = High[i] + nShift*Point;
      }
//----
    return(0);
  }
//+------------------------------------------------------------------+
 

A) I think that 

          if(adrdel<-1*AdrLimit&& adrdelb4b4<AdrLimit&& adrdel<adrdelb4)
            ExtMapBuffer2[i] = High[i] + nShift*Point;

should be

          if(adrdel<-1*AdrLimit&& adrdelb4b4<-1*AdrLimit&& adrdel<adrdelb4)
            ExtMapBuffer2[i] = High[i] + nShift*Point;

buit it should display SOMETHING even if at the wrong time.

B) verify that indicator "adrdeltshistorical" returns the value you want as the first indicator

C) verify that indicator "adrdeltshistorical" has no parameters, otherwise the iCustom call will return incorrect or always-the-same values.

New comment