CurrentTime() - OrderClosetime() problem

 
I'm having some problems getting my EA to wait a specific period of time between trades. I know I'm supposed to use the two variables listed above but i can't get it to work properly (especially in back tests). I know I'm not referencing previously closed orders correctly.

If anyone can help me insert the proper code i would greatly appreciate it.

Thank you in advance for any help.


#define SIGNAL_NONE 0
#define SIGNAL_BUY 1
#define SIGNAL_SELL 2
#define SIGNAL_CLOSEBUY 3
#define SIGNAL_CLOSESELL 4

extern int MagicNumber = 0;
extern bool SignalMail = False;
extern bool EachTickMode = True;
extern double Lots = 0.1;
extern int Slippage = 0;
extern bool UseStopLoss = True;
extern int StopLoss = 30;
extern bool UseTakeProfit = True;
extern int TakeProfit = 5;
extern bool UseTrailingStop = False;
extern int TrailingStop = 30;
extern string hd = " --Delay time--";
extern int useDelay = 1;
extern int useDelayAfterWin = 1;
extern int MinutesToDelay = 180;

int BarCount;
int Current;
bool TickCheck = False;

// expert initialization function

int init() {
BarCount = Bars;

if (EachTickMode) Current = 0; else Current = 1;

return(0);
}

// expert deinitialization function

int deinit() {
return(0);
}

// expert start function

int start() {
int Order = SIGNAL_NONE;
int Total, Ticket;
double StopLossLevel, TakeProfitLevel;



if (EachTickMode && Bars != BarCount) TickCheck = False;
Total = OrdersTotal();
Order = SIGNAL_NONE;

// Variable Begin

double Var1 = iBullsPower(NULL, 0, 13, PRICE_CLOSE, Current + 0);
double Var2 = iBullsPower(NULL, 0, 13, PRICE_CLOSE, Current + 1);
double Var3 = iBullsPower(NULL, 0, 13, PRICE_CLOSE, Current + 2);
double Var4 = iBearsPower(NULL, 0, 13, PRICE_CLOSE, Current + 0);
double Var5 = iBearsPower(NULL, 0, 13, PRICE_CLOSE, Current + 1);
double Var6 = iMACD(NULL, 0, 12, 20, 9, PRICE_CLOSE, MODE_MAIN, Current + 0);
double Var7 = iMACD(NULL, 0, 12, 20, 9, PRICE_CLOSE, MODE_MAIN, Current + 1);
double Var8 = iMACD(NULL, 0, 12, 20, 9, PRICE_CLOSE, MODE_MAIN, Current + 2);
double Var9 = iCCI(NULL, 0, 14, PRICE_CLOSE, Current + 0);
double Var10 = iCCI(NULL, 0, 14, PRICE_CLOSE, Current + 1);
double Var11 = iCCI(NULL, 0, 14, PRICE_CLOSE, Current + 2);
double Var12 = iCCI(NULL, 0, 14, PRICE_CLOSE, Current + 3);

double Buy1_1 = Var1 ;
double Buy1_2 = 0;
double Buy2_1 = Var1 ;
double Buy2_2 = Var2 ;
double Buy3_1 = Var2 ;
double Buy3_2 = -0.0003;
double Buy4_1 = Var3 ;
double Buy4_2 = -0.0008;
double Buy5_1 = Var4 ;
double Buy5_2 = 0;
double Buy6_1 = Var5 ;
double Buy6_2 = 0;
double Buy7_1 = Var6 ;
double Buy7_2 = Var7 ;
double Buy8_1 = Var7 ;
double Buy8_2 = Var8 ;
double Buy9_1 = Var9 ;
double Buy9_2 = 100;
double Buy10_1 = Var9 ;
double Buy10_2 = Var10 ;
double Buy11_1 = Var10 ;
double Buy11_2 = Var11 ;
double Buy12_1 = Var1 ;
double Buy12_2 = 0.006;
double Buy13_1 = Var2 ;
double Buy13_2 = Var3 ;
double Buy14_1 = Var4 ;
double Buy14_2 = Var5 ;
double Buy15_1 = Var2 ;
double Buy15_2 = 0.06;
double Buy16_1 = Var11;
double Buy16_2 = Var12;



double CloseBuy1_1 = Var3 ;
double CloseBuy1_2 = Var2 ;
double CloseBuy2_1 = Var2 ;
double CloseBuy2_2 = Var1 ;
double CloseBuy3_1 = 100;
double CloseBuy3_2 = Var9 ;




// Variable End


//Check position
bool IsTrade = False;

for (int i = 0; i < Total; i ++) {
OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
if(OrderType() <= OP_SELL && OrderSymbol() == Symbol()) {
IsTrade = True;
if(OrderType() == OP_BUY) {
//Close


// Signal Begin(Exit Buy)


if (CloseBuy1_1 > CloseBuy1_2 && CloseBuy2_1 > CloseBuy2_2 && CloseBuy3_1 > CloseBuy3_2) Order = SIGNAL_CLOSEBUY;


// Signal End(Exit Buy)

if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(UseTrailingStop && TrailingStop > 0) {
if(Bid - OrderOpenPrice() > Point * TrailingStop) {
if(OrderStopLoss() < Bid - Point * TrailingStop) {
OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
} else {
//Close


// Signal Begin(Exit Sell)



// Signal End(Exit Sell)


if (Order == SIGNAL_CLOSESELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Close Sell");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(UseTrailingStop && TrailingStop > 0) {
if((OrderOpenPrice() - Ask) > (Point * TrailingStop)) {
if((OrderStopLoss() > (Ask + Point * TrailingStop)) || (OrderStopLoss() == 0)) {
OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TrailingStop, OrderTakeProfit(), 0, DarkOrange);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
}
}
}


// Signal Begin(Entry)


if (Buy1_1 >= Buy1_2 && Buy2_1 > Buy2_2 && Buy3_1 > Buy3_2 && Buy4_1 >= Buy4_2 && Buy5_1 > Buy5_2 && Buy6_1 > Buy6_2 && Buy7_1 >= Buy7_2 && Buy8_1 >= Buy8_2 && Buy9_1 >= Buy9_2 && Buy10_1 >= Buy10_2 && Buy11_1 > Buy11_2 && Buy12_1 < Buy12_2 && Buy13_1 > Buy13_2 && Buy14_1 > Buy14_2 && Buy15_1 < Buy15_2 && Buy16_1 > Buy16_2) Order = SIGNAL_BUY;




// Signal End

//Buy
if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lots)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}

if (UseStopLoss) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0;

Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("BUY order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");
} else {
Print("Error opening BUY order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}

//Sell
if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lots)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}

if (UseStopLoss) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0;

Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("SELL order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Open Sell");
} else {
Print("Error opening SELL order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}

if (!EachTickMode) BarCount = Bars;

return(0);
}
 
jrwent wrote >>
I'm having some problems getting my EA to wait a specific period of time between trades. I know I'm supposed to use the two variables listed above but i can't get it to work properly (especially in back tests). I know I'm not referencing previously closed orders correctly.

If anyone can help me insert the proper code i would greatly appreciate it.

Thank you in advance for any help.


#define SIGNAL_NONE 0
#define SIGNAL_BUY 1
#define SIGNAL_SELL 2
#define SIGNAL_CLOSEBUY 3
#define SIGNAL_CLOSESELL 4

extern int MagicNumber = 0;
extern bool SignalMail = False;
extern bool EachTickMode = True;
extern double Lots = 0.1;
extern int Slippage = 0;
extern bool UseStopLoss = True;
extern int StopLoss = 30;
extern bool UseTakeProfit = True;
extern int TakeProfit = 5;
extern bool UseTrailingStop = False;
extern int TrailingStop = 30;
extern string hd = " --Delay time--";
extern int useDelay = 1;
extern int useDelayAfterWin = 1;
extern int MinutesToDelay = 180;

int BarCount;
int Current;
bool TickCheck = False;

// expert initialization function

int init() {
BarCount = Bars;

if (EachTickMode) Current = 0; else Current = 1;

return(0);
}

// expert deinitialization function

int deinit() {
return(0);
}

// expert start function

int start() {
int Order = SIGNAL_NONE;
int Total, Ticket;
double StopLossLevel, TakeProfitLevel;



if (EachTickMode && Bars != BarCount) TickCheck = False;
Total = OrdersTotal();
Order = SIGNAL_NONE;

// Variable Begin

double Var1 = iBullsPower(NULL, 0, 13, PRICE_CLOSE, Current + 0);
double Var2 = iBullsPower(NULL, 0, 13, PRICE_CLOSE, Current + 1);
double Var3 = iBullsPower(NULL, 0, 13, PRICE_CLOSE, Current + 2);
double Var4 = iBearsPower(NULL, 0, 13, PRICE_CLOSE, Current + 0);
double Var5 = iBearsPower(NULL, 0, 13, PRICE_CLOSE, Current + 1);
double Var6 = iMACD(NULL, 0, 12, 20, 9, PRICE_CLOSE, MODE_MAIN, Current + 0);
double Var7 = iMACD(NULL, 0, 12, 20, 9, PRICE_CLOSE, MODE_MAIN, Current + 1);
double Var8 = iMACD(NULL, 0, 12, 20, 9, PRICE_CLOSE, MODE_MAIN, Current + 2);
double Var9 = iCCI(NULL, 0, 14, PRICE_CLOSE, Current + 0);
double Var10 = iCCI(NULL, 0, 14, PRICE_CLOSE, Current + 1);
double Var11 = iCCI(NULL, 0, 14, PRICE_CLOSE, Current + 2);
double Var12 = iCCI(NULL, 0, 14, PRICE_CLOSE, Current + 3);

double Buy1_1 = Var1 ;
double Buy1_2 = 0;
double Buy2_1 = Var1 ;
double Buy2_2 = Var2 ;
double Buy3_1 = Var2 ;
double Buy3_2 = -0.0003;
double Buy4_1 = Var3 ;
double Buy4_2 = -0.0008;
double Buy5_1 = Var4 ;
double Buy5_2 = 0;
double Buy6_1 = Var5 ;
double Buy6_2 = 0;
double Buy7_1 = Var6 ;
double Buy7_2 = Var7 ;
double Buy8_1 = Var7 ;
double Buy8_2 = Var8 ;
double Buy9_1 = Var9 ;
double Buy9_2 = 100;
double Buy10_1 = Var9 ;
double Buy10_2 = Var10 ;
double Buy11_1 = Var10 ;
double Buy11_2 = Var11 ;
double Buy12_1 = Var1 ;
double Buy12_2 = 0.006;
double Buy13_1 = Var2 ;
double Buy13_2 = Var3 ;
double Buy14_1 = Var4 ;
double Buy14_2 = Var5 ;
double Buy15_1 = Var2 ;
double Buy15_2 = 0.06;
double Buy16_1 = Var11;
double Buy16_2 = Var12;



double CloseBuy1_1 = Var3 ;
double CloseBuy1_2 = Var2 ;
double CloseBuy2_1 = Var2 ;
double CloseBuy2_2 = Var1 ;
double CloseBuy3_1 = 100;
double CloseBuy3_2 = Var9 ;




// Variable End


//Check position
bool IsTrade = False;

for (int i = 0; i < Total; i ++) {
OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
if(OrderType() <= OP_SELL && OrderSymbol() == Symbol()) {
IsTrade = True;
if(OrderType() == OP_BUY) {
//Close


// Signal Begin(Exit Buy)


if (CloseBuy1_1 > CloseBuy1_2 && CloseBuy2_1 > CloseBuy2_2 && CloseBuy3_1 > CloseBuy3_2) Order = SIGNAL_CLOSEBUY;


// Signal End(Exit Buy)

if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(UseTrailingStop && TrailingStop > 0) {
if(Bid - OrderOpenPrice() > Point * TrailingStop) {
if(OrderStopLoss() < Bid - Point * TrailingStop) {
OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
} else {
//Close


// Signal Begin(Exit Sell)



// Signal End(Exit Sell)


if (Order == SIGNAL_CLOSESELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Close Sell");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(UseTrailingStop && TrailingStop > 0) {
if((OrderOpenPrice() - Ask) > (Point * TrailingStop)) {
if((OrderStopLoss() > (Ask + Point * TrailingStop)) || (OrderStopLoss() == 0)) {
OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TrailingStop, OrderTakeProfit(), 0, DarkOrange);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
}
}
}


// Signal Begin(Entry)


if (Buy1_1 >= Buy1_2 && Buy2_1 > Buy2_2 && Buy3_1 > Buy3_2 && Buy4_1 >= Buy4_2 && Buy5_1 > Buy5_2 && Buy6_1 > Buy6_2 && Buy7_1 >= Buy7_2 && Buy8_1 >= Buy8_2 && Buy9_1 >= Buy9_2 && Buy10_1 >= Buy10_2 && Buy11_1 > Buy11_2 && Buy12_1 < Buy12_2 && Buy13_1 > Buy13_2 && Buy14_1 > Buy14_2 && Buy15_1 < Buy15_2 && Buy16_1 > Buy16_2) Order = SIGNAL_BUY;




// Signal End

//Buy
if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lots)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}

if (UseStopLoss) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0;

Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("BUY order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");
} else {
Print("Error opening BUY order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}

//Sell
if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lots)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}

if (UseStopLoss) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0;

Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("SELL order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Open Sell");
} else {
Print("Error opening SELL order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}

if (!EachTickMode) BarCount = Bars;

return(0);
}

I had simular problem try to impliment this in your code put the Mater_trading variable to stop your buy or sellling

if (OrdersHistoryTotal()>0)
{
OrderSelect(OrdersHistoryTotal()-1, SELECT_BY_POS, MODE_HISTORY);
if (OrderCloseTime()+Open_Delay_Time > TimeCurrent())
{
Master_Trading = false;
// Print("Master trading = false !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!");
return(0);
}
}
Master_Trading = true;