EA Executing Order when X Amout > 0.50

New comment
 

Hi MQL community,

My EA from time to time executes a trade when my division1 value is greater than 0.50. Is there an obvious error in my code?

FYI, I run about 30 EAs in different pairs with similar code, however, they each use a different magic number. Also, I'm getting no error messages in the journal.

Thanks in advance!

Cheers, Tim 

void CheckForATOMUSDTTrade1()
{

int buyticket=0,sellticket=0; 
static datetime TimeSent;

     double HighRangeyesterday = High[iHighest(NULL,PERIOD_H1,MODE_HIGH,36,1)];
       
     double LowRangeyesterday = Low[iLowest(NULL,PERIOD_H1,MODE_LOW,36,1)];
   
     double Rangeyesterday = (HighRangeyesterday-LowRangeyesterday);
   
     double AbsoluteRange = MathAbs(Rangeyesterday);
       
     double ATRT = iATR(NULL,PERIOD_D1,14,1);
       
     double RangeVol = MathAbs(AbsoluteRange / ATRT);
     
   ////////////////////////////////////////////////////////
   
      int HighestNEARUSDT =  iHighest("NEARUSDT",PERIOD_H1,MODE_HIGH,36,1);
      double NEARUSDTHighRange = iHigh("NEARUSDT",PERIOD_H1,HighestNEARUSDT);
      int LowestNEARUSDT =  iLowest("NEARUSDT",PERIOD_H1,MODE_LOW,36,1);
      double NEARUSDTLowRange = iLow("NEARUSDT",PERIOD_H1,LowestNEARUSDT);
   
     double RangeyesterdayNEAR = (NEARUSDTHighRange-NEARUSDTLowRange);
   
     double AbsoluteRangeNEAR = MathAbs(RangeyesterdayNEAR);
       
     double ATRTNEAR = iATR("NEARUSDT",PERIOD_D1,14,1);
       
     double RangeVolNEAR = MathAbs(AbsoluteRangeNEAR / ATRTNEAR);
     
     double nearopen1 = iOpen("NEARUSDT",PERIOD_D1,1);
     double nearclose1 = iClose("NEARUSDT",PERIOD_D1,1);
     
     double ATOMRSI = iRSI(NULL,PERIOD_H1,14,0,1);
     double NEARRSI = iRSI("NEARUSDT",PERIOD_H1,14,0,1);
   
      double LotSize1=0;
      double Equity= 100.00;
      LotSize1=(Equity/Close[1]);
      double LotSize= NormalizeDouble(LotSize1,1);
      
      ////////////
      double division1 = (RangeVol / RangeVolNEAR);
      double division2 = (RangeVolNEAR / RangeVol);
      
      if(RangeVol<RangeVolNEAR)
      if(ATOMRSI<NEARRSI)
      if(division1 < 0.50)
 

  1. Why did you post your MT4 question in the MT5 EA section instead of the MQL4 section, (bottom of the Root page)?
              General rules and best pratices of the Forum. - General - MQL5 programming forum? (2017)
    Next time, post in the correct place. The moderators will likely move this thread there soon.

  2. Timothy Smith: My EA from time to time executes a trade when my division1 value is greater than 0.50. Is there an obvious error in my code?

    Your posted code has no trading code. Always post all relevant code (using Code button) or attach the source file.
         How To Ask Questions The Smart Way. (2004)
              Be precise and informative about your problem

  3.       LotSize1=(Equity/Close[1]);
      double LotSize= NormalizeDouble(LotSize1,1);

    Risk depends on your initial stop loss, lot size, and the value of the symbol. It does not depend on margin and leverage. No SL means you have infinite risk (on leveraged symbols). Never risk more than a small percentage of your trading funds, certainly less than 2% per trade, 6% total.

    1. You place the stop where it needs to be — where the reason for the trade is no longer valid. E.g. trading a support bounce, the stop goes below the support.

    2. AccountBalance * percent/100 = RISK = OrderLots * (|OrderOpenPrice - OrderStopLoss| * DeltaPerLot + CommissionPerLot) (Note OOP-OSL includes the spread, and DeltaPerLot is usually around $10/PIP, but it takes account of the exchange rates of the pair vs. your account currency.)

    3. Do NOT use TickValue by itself - DeltaPerLot and verify that MODE_TICKVALUE is returning a value in your deposit currency, as promised by the documentation, or whether it is returning a value in the instrument's base currency.
                MODE_TICKVALUE is not reliable on non-fx instruments with many brokers - MQL4 programming forum (2017)
                Is there an universal solution for Tick value? - Currency Pairs - General - MQL5 programming forum (2018)
                Lot value calculation off by a factor of 100 - MQL5 programming forum (2019)

    4. You must normalize lots properly and check against min and max.

    5. You must also check Free Margin to avoid stop out

    6. For MT5, see 'Money Fixed Risk' - MQL5 Code Base (2017)

    Most pairs are worth about $10 per PIP. A $5 risk with a (very small) 5 PIP SL is $5/$10/5 or 0.1 Lots maximum.

 
William Roeder #:

  1. Why did you post your MT4 question in the MT5 EA section instead of the MQL4 section, (bottom of the Root page)?
              General rules and best pratices of the Forum. - General - MQL5 programming forum? (2017)
    Next time, post in the correct place. The moderators will likely move this thread there soon.

  2. Your posted code has no trading code. Always post all relevant code (using Code button) or attach the source file.
         How To Ask Questions The Smart Way. (2004)
              Be precise and informative about your problem

  3. Risk depends on your initial stop loss, lot size, and the value of the symbol. It does not depend on margin and leverage. No SL means you have infinite risk (on leveraged symbols). Never risk more than a small percentage of your trading funds, certainly less than 2% per trade, 6% total.

    1. You place the stop where it needs to be — where the reason for the trade is no longer valid. E.g. trading a support bounce, the stop goes below the support.

    2. AccountBalance * percent/100 = RISK = OrderLots * (|OrderOpenPrice - OrderStopLoss| * DeltaPerLot + CommissionPerLot) (Note OOP-OSL includes the spread, and DeltaPerLot is usually around $10/PIP, but it takes account of the exchange rates of the pair vs. your account currency.)

    3. Do NOT use TickValue by itself - DeltaPerLot and verify that MODE_TICKVALUE is returning a value in your deposit currency, as promised by the documentation, or whether it is returning a value in the instrument's base currency.
                MODE_TICKVALUE is not reliable on non-fx instruments with many brokers - MQL4 programming forum (2017)
                Is there an universal solution for Tick value? - Currency Pairs - General - MQL5 programming forum (2018)
                Lot value calculation off by a factor of 100 - MQL5 programming forum (2019)

    4. You must normalize lots properly and check against min and max.

    5. You must also check Free Margin to avoid stop out

    6. For MT5, see 'Money Fixed Risk' - MQL5 Code Base (2017)

    Most pairs are worth about $10 per PIP. A $5 risk with a (very small) 5 PIP SL is $5/$10/5 or 0.1 Lots maximum.

I run a long/short strategy with many corresponding buy and sell orders open at the same time.

I have a separate risk management ea that closes all trades if the account profit falls x percentage of total dollar amount value of all open trades.
New comment