OrderClose function MQL5

[David Diez]

Hi,I have this orderclose function working in MQ4 but as the tester results doesnt show any closed position must be a translation mistake, if someone can check this issue I thank you in advance.

void OrdersCloseLong(){
   for(int i=0;i<OrdersTotal();i++){
      if(PositionSelectByTicket(i)){
         if(PositionGetInteger(POSITION_TYPE)==POSITION_TYPE_BUY&&
            OrderGetString(ORDER_SYMBOL)==Symbol()&&OrderGetInteger(ORDER_MAGIC)==MagicNumber){
            if(!trade.PositionClose(Symbol(),ULONG_MAX)){ // Tried also with PositionGetTicket(i)
               Print("OrderClose error ",GetLastError());
               return;
               }
            else{i--;}
            }
         }
      }
   }

[Konstantin Nikitin]

void OrdersCloseLong(){
   for(int i=0;i<PositionsTotal();i++){
      if(PositionGetTicket(i)>0){
         if(PositionGetInteger(POSITION_TYPE)==POSITION_TYPE_BUY&&
            PositionGetString(POSITION_SYMBOL)==_Symbol&&PositionGetInteger(POSITION_MAGIC)==MagicNumber){
            if(!trade.PositionClose(_Symbol,ULONG_MAX)){
               Print("OrderClose error ",GetLastError());
               return;
               }
            else{i--;}
            }
         }
      }
   }

Order - pending orders.
Position - trading positions
In MQL5 it matters.

[David Diez]

Konstantin Nikitin:

Order - pending orders.
Position - trading positions
In MQL5 it matters.

Ok, seems the code is good, but for some reason expert isn't still closing orders.