Calling indicators in EA (MQ5)

[Rogerio Caeiro]

I am using the following code to retrieve RSI and EMA in an Expert. Can someone check if it is well writen? It is my first EA in MQL5.

Thanks for the help in advance :)

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *

*

*  iRSI Indicator Calculations

**/

double iRSIGet(string TestSymbol)

  {

  

   int handle_iRSI=iRSI(TestSymbol,PERIOD_H4,RSI_Period,PRICE_CLOSE);

   double RSI[1];

   

   CopyBuffer(handle_iRSI,0,0,1,RSI);

    

   return(RSI[0]);

  }

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *

*

*  iEMA Long Indicator Calculations

*

*/

double iMALongGet(string TestSymbol)

  {

  

   int handle_iMA=iMA(TestSymbol,PERIOD_H4,EMA_Long,0,MODE_EMA,PRICE_CLOSE);

   double MA[1];

   

   CopyBuffer(handle_iMA,0,0,1,MA);

    

   return(MA[0]);

  }

  

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *

*

*  iEMA Short Indicator Calculations

*

*/

double iMAShortGet(string TestSymbol)

  {

  

   int handle_iMA=iMA(TestSymbol,PERIOD_H4,EMA_Short,0,MODE_EMA,PRICE_CLOSE);

   double MA[1];

   

   CopyBuffer(handle_iMA,0,1,1,MA);

    

   return(MA[0]);

  }