Coding help - page 143
You are missing trading opportunities:
- Free trading apps
- Over 8,000 signals for copying
- Economic news for exploring financial markets
Registration
Log in
You agree to website policy and terms of use
If you do not have an account, please register
Hey mladen, one more question:
How can I check all open orders, if their profit is lower than -20 and close them then?
Something like this?
//int currentTicket;
for(int i0=OrdersTotal()-1; i0>=0; i0--) {
//currentTicket = OrderSelect(i0, SELECT_BY_POS, MODE_TRADES);
if(OrderProfit() <= -20) {
OrderClose(OrderTicket(),OrderLots(),0,0, CLR_NONE);
}
}arroganzmaschine
Yes, that should do it.
You might change just the line where you check the profit to this :
if ((OrderProfit()+OrderSwap()+OrderCommission()) <= -20)
to make sure that it is a "pure" profit that you are checking
Do I have to set a Bid or Ask at OrderClose? Or is the line correct?
Hm, there is something wrong. The backtest doesn't close the orders who are in minus profit. At the end of test there are open orders with -230 profit.
int start()
{
for(int i0=OrdersTotal()-1; i0>=0; i0--) {
if((OrderProfit()+OrderSwap()+OrderCommission()) <= -20) {
OrderClose(OrderTicket(),OrderLots(),0,0, CLR_NONE);
}
}
}
This doesn't work.
int start()
{
for(int i0=OrdersTotal()-1; i0>=0; i0--) {
if((OrderProfit()+OrderSwap()+OrderCommission()) <= -20) {
OrderClose(OrderTicket(),OrderLots(),0,0, CLR_NONE);
}
}
}
This doesn't work.You forgot the OrderSelect() (you always have to select the order before you do anything with it). Also it would be a good idea to add the part that checks what type of order you are trying to close
Something like this :
if (OrderSelect(u0,SELECT_BY_POS,MODE_TRADES))
if((OrderProfit()+OrderSwap()+OrderCommission()) <= -20)
{
if (OrderType()==OP_BUY) OrderClose(OrderTicket(),OrderLots(),Bid,0,CLR_NONE);
if (OrderType()==OP_SELL) OrderClose(OrderTicket(),OrderLots(),Ask,0,CLR_NONE);
}
could somebody help me with converting histogram into bars in the TrendHistogram indicator? I would like to get the same bars as those in the attached TrendFilter indicator
TrendHistogram needs EMA_Adaptive indicator to work correctly
could somebody help me with converting histogram into bars in the TrendHistogram indicator? I would like to get the same bars as those in the attached TrendFilter indicator
freakout
Here you go
Set the DrawAsBars to true and it will draw the way you described. If you leave that parameter to be false it will work as the original
Hi,
Can anyone help me to edit this code back-testing is good but EA not work on Demo / Real Account.
//+------------------------------------------------------------------+
//| Hans123Trader v1 |
//+------------------------------------------------------------------+
#include
#property copyright "hans123"
#property link ""
// programmed by fukinagashi
extern int BeginSession1=6;(during backtest i edit and set 0 for all sessions thus got ultimate results)
extern int EndSession1=10;
extern int BeginSession2=10;
extern int EndSession2=14;
extern double TrailingStop = 0;
extern double TakeProfit = 452;
extern double InitialStopLoss=40;
double Lots = 0.1;
datetime bartime = 0;
double Slippage=3;
//+------------------------------------------------------------------+
//| |
//+------------------------------------------------------------------+
int start()
{
int cnt, ticket, err, i, j, cmd;
int MagicNumber;
double ts, tp, LowestPrice, HighestPrice, Price;
bool Order[5];
string setup;
datetime Validity=0;
if(IsTesting() && Bars<100) return(0);
MagicNumber = 50000 + func_Symbol2Val(Symbol())*100;
setup="H123_" + Symbol();
if (bartime == Time[0]) {
return(0);
} else {
bartime = Time[0];
}
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
///////////////// MODIFICATIONS ON OPEN ORDERS ////////////////////////////////////////////////////////////////////
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
for(cnt=OrdersTotal();cnt>=0;cnt--)
{
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
if(OrderType()==OP_BUY && (OrderMagicNumber()==MagicNumber+1 || OrderMagicNumber()==MagicNumber+3)) {
if(TimeDay(OrderOpenTime())!=TimeDay(Time[0])) {
Print(".");
OrderClose(OrderTicket(), Lots, Bid, 3, Red);
if (err>1) { Print("Error closing buy order [" + setup + "]: (" + err + ") " + ErrorDescription(err)); }
} else if (OrderStopLoss()==0) {
if (TakeProfit>0) { tp=OrderOpenPrice()+TakeProfit*Point;
} else { tp=0; }
if (InitialStopLoss>0) { ts=OrderOpenPrice()-InitialStopLoss*Point;
} else { ts=0; }
OrderModify(OrderTicket(),OrderOpenPrice(),ts,tp,0,White);
if (err>1) { Print("Error modifying Buy order [" + setup + "]: (" + err + ") " + ErrorDescription(err)); }
} else if (TrailingStop>0) {ts = Bid-Point*TrailingStop;
if (OrderStopLoss()0) OrderModify(OrderTicket(),OrderOpenPrice(),ts,OrderTakeProfit(),0,White);
}
} else if(OrderType()==OP_SELL && (OrderMagicNumber()==MagicNumber+2 || OrderMagicNumber()==MagicNumber+4)) {
if(TimeDay(OrderOpenTime())!=TimeDay(Time[0])) {
Print(".");
OrderClose(OrderTicket(), Lots, Ask, 3, Red);
if (err>1) { Print("Error closing Sell order [" + setup + "]: (" + err + ") " + ErrorDescription(err)); }
} else if (OrderStopLoss()==0) {
if (TakeProfit>0) { tp=OrderOpenPrice()-TakeProfit*Point;
} else { tp=0; }
if (InitialStopLoss>0) { ts=OrderOpenPrice()+InitialStopLoss*Point;
} else { ts=0; }
OrderModify(OrderTicket(),OrderOpenPrice(),ts,tp,0,White);
if (err>1) { Print("Error modifying Sell order [" + setup + "]: (" + err + ") " + ErrorDescription(err)); }
} else if (TrailingStop>0) {ts = Ask+Point*TrailingStop;
if (OrderStopLoss()>ts && OrderProfit()>0) OrderModify(OrderTicket(),OrderOpenPrice(),ts,OrderTakeProfit(),0,White);
}
}
}
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
///////////////// SETTING ORDERS ////////////////////////////////////////////////////////////////////
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
if(AccountFreeMargin()<(1000*Lots)) return(0);
Validity=StrToTime(TimeYear(Time[0]) + "." + TimeMonth(Time[0]) + "." + TimeDay(Time[0]) + " 23:59");
if (TimeHour(Time[0])==EndSession1 && TimeMinute(Time[0])==0) {
LowestPrice=Low[Lowest(NULL, PERIOD_M5, MODE_LOW, 80, 0)];
HighestPrice=High;
//// the following is necessary, to avoid a BUYSTOP/SELLSTOP Price which is too close to Bid/Ask,
//// in which case we get a 130 invalid stops.
//// I experimented to change to proper OP_BUY and OP_SELL, but the results where not satisfying
//if (HighestPrice+5*Point<Ask+Spread*Point) {
// cmd=OP_BUY;
// Price=Ask;
//} else {
cmd=OP_BUYSTOP;
Price=HighestPrice+5*Point;
//}
ticket=OrderSendExtended(Symbol(),cmd,Lots,Price,Slippage,0,0,setup,MagicNumber+1,Validity,Green);
err = GetLastError();
if (err>1) { Print("Error modifying Sell order [" + setup + "]: (" + err + ") " + ErrorDescription(err)); }
//if (LowestPrice-5*Point>Bid-Spread*Point) {
// cmd=OP_SELL;
// Price=Bid;
//} else {
cmd=OP_SELLSTOP;
Price=LowestPrice-5*Point;
//}
ticket=OrderSendExtended(Symbol(),OP_SELLSTOP,Lots,Price,Slippage,0,0,setup,MagicNumber+2,Validity,Green);
err = GetLastError();
if (err>1) { Print("Error modifying Sell order [" + setup + "]: (" + err + ") " + ErrorDescription(err)); }
}
if (TimeHour(Time[0])==EndSession2 && TimeMinute(Time[0])==0) {
LowestPrice=Low[Lowest(NULL, PERIOD_M5, MODE_LOW, 80, 0)];
HighestPrice=High;
//if (HighestPrice+5*Point<Ask+Spread*Point) {
// cmd=OP_BUY;
// Price=Ask;
//} else {
cmd=OP_BUYSTOP;
Price=HighestPrice+5*Point;
//}
ticket=OrderSendExtended(Symbol(),cmd,Lots,Price,Slippage,0,0,setup,MagicNumber+3,Validity,Green);
err = GetLastError();
if (err>1) { Print("Error modifying Sell order [" + setup + "]: (" + err + ") " + ErrorDescription(err)); }
//if (LowestPrice-5*Point>Bid-Spread*Point) {
// cmd=OP_SELL;
// Price=Bid;
//} else {
cmd=OP_SELLSTOP;
Price=LowestPrice-5*Point;
//}
ticket=OrderSendExtended(Symbol(),cmd,Lots,Price,Slippage,0,0,setup,MagicNumber+4,Validity,Green);
err = GetLastError();
if (err>1) { Print("Error modifying Sell order [" + setup + "]: (" + err + ") " + ErrorDescription(err)); }
}
}
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
///////////////// DIVERSE SUBROUTINES /////////////////////////////////////////////////////////////////////////////
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
int func_Symbol2Val(string symbol) {
if(symbol=="AUDUSD") { return(01);
} else if(symbol=="CHFJPY") { return(10);
} else if(symbol=="EURAUD") { return(10);
} else if(symbol=="EURCAD") { return(11);
} else if(symbol=="EURCHF") { return(12);
} else if(symbol=="EURGBP") { return(13);
} else if(symbol=="EURJPY") { return(14);
} else if(symbol=="EURUSDm") { return(15);
} else if(symbol=="GBPCHF") { return(20);
} else if(symbol=="GBPJPY") { return(21);
} else if(symbol=="GBPUSD") { return(22);
} else if(symbol=="USDCAD") { return(40);
} else if(symbol=="USDCHF") { return(41);
} else if(symbol=="USDJPY") { return(42);
} else if(symbol=="GOLD") { return(90);
} else { Comment("unexpected Symbol"); return(0);
}
}
int OrderSendExtended(string symbol, int cmd, double volume, double price, int slippage, double stoploss, double takeprofit, string comment, int magic, datetime expiration=0, color arrow_color=CLR_NONE) {
datetime OldCurTime;
int timeout=30;
int ticket;
OldCurTime=CurTime();
while (GlobalVariableCheck("InTrade") && !IsTradeAllowed()) {
if(OldCurTime+timeout<=CurTime()) {
Print("Error in OrderSendExtended(): Timeout encountered");
return(0);
}
Sleep(1000);
}
GlobalVariableSet("InTrade", CurTime()); // set lock indicator
ticket = OrderSend(symbol, cmd, volume, price, slippage, stoploss, takeprofit, comment, magic, expiration, arrow_color);
GlobalVariableDel("InTrade"); // clear lock indicator
return(ticket);
}
Hi,
Can anyone help me to edit this code back-testing is good but EA not work on Demo / Real Account.
//+------------------------------------------------------------------+
//| Hans123Trader v1 |
//+------------------------------------------------------------------+
#include
#property copyright "hans123"
#property link ""
// programmed by fukinagashi
extern int BeginSession1=6;(during backtest i edit and set 0 for all sessions thus got ultimate results)
extern int EndSession1=10;
extern int BeginSession2=10;
extern int EndSession2=14;
extern double TrailingStop = 0;
extern double TakeProfit = 452;
extern double InitialStopLoss=40;
double Lots = 0.1;
datetime bartime = 0;
double Slippage=3;
//+------------------------------------------------------------------+
//| |
//+------------------------------------------------------------------+
int start()
{
int cnt, ticket, err, i, j, cmd;
int MagicNumber;
double ts, tp, LowestPrice, HighestPrice, Price;
bool Order[5];
string setup;
datetime Validity=0;
if(IsTesting() && Bars<100) return(0);
MagicNumber = 50000 + func_Symbol2Val(Symbol())*100;
setup="H123_" + Symbol();
if (bartime == Time[0]) {
return(0);
} else {
bartime = Time[0];
}
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
///////////////// MODIFICATIONS ON OPEN ORDERS ////////////////////////////////////////////////////////////////////
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
for(cnt=OrdersTotal();cnt>=0;cnt--)
{
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
if(OrderType()==OP_BUY && (OrderMagicNumber()==MagicNumber+1 || OrderMagicNumber()==MagicNumber+3)) {
if(TimeDay(OrderOpenTime())!=TimeDay(Time[0])) {
Print(".");
OrderClose(OrderTicket(), Lots, Bid, 3, Red);
if (err>1) { Print("Error closing buy order [" + setup + "]: (" + err + ") " + ErrorDescription(err)); }
} else if (OrderStopLoss()==0) {
if (TakeProfit>0) { tp=OrderOpenPrice()+TakeProfit*Point;
} else { tp=0; }
if (InitialStopLoss>0) { ts=OrderOpenPrice()-InitialStopLoss*Point;
} else { ts=0; }
OrderModify(OrderTicket(),OrderOpenPrice(),ts,tp,0,White);
if (err>1) { Print("Error modifying Buy order [" + setup + "]: (" + err + ") " + ErrorDescription(err)); }
} else if (TrailingStop>0) {ts = Bid-Point*TrailingStop;
if (OrderStopLoss()0) OrderModify(OrderTicket(),OrderOpenPrice(),ts,OrderTakeProfit(),0,White);
}
} else if(OrderType()==OP_SELL && (OrderMagicNumber()==MagicNumber+2 || OrderMagicNumber()==MagicNumber+4)) {
if(TimeDay(OrderOpenTime())!=TimeDay(Time[0])) {
Print(".");
OrderClose(OrderTicket(), Lots, Ask, 3, Red);
if (err>1) { Print("Error closing Sell order [" + setup + "]: (" + err + ") " + ErrorDescription(err)); }
} else if (OrderStopLoss()==0) {
if (TakeProfit>0) { tp=OrderOpenPrice()-TakeProfit*Point;
} else { tp=0; }
if (InitialStopLoss>0) { ts=OrderOpenPrice()+InitialStopLoss*Point;
} else { ts=0; }
OrderModify(OrderTicket(),OrderOpenPrice(),ts,tp,0,White);
if (err>1) { Print("Error modifying Sell order [" + setup + "]: (" + err + ") " + ErrorDescription(err)); }
} else if (TrailingStop>0) {ts = Ask+Point*TrailingStop;
if (OrderStopLoss()>ts && OrderProfit()>0) OrderModify(OrderTicket(),OrderOpenPrice(),ts,OrderTakeProfit(),0,White);
}
}
}
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
///////////////// SETTING ORDERS ////////////////////////////////////////////////////////////////////
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
if(AccountFreeMargin()<(1000*Lots)) return(0);
Validity=StrToTime(TimeYear(Time[0]) + "." + TimeMonth(Time[0]) + "." + TimeDay(Time[0]) + " 23:59");
if (TimeHour(Time[0])==EndSession1 && TimeMinute(Time[0])==0) {
LowestPrice=Low[Lowest(NULL, PERIOD_M5, MODE_LOW, 80, 0)];
HighestPrice=High;
//// the following is necessary, to avoid a BUYSTOP/SELLSTOP Price which is too close to Bid/Ask,
//// in which case we get a 130 invalid stops.
//// I experimented to change to proper OP_BUY and OP_SELL, but the results where not satisfying
//if (HighestPrice+5*Point<Ask+Spread*Point) {
// cmd=OP_BUY;
// Price=Ask;
//} else {
cmd=OP_BUYSTOP;
Price=HighestPrice+5*Point;
//}
ticket=OrderSendExtended(Symbol(),cmd,Lots,Price,Slippage,0,0,setup,MagicNumber+1,Validity,Green);
err = GetLastError();
if (err>1) { Print("Error modifying Sell order [" + setup + "]: (" + err + ") " + ErrorDescription(err)); }
//if (LowestPrice-5*Point>Bid-Spread*Point) {
// cmd=OP_SELL;
// Price=Bid;
//} else {
cmd=OP_SELLSTOP;
Price=LowestPrice-5*Point;
//}
ticket=OrderSendExtended(Symbol(),OP_SELLSTOP,Lots,Price,Slippage,0,0,setup,MagicNumber+2,Validity,Green);
err = GetLastError();
if (err>1) { Print("Error modifying Sell order [" + setup + "]: (" + err + ") " + ErrorDescription(err)); }
}
if (TimeHour(Time[0])==EndSession2 && TimeMinute(Time[0])==0) {
LowestPrice=Low[Lowest(NULL, PERIOD_M5, MODE_LOW, 80, 0)];
HighestPrice=High;
//if (HighestPrice+5*Point<Ask+Spread*Point) {
// cmd=OP_BUY;
// Price=Ask;
//} else {
cmd=OP_BUYSTOP;
Price=HighestPrice+5*Point;
//}
ticket=OrderSendExtended(Symbol(),cmd,Lots,Price,Slippage,0,0,setup,MagicNumber+3,Validity,Green);
err = GetLastError();
if (err>1) { Print("Error modifying Sell order [" + setup + "]: (" + err + ") " + ErrorDescription(err)); }
//if (LowestPrice-5*Point>Bid-Spread*Point) {
// cmd=OP_SELL;
// Price=Bid;
//} else {
cmd=OP_SELLSTOP;
Price=LowestPrice-5*Point;
//}
ticket=OrderSendExtended(Symbol(),cmd,Lots,Price,Slippage,0,0,setup,MagicNumber+4,Validity,Green);
err = GetLastError();
if (err>1) { Print("Error modifying Sell order [" + setup + "]: (" + err + ") " + ErrorDescription(err)); }
}
}
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
///////////////// DIVERSE SUBROUTINES /////////////////////////////////////////////////////////////////////////////
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
int func_Symbol2Val(string symbol) {
if(symbol=="AUDUSD") { return(01);
} else if(symbol=="CHFJPY") { return(10);
} else if(symbol=="EURAUD") { return(10);
} else if(symbol=="EURCAD") { return(11);
} else if(symbol=="EURCHF") { return(12);
} else if(symbol=="EURGBP") { return(13);
} else if(symbol=="EURJPY") { return(14);
} else if(symbol=="EURUSDm") { return(15);
} else if(symbol=="GBPCHF") { return(20);
} else if(symbol=="GBPJPY") { return(21);
} else if(symbol=="GBPUSD") { return(22);
} else if(symbol=="USDCAD") { return(40);
} else if(symbol=="USDCHF") { return(41);
} else if(symbol=="USDJPY") { return(42);
} else if(symbol=="GOLD") { return(90);
} else { Comment("unexpected Symbol"); return(0);
}
}
int OrderSendExtended(string symbol, int cmd, double volume, double price, int slippage, double stoploss, double takeprofit, string comment, int magic, datetime expiration=0, color arrow_color=CLR_NONE) {
datetime OldCurTime;
int timeout=30;
int ticket;
OldCurTime=CurTime();
while (GlobalVariableCheck("InTrade") && !IsTradeAllowed()) {
if(OldCurTime+timeout<=CurTime()) {
Print("Error in OrderSendExtended(): Timeout encountered");
return(0);
}
Sleep(1000);
}
GlobalVariableSet("InTrade", CurTime()); // set lock indicator
ticket = OrderSend(symbol, cmd, volume, price, slippage, stoploss, takeprofit, comment, magic, expiration, arrow_color);
GlobalVariableDel("InTrade"); // clear lock indicator
return(ticket);
}Try multiplying the InitialStopLoss with 10 on a live account. That EA is written for 4 digit brokers
______________________
PS : you should also multiply the TakeProfit with 10 to be consistent and to have that as pips, but if you tested it with those numbers, you will not get the same results as when back testing (simply because back test allowed you to use values for those two that neither demo account nor live account will allow you)
zigflip Last two psar as in "last upper/lower pair of psar" or "last 2 bars"?
sorry for late reply mladen, i thought i had email subscription on but...
I mean the last pair of psars!
I mainly want to monitor the last psar but when upper/lower change occurs would need the last two levels, hmm maybe should be x bars back… agh i see what your saying now, on seconds thoughts perhaps the last set of uppers/lowers, that trims to last changeover on the arrival of the first new direction psar!
Thanks for your help on this,