How to code? - page 207

 

Reduce Open Position

Does anyone know how to close / reduce half a position. What function do we call ?

Example: Reduce an open position from 10 Lots to 5 Lots without opening another trade in the opposite direction ?

 

Is called 'partial close';

bool OrderClose( int ticket, double lots, double price, int slippage, color Color=CLR_NONE)

Just specify how many lots to close.

 
ljuba973:
Hi,

Try this way

for (int i=OrdersTotal()-1;i>=0 i--) {

if (OrderSelect(i, SELECT_BY_POS)) {

if (OrderSymbol()==Symbol()&&OrderType()==0) {

Ans=OrderClose(OrderTicket(),alLots,Bid,2);// Order closing

}

if (OrderSymbol()==Symbol()&&OrderType()==1) {

Ans=OrderClose(OrderTicket(),alLots,Ask,2);// Order closing

}

}

 
username1:
Does anyone know how to close / reduce half a position. What function do we call ? Example: Reduce an open position from 10 Lots to 5 Lots without opening another trade in the opposite direction ?

Just close order for 5 lots, like this:

OrderClose(OrderTicket(),5.0,.......

 

Hi Roger,

Thanks a lot for help. In meantime I managed to fix it to work:

OrderSend(Symbol(),OP_BUY,alLots,Ask,3,0,0,EA_Tester,Magic);

if(OrderSelect(OrdersTotal()-1, SELECT_BY_POS)==true) {

alTicker = OrderTicket();

Alert("Bought! ", alTicker);

} else Print("OrderSelect failed error code is ",GetLastError());

[/CODE]

Like that I found alTicker (after opening position) which I close later on.

But your code I will use to optimize my Closing function. Sorry for maybe "beginner's code", I am into mq4 just 2 days ... will improve - I promise

Thanks again

Roger09:
Try this way

[CODE]

for (int i=OrdersTotal()-1;i>=0 i--) {

if (OrderSelect(i, SELECT_BY_POS)) {

if (OrderSymbol()==Symbol()&&OrderType()==0) {

Ans=OrderClose(OrderTicket(),alLots,Bid,2);// Order closing

}

if (OrderSymbol()==Symbol()&&OrderType()==1) {

Ans=OrderClose(OrderTicket(),alLots,Ask,2);// Order closing

}

}

 

How I can place a fixed StopLoss ?

Hi,

Could someone please let me know how I can place a fixed StopLoss in ths code?

//+------------------------------------------------------------------+

//| Daydream by Cothool |

//| Recommended: USD/JPY 1H |

//+------------------------------------------------------------------+

#define MAGIC_NUM 48213657

//+------------------------------------------------------------------+

extern double Lots = 0.1;

extern int ChannelPeriod = 25;

extern int Slippage = 3;

extern int TakeProfit = 15;

//+------------------------------------------------------------------+

double LastOrderTime = 0;

double CurrentDirection = 0;

double CurrentTakeProfitPrice = 0;

//+------------------------------------------------------------------+

void OpenLong()

{

if (Time[0] == LastOrderTime)

return;

if (CurrentDirection != 0)

return;

OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, 0, 0,

"Daydream", MAGIC_NUM, 0, Blue);

LastOrderTime = Time[0];

CurrentDirection = 1;

}

//+------------------------------------------------------------------+

void OpenShort()

{

if (Time[0] == LastOrderTime)

return;

if (CurrentDirection != 0)

return;

OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, 0, 0,

"Daydream", MAGIC_NUM, 0, Red);

LastOrderTime = Time[0];

CurrentDirection = -1;

}

//+------------------------------------------------------------------+

void CloseLong()

{

int i;

if (Time[0] == LastOrderTime)

return;

if (CurrentDirection != 1)

return;

for (i = 0; i < OrdersTotal(); i++)

{

if (OrderSelect(i, SELECT_BY_POS) && OrderSymbol() == Symbol() &&

OrderMagicNumber() == MAGIC_NUM && OrderType() == OP_BUY)

{

OrderClose(OrderTicket(), OrderLots(), Bid, 3, White);

LastOrderTime = Time[0];

CurrentDirection = 0;

}

}

}

//+------------------------------------------------------------------+

void CloseShort()

{

int i;

if (Time[0] == LastOrderTime)

return;

if (CurrentDirection != -1)

return;

for (i = 0; i < OrdersTotal(); i++)

{

if (OrderSelect(i, SELECT_BY_POS) && OrderSymbol() == Symbol() &&

OrderMagicNumber() == MAGIC_NUM && OrderType() == OP_SELL)

{

OrderClose(OrderTicket(), OrderLots(), Ask, 3, White);

LastOrderTime = Time[0];

CurrentDirection = 0;

}

}

}

//+------------------------------------------------------------------+

void start()

{

double HighestValue;

double LowestValue;

HighestValue = High;

LowestValue = Low[Lowest(NULL, 0, MODE_LOW, ChannelPeriod, 1)];

// BUY

if (Close[0] < LowestValue)

{

CloseShort();

OpenLong();

CurrentTakeProfitPrice = Bid + TakeProfit * Point;

}

// SELL

if (Close[0] > HighestValue)

{

CloseLong();

OpenShort();

CurrentTakeProfitPrice = Ask - TakeProfit * Point;

}

// Trailing Profit Taking for Long Position

if (CurrentDirection == 1)

{

if (CurrentTakeProfitPrice > Bid + TakeProfit * Point)

CurrentTakeProfitPrice = Bid + TakeProfit * Point;

if (Bid >= CurrentTakeProfitPrice)

CloseLong();

}

// Trailing Profit Taking for Short Position

if (CurrentDirection == -1)

{

if (CurrentTakeProfitPrice < Ask - TakeProfit * Point)

CurrentTakeProfitPrice = Ask - TakeProfit * Point;

if (Ask <= CurrentTakeProfitPrice)

CloseShort();

}

}

//+------------------------------------------------------------------+

Regards!

 
fxbg:
Hi,

Could someone please let me know how I can place a fixed StopLoss in ths code?

Replace

extern double Lots = 0.1;

extern int ChannelPeriod = 25;

extern int Slippage = 3;

extern int TakeProfit = 15;

//+------------------------------------------------------------------+

double LastOrderTime = 0;

double CurrentDirection = 0;

double CurrentTakeProfitPrice = 0;

//+------------------------------------------------------------------+

void OpenLong()

{

if (Time[0] == LastOrderTime)

return;

if (CurrentDirection != 0)

return;

OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, 0, 0,

"Daydream", MAGIC_NUM, 0, Blue);

LastOrderTime = Time[0];

CurrentDirection = 1;

}

//+------------------------------------------------------------------+

void OpenShort()

{

if (Time[0] == LastOrderTime)

return;

if (CurrentDirection != 0)

return;

OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, 0, 0,

"Daydream", MAGIC_NUM, 0, Red);

LastOrderTime = Time[0];

CurrentDirection = -1;

} [/CODE]

to

[CODE]extern double Lots = 0.1;

extern int ChannelPeriod = 25;

extern int Slippage = 3;

extern int TakeProfit = 15;

extern int StopLoss = 15;

//+------------------------------------------------------------------+

double LastOrderTime = 0;

double CurrentDirection = 0;

double CurrentTakeProfitPrice = 0;

//+------------------------------------------------------------------+

void OpenLong()

{

if (Time[0] == LastOrderTime)

return;

if (CurrentDirection != 0)

return;

OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, Ask-StopLoss*Point, 0,

"Daydream", MAGIC_NUM, 0, Blue);

LastOrderTime = Time[0];

CurrentDirection = 1;

}

//+------------------------------------------------------------------+

void OpenShort()

{

if (Time[0] == LastOrderTime)

return;

if (CurrentDirection != 0)

return;

OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, Bid+StopLoss*Point, 0,

"Daydream", MAGIC_NUM, 0, Red);

LastOrderTime = Time[0];

CurrentDirection = -1;

}
 

Need help modify the indicator

Hi all programmer,

I found an indicator (currency positions) in the forum which shows the current positions I am trading. Now I want to find someone out there help me make this indicator to use external window at the bottom of the chart, also the fonts and color can be changed. I am not good at program. Thanks a lot.

asam

Files:
 

Don't work in tester

I start this EA in tester .When it reach the first Stoploss tester stop and don't continue make a test.Is it possible to correct this problem.Thank you Roger.

//+------------------------------------------------------------------+

//| Daydream by Cothool |

//| Recommended: USD/JPY 1H |

//+------------------------------------------------------------------+

#define MAGIC_NUM 48213657

//+------------------------------------------------------------------+

extern double Lots = 0.1;

extern int ChannelPeriod = 25;

extern int Slippage = 3;

extern int TakeProfit = 0;

extern int StopLoss = 15;

//+------------------------------------------------------------------+

double LastOrderTime = 0;

double CurrentDirection = 0;

double CurrentTakeProfitPrice = 0;

//+------------------------------------------------------------------+

void OpenLong()

{

if (Time[0] == LastOrderTime)

return;

if (CurrentDirection != 0)

return;

OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage,Ask-StopLoss*Point, 0,

"Daydream", MAGIC_NUM, 0, Blue);

LastOrderTime = Time[0];

CurrentDirection = 1;

}

//+------------------------------------------------------------------+

void OpenShort()

{

if (Time[0] == LastOrderTime)

return;

if (CurrentDirection != 0)

return;

OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage,Bid+StopLoss*Point, 0,

"Daydream", MAGIC_NUM, 0, Red);

LastOrderTime = Time[0];

CurrentDirection = -1;

}

//+------------------------------------------------------------------+

void CloseLong()

{

int i;

if (Time[0] == LastOrderTime)

return;

if (CurrentDirection != 1)

return;

for (i = 0; i < OrdersTotal(); i++)

{

if (OrderSelect(i, SELECT_BY_POS) && OrderSymbol() == Symbol() &&

OrderMagicNumber() == MAGIC_NUM && OrderType() == OP_BUY)

{

OrderClose(OrderTicket(), OrderLots(), Bid, 3, White);

LastOrderTime = Time[0];

CurrentDirection = 0;

}

}

}

//+------------------------------------------------------------------+

void CloseShort()

{

int i;

if (Time[0] == LastOrderTime)

return;

if (CurrentDirection != -1)

return;

for (i = 0; i < OrdersTotal(); i++)

{

if (OrderSelect(i, SELECT_BY_POS) && OrderSymbol() == Symbol() &&

OrderMagicNumber() == MAGIC_NUM && OrderType() == OP_SELL)

{

OrderClose(OrderTicket(), OrderLots(), Ask, 3, White);

LastOrderTime = Time[0];

CurrentDirection = 0;

}

}

}

//+------------------------------------------------------------------+

void start()

{

double HighestValue;

double LowestValue;

HighestValue = High;

LowestValue = Low[Lowest(NULL, 0, MODE_LOW, ChannelPeriod, 1)];

// BUY

if (Close[0] < LowestValue)

{

CloseShort();

OpenLong();

CurrentTakeProfitPrice = Bid + TakeProfit * Point;

}

// SELL

if (Close[0] > HighestValue)

{

CloseLong();

OpenShort();

CurrentTakeProfitPrice = Ask - TakeProfit * Point;

}

// Trailing Profit Taking for Long Position

if (CurrentDirection == 1)

{

if (CurrentTakeProfitPrice > Bid + TakeProfit * Point)

CurrentTakeProfitPrice = Bid + TakeProfit * Point;

if (Bid >= CurrentTakeProfitPrice)

CloseLong();

}

// Trailing Profit Taking for Short Position

if (CurrentDirection == -1)

{

if (CurrentTakeProfitPrice < Ask - TakeProfit * Point)

CurrentTakeProfitPrice = Ask - TakeProfit * Point;

if (Ask <= CurrentTakeProfitPrice)

CloseShort();

}

}

//+------------------------------------------------------------------+

 

The code is amazing, thanks