Thanks Phillip! Sounds like the code had some problems with JPY pairs though. Has this been resolved?
Thanks
Shawn
Thanks Phillip! Sounds like the code had some problems with JPY pairs though. Has this been resolved?
Thanks
Shawn
I have no idea what you are referring to? Works fine with JPY pairs. As with any code though that you might entrust your money to, you should investigate the code and confirm it correctness with some manual calculations. The code is correct, but it isn't fool-proof :)
1. A Sample: Lot size computing https://www.mql5.com/en/code/8583
2. AIS1 Trading Robot https://www.mql5.com/en/code/8700
//< 7.7.2. Risk Management > //<192>
//< 7.7.3. Operation Size Control > //<202>
Would anyone have a handy-dandy little MQL4 function that automatically calculates lot size (for any symbol) based on how much % risk of my available equity, and my desired stoploss size in pips?
//+------------------------------------------------------------------+ //| Lot size computation. | //+------------------------------------------------------------------+ double LotSize(double risk){ /*double TEF.value, // Import from ComputeTEF //double at.risk; // Export to init/start //bool need2refresh; // Import from RelTradeContext //int op.code; // -1/OP_BUY/OP_SELL // Import from setDIR */ /* This function computes the lot size for a trade. * Explicit inputs are SL relative to bid/ask (E.G. SL=30*points,) * Implicit inputs are the MM mode, the MM multiplier, count currently * filled orders by all EA's vs this EA/pair/period count and history. * Implicit inputs are all used to reduce available balance the maximum * dollar risk allowed. StopLoss determines the maximum dollar risk possible * per lot. Lots=maxRisk/maxRiskPerLot **************************************************************************/ if (need2refresh) Refresh(); /*++++ Compute lot size based on account balance and MM mode*/{ double ab = AccountBalance(); switch(Money.Management.F0M1G2){ case MMMODE_FIXED: at.risk = Money.Management.Multiplier; break; case MMMODE_MODERATE: // See https://www.mql5.com/en/articles/1526 Fallacies, Part 1: Money // Management is Secondary and Not Very Important. // %used/trade= at.risk = MathSqrt(Money.Management.Multiplier * ab)/ab; // ~const rate. at.risk = MathSqrt(Money.Management.Multiplier * ab * MathPow( 1 - at.risk, OrdersTotal() )); break; case MMMODE_GEOMETRICAL: at.risk = Money.Management.Multiplier * ab * MathPow(1 - Money.Management.Multiplier, OrdersTotal()); break; } double maxLossPerLot = risk * PointValuePerLot(), /* Number of lots wanted = at.risk / maxLossPerLot rounded/truncated to * nearest lotStep size. * * However, the broker doesn't care about the at.risk/account balance. They * care about margin. Margin used=lots used*marginPerLot and that must be * less than free margin available. */ marginFree = AccountFreeMargin(), marginPerLot = MarketInfo( Symbol(), MODE_MARGINREQUIRED ), // So I use, the lesser of either. size = MathMin(marginFree / marginPerLot, at.risk / maxLossPerLot), minLot = MarketInfo(Symbol(), MODE_MINLOT), LotStep = MarketInfo(Symbol(), MODE_LOTSTEP); /*---- Compute lot size based on account balance and MM mode*/} double adjFact = IfD(MathMin(1, TEF.value), 1, TEF.Enable01); while (true){ // Adjust for broker, test for margin, combine with TEF size = MathFloor(size/LotStep)*LotStep; if (size < minLot){ // Insufficient margin. Print( "LotSize(SL=", DoubleToStr(risk/pips2dbl, Digits.pips), ")=", size, " [risk=", at.risk, AccountCurrency(), "/", maxLossPerLot, ", margin=", marginFree, "/", marginPerLot, ", MMM=", Money.Management.F0M1G2,"x", Money.Management.Multiplier, ", OO=", OrdersTotal(), "]" ); size=0; break; } /* size<minLot should be sufficient, but the tester was generating error * 134 even when marginFree should have been OK. So I also use * AccountFreeMarginCheck which aggrees with the tester. * https://forum.mql4.com/35056 */ double AFMC = AccountFreeMarginCheck(Symbol(), op.code, size); /**/ if (AFMC < 0) size *= 0.95; else if (adjFact < 1){ size = MathMax(minLot,size*adjFact);adjFact=1;} else break; // We're good to go. } at.risk = size * maxLossPerLot; // Export for Comment return(size); } // LotSize double PointValuePerLot() { // Value in account currency of a Point of Symbol. /* In tester I had a sale: open=1.35883 close=1.35736 (0.00147) * gain$=97.32/6.62 lots/147 points=$0.10/point or $1.00/pip. * IBFX demo/mini EURUSD TICKVALUE=0.1 MAXLOT=50 LOTSIZE=10,000 * IBFX demo/standard EURUSD TICKVALUE=1.0 MAXLOT=50 LOTSIZE=100,000 * $1.00/point or $10.00/pip. * * https://forum.mql4.com/33975 CB: MODE_TICKSIZE will usually return the * same value as MODE_POINT (or Point for the current symbol), however, an * example of where to use MODE_TICKSIZE would be as part of a ratio with * MODE_TICKVALUE when performing money management calculations which need * to take account of the pair and the account currency. The reason I use * this ratio is that although TV and TS may constantly be returned as * something like 7.00 and 0.00001 respectively, I've seen this * (intermittently) change to 14.00 and 0.00002 respectively (just example * tick values to illustrate). */ return( MarketInfo(Symbol(), MODE_TICKVALUE) / MarketInfo(Symbol(), MODE_TICKSIZE) ); // Not Point. }
Phillip, I put your code in my EA and it works beautifully - thank you so much. Thanks also to AIS and WHRoeder for their responses too!
Cheers
Shawn
Glad to hear it Shawn!
I am continuously tinkering with the codes, if you'd like a more recent version (there are no bugs in the ones you have) I'd be more than happy to share it.
The changes mostly center around making the include file easier to integrate and use with your existing EA. Since you've already managed to get the other one implemented it might not make any difference to you now.
Phillip, I would love that new "easier to use" include file, could you post it or send it to me, I'm trying to do that today actually.
Thanks!
Sure, I'll post it when I get back to the computer that has my codes.
I should probably upload it to the codebank too now that I think about it.
Step 1: Place all the file attachments from this post into your include path (...\experts\include\*.mqh)
Step 2: Add the following to the top of your EA so it has access to the call functions contained in the attached files
#include <OrderReliable_2010.10.12.mqh> #include <Trade_Position_Management_2010.10.29.mqh>
Step 3: To compute the lotsize based on a budgeted amount of equity to risk add the following
// Determine position lotsize based on order direction and market prices
double CurrentEquityAtRisk=(MaxPercentEquityAtRisk/100.)*AccountBalance();
double CurrentLotSize=LotSize(CurrentEquityAtRisk,OpenPrice_ND,StopLossPrice_ND,CurrentOrderType); // Compute the max possible lotsize for the risk equity
Print("Max allowed EquityAtRisk = $",DoubleToStr(CurrentEquityAtRisk,2)," and Max computed Lotsize = ",CurrentLotSize);
CurrentLotSize=NormalizeLotSize(CurrentLotSize); // Normalize the lotsize to conform with the Broker's specific quantized position allowances
if(CurrentLotSize<MarketInfo(CurrentSymbol,MODE_MINLOT)) CurrentLotSize=MarketInfo(CurrentSymbol,MODE_MINLOT);
if(CurrentLotSize>MarketInfo(CurrentSymbol,MODE_MAXLOT)) CurrentLotSize=MarketInfo(CurrentSymbol,MODE_MAXLOT);
Assuming you have defined MaxPercentEquityAtRisk somewhere in your EA to be the max allowed equity to put at risk of complete loss per trade in the event the stops are hit, this portion of code will first determine the maximum lotsize based on openprice and stoplossprice (not pips but actual market price, same thing you send in your order to the broker) and then it will determine the maximum position size that the broker will accept while not exceeding your budgeted risk equity.
Step 4: If you like having the results of the calculations printed in your log or added to the trade as an order comment you can also add the following
// Determine the actual equity at risk of total loss for the position's normalized lotsize CurrentEquityAtRisk=EquityAtRisk(CurrentLotSize,OpenPrice_ND,StopLossPrice_ND,CurrentOrderType); if(TakeProfitBidPrice>0.01) { CurrentProfitPotential=ProfitPotential(CurrentLotSize,OpenPrice_ND,TakeProfitPrice_ND,CurrentOrderType); Print("Current EquityAtRisk = $",DoubleToStr(CurrentEquityAtRisk,2)," and Current Lotsize = ",CurrentLotSize," and Profit Target = $" ,DoubleToStr(CurrentProfitPotential,2)," for a ",DoubleToStr(CurrentProfitPotential/CurrentEquityAtRisk,1),":1 Profit:Loss ratio"); Order_Comment=StringConcatenate("EaR = $",DoubleToStr(CurrentEquityAtRisk,2)," & Profit = $",DoubleToStr(CurrentProfitPotential,2)); } else { Print("Current EquityAtRisk = $",DoubleToStr(CurrentEquityAtRisk,2)," and Current Lotsize = ",CurrentLotSize); Order_Comment=StringConcatenate("EquityAtRisk = $",DoubleToStr(CurrentEquityAtRisk,2)); }
Step 5: Place your order (using the ordersendreliable method)
// Place the order ticket = OrderSendReliable(CurrentSymbol,CurrentOrderType,CurrentLotSize,OpenPrice_ND,MarketInfo(CurrentSymbol,MODE_SPREAD) ,StopLossPrice_ND,TakeProfitPrice_ND,Order_Comment,0,0,Aqua);
https://c.mql5.com/mql4/forum/2010/10/OrderReliable_2010.10.12.mqh
![MQL5 - Language of trade strategies built-in the MetaTrader 5 client terminal](https://c.mql5.com/i/registerlandings/logo-2.png)
- Free trading apps
- Over 8,000 signals for copying
- Economic news for exploring financial markets
You agree to website policy and terms of use
Hi All, back again to nag you. :-) Would anyone have a handy-dandy little MQL4 function that automatically calculates lot size (for any symbol) based on how much % risk of my available equity, and my desired stoploss size in pips?
Thanks!
Shawn