[Help] Change an indicator into a function in an EA

Erman Ardianto 2009.04.22 03:16

Hello all,

I'm trying to make the indicator below as a function in the EA so the EA will be able working independently.

Is anyone want to lay a hand? or at least give me a complete "how to" step by step so I can do it by myself..

Thank you.

//+------------------------------------------------------------------+
//|                                              SuperTrend.mq4 v1.2 |
//|                   Copyright © 2008, Jason Robinson (jnrtrading). |
//|                                   http://www.spreadtrade2win.com |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2008, Jason Robinson."
#property link      "http://www.spreadtrade2win.com"

#property indicator_chart_window
#property indicator_color1 Lime
#property indicator_color2 Red
#property indicator_width1 2
#property indicator_width2 2
#property indicator_buffers 2
double TrendUp[], TrendDown[];
int changeOfTrend;
extern int Nbr_Periods = 10;
extern double Multiplier = 3.0;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
//---- indicators
   SetIndexBuffer(0, TrendUp);
   SetIndexStyle(0, DRAW_LINE, STYLE_SOLID, 2);
   SetIndexLabel(0, "Trend Up");
   SetIndexBuffer(1, TrendDown);
   SetIndexStyle(1, DRAW_LINE, STYLE_SOLID, 2);
   SetIndexLabel(1, "Trend Down");
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
  {
   int limit, i, flag, flagh, trend[5000];
   double up[5000], dn[5000], medianPrice, atr;
   int counted_bars = IndicatorCounted();
//---- check for possible errors
   if(counted_bars < 0) return(-1);
//---- last counted bar will be recounted
   if(counted_bars > 0) counted_bars--;
   limit=Bars-counted_bars;
   //Print(limit);
   
//----
   for (i = Bars; i >= 0; i--) {
      TrendUp[i] = EMPTY_VALUE;
      TrendDown[i] = EMPTY_VALUE;
      atr = iATR(NULL, 0, Nbr_Periods, i);
      //Print("atr: "+atr[i]);
      medianPrice = (High[i]+Low[i])/2;
      //Print("medianPrice: "+medianPrice[i]);
      up[i]=medianPrice+(Multiplier*atr);
      //Print("up: "+up[i]);
      dn[i]=medianPrice-(Multiplier*atr);
      //Print("dn: "+dn[i]);
      trend[i]=1;
   
      
      if (Close[i]>up[i+1]) {
         trend[i]=1;
         if (trend[i+1] == -1) changeOfTrend = 1;
         //Print("trend: "+trend[i]);
         
      }
      else if (Close[i]<dn[i+1]) {
         trend[i]=-1;
         if (trend[i+1] == 1) changeOfTrend = 1;
         //Print("trend: "+trend[i]);
      }
      else if (trend[i+1]==1) {
         trend[i]=1;
         changeOfTrend = 0;       
      }
      else if (trend[i+1]==-1) {
         trend[i]=-1;
         changeOfTrend = 0;
      }

      if (trend[i]<0 && trend[i+1]>0) {
         flag=1;
         //Print("flag: "+flag);
      }
      else {
         flag=0;
         //Print("flagh: "+flag);
      }
      
      if (trend[i]>0 && trend[i+1]<0) {
         flagh=1;
         //Print("flagh: "+flagh);
      }
      else {
         flagh=0;
         //Print("flagh: "+flagh);
      }
      
      if (trend[i]>0 && dn[i]<dn[i+1])
         dn[i]=dn[i+1];
      
      if (trend[i]<0 && up[i]>up[i+1])
         up[i]=up[i+1];
      
      if (flag==1)
         up[i]=medianPrice+(Multiplier*atr);
         
      if (flagh==1)
         dn[i]=medianPrice-(Multiplier*atr);
         
      //-- Draw the indicator
      if (trend[i]==1) {
         TrendUp[i]=dn[i];
         if (changeOfTrend == 1) {
            TrendUp[i+1] = TrendDown[i+1];
            changeOfTrend = 0;
         }
      }
      else if (trend[i]==-1) {
         TrendDown[i]=up[i];
         if (changeOfTrend == 1) {
            TrendDown[i+1] = TrendUp[i+1];
            changeOfTrend = 0;
         }
      }
   }
   WindowRedraw();
      
//----
   return(0);
  }
//+------------------------------------------------------------------+

Walter 2009.04.22 05:52 #1

devilian1899 wrote >>

Hello all,

I'm trying to make the indicator below as a function in the EA so the EA will be able working independently.

Is anyone want to lay a hand? or at least give me a complete "how to" step by step so I can do it by myself..

Thank you.

'Transferring an Indicator Code into an Expert Advisor Code. Indicator Structure' and 'Transferring an Indicator Code into an Expert Advisor Code. General Structural Schemes of an Expert Advisor and Indicator Functions'

Erman Ardianto 2009.04.22 14:57 #2

Thank you brother3th. I already able to do this if there's only one loop inside the indicator, but still struggling if there're more in it.

Have a nice day

Rob Spaan 2012.12.14 09:40 #3

devilian1899:

Hello all,

I'm trying to make the indicator below as a function in the EA so the EA will be able working independently.

Is anyone want to lay a hand? or at least give me a complete "how to" step by step so I can do it by myself..

Thank you.

Hello,

I would also like to use the Supertrend indicator as an entry criteria in an Expert Advisor.

The input variables are the same as in the Supertrend indicator and the output variable has to be the trend direction. Up=1 and Down=-1 or something simmular.

Could you provide me the code for this function in an EA, based on the code for the chart indicator (SuperTrend.mq4 v1.2 ;see code above)?

Thanks, RobS

using EMPTY_VALUE to open SuperTrend for EA keep How to use output

Simon Gniadkowski 2012.12.14 09:48 #4

robspaan:

Hello,

I would also like to use the Supertrend indicator as an entry criteria in an Expert Advisor.

The input variables are the same as in the Supertrend indicator and the output variable has to be the trend direction. Up=1 and Down=-1 or something simmular.

Could you provide me the code for this function in an EA, based on the code for the chart indicator (SuperTrend.mq4 v1.2 ;see code above)?

Just use iCustom() to get the information from the Indicator that you need . . . . if you can't do that then you will need to get someone else to code for you: MT4 & MT5 coding

New comment