Why is sell trailing stop not working !!!!!!!!!!!

Ahmed Ibrahim Mahmoud Ibrahim 2022.11.05 14:24

void TrailingBuy(){       for(cnt=OrdersTotal()-1;cnt>=0;cnt--){    if(OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES))    if(OrderSymbol()==Symbol())    if(OrderMagicNumber()==Magic)    if(OrderType()==OP_BUY)    if(Bid-OrderOpenPrice()>TrailingStop*Point)    if(OrderStopLoss()<Bid-TrailingStep*Point)    bool zs = OrderModify(OrderTicket(),OrderOpenPrice(),Bid-TrailingStop*Point,OrderTakeProfit(),0,clrAliceBlue);

THAT Function WORK SUCCESSFULY but the SELL TRAILING FUNCTION IS NOT WORKING in the tester !!!!!

void TrailingSell(){

  

   for(cnt=OrdersTotal()-1;cnt>=0;cnt--){

   if(OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES))

   if(OrderSymbol()==Symbol())

   if(OrderMagicNumber()==Magic)

   if(OrderType()==OP_SELL)

   if(OrderOpenPrice()-Ask>TrailingStop*Point)

   if(OrderStopLoss()>Ask+TrailingStep*Point)

   bool zs = OrderModify(OrderTicket(),OrderOpenPrice(),Ask+TrailingStop*Point,OrderTakeProfit(),0,clrRed);

CAN ANY ONE HELP ME WHY IT IS NOT WORKING !! PLEASE I AM SO UPSET

Sergey Golubev 2022.11.05 14:36 #1

When you post code please use the CODE button (Alt-S)!

Use the CODE button

William Roeder 2022.11.05 15:10 #2

You correctly wrote:	if(Bid-OrderOpenPrice() > TrailingStopPoint) // Break even if(OrderStopLoss() < Bid-TrailingStepPoint) // and higher.
Inverting for selling gives:	if(OrderOpenPrice()-Ask > TrailingStopPoint) if(OrderStopLoss() < Ask+TrailingStepPoint)
But you wrote	if(OrderOpenPrice()-Ask > TrailingStopPoint) if(OrderStopLoss() > Ask+TrailingStepPoint)

You correctly wrote:

if(Bid-OrderOpenPrice() > TrailingStop*Point)      // Break even
if(OrderStopLoss()      < Bid-TrailingStep*Point)  // and higher.

Inverting for selling gives:

if(OrderOpenPrice()-Ask > TrailingStop*Point)
if(OrderStopLoss()      < Ask+TrailingStep*Point)

But you wrote

if(OrderOpenPrice()-Ask > TrailingStop*Point)
if(OrderStopLoss()      > Ask+TrailingStep*Point)

Isn't better to write it as:

double newSL= Bid-TrailingStep*Point;
if(newSL > MathMax( OrderStopLoss(), OrderOpenPrice() )) // BE and higher.
bool zs = OrderModify(OrderTicket(),OrderOpenPrice(),newSL,OrderTakeProfit(),0,clrAliceBlue);

Please edit your (original) post and use the CODE button (or Alt+S)! (For large amounts of code, attach it.)
General rules and best pratices of the Forum. - General - MQL5 programming forum (2019)
Messages Editor

'{' - function definition Trying to do an protecting an EA

Ahmed Ibrahim Mahmoud Ibrahim 2022.11.05 17:06 #3

William Roeder #:

You correctly wrote:

Inverting for selling gives:

But you wrote
Isn't better to write it as:
Please edit your (original) post and use the CODE button (or Alt+S)! (For large amounts of code, attach it.)
General rules and best pratices of the Forum. - General - MQL5 programming forum (2019)
Messages Editor

You correctly wrote:
Inverting for selling gives:
But you wrote

Thanks a lot it worked finally .. sorry i did not know about that code button

Ahmed Ibrahim Mahmoud Ibrahim 2022.11.05 17:09 #4

Sergey Golubev #:

When you post code please use the CODE button (Alt-S)!

ok i will sorry

Ahmed Ibrahim Mahmoud Ibrahim 2022.11.05 19:12 #5

William Roeder #:

You correctly wrote:

Inverting for selling gives:

But you wrote
Isn't better to write it as:
Please edit your (original) post and use the CODE button (or Alt+S)! (For large amounts of code, attach it.)
General rules and best pratices of the Forum. - General - MQL5 programming forum (2019)
Messages Editor

You correctly wrote:
Inverting for selling gives:
But you wrote

void TrailingSell()
  {
   for(cnt=OrdersTotal()-1; cnt>=0; cnt--)
     {
      if(OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES))
         if(OrderSymbol()==Symbol())
            if(OrderMagicNumber()==Magic)
               if(OrderType()==OP_SELL)
                  if(OrderOpenPrice()-Ask>TrailingStop*Point)
                     if(OrderStopLoss()<Ask+TrailingStep*Point)
                         bool zs = OrderModify(OrderTicket(),OrderOpenPrice(),Ask+TrailingStep*Point,OrderTakeProfit(),0,clrAliceBlue); 
                       
     }
  }

I have modified the code but the trailing do not move more than break even !

please look at photo attached if you know why it do not move more i will be Glad , Thanks Again

Get value from iBarShift(). Help need modifying this Help need modifying this

Keith Watford 2022.11.06 00:07 #6

Ahmed Gouda #:

I have modified the code but the trailing do not move more than break even !

please look at photo attached if you know why it do not move more i will be Glad , Thanks Again

I have deleted your image as it is not relevant (only showed pending orders).

                  if(OrderOpenPrice()-Ask>TrailingStop*Point)
                     if(OrderStopLoss()<Ask+TrailingStep*Point)

I don't understand your logic.

Surely it should be

                  if(OrderOpenPrice()-Ask>=TrailingStop*Point)
                     if(OrderStopLoss()>Ask+TrailingStep*Point)

New comment