Specification
Hi,
I have an existing EA from codebase, which I want some to enhance it and add few features like
1. Time Filter (Day and Time)
2. Risk Management
3. Trailing Stop Loss
4. Send signal and alert
and finetune existing code if any bugs there.
Here's code
#property copyright "Copyright 2010, vsebastien3" #include <Trade\PositionInfo.mqh> #include <Trade\Trade.mqh> #include <Trade\SymbolInfo.mqh> #include <Trade\AccountInfo.mqh> #include <Trade\DealInfo.mqh> #include <Trade\OrderInfo.mqh> CPositionInfo m_position; // trade position object CTrade m_trade; // trading object CSymbolInfo m_symbol; // symbol info object CAccountInfo m_account; // account info wrapper CDealInfo m_deal; // deals object COrderInfo m_order; // pending orders object //--- input parameters input int bands_period= 20; // Bollinger Bands period input int rsi_period =13; //rsi period input int rsi_up=70; //rsi overbought lvl input int rsi_down=30; // rsi oversold lvl input double Lot=0.1; // Lot if autolot inactive input double SL=0.0238; //stop lose value input int MAperiod = 200; // Period of the MA input int magic=1234; input bool autolot = true ; // activate or not autolot input double risk=0.05; // risk per trade of total equity //--- global variables //--- initialize global variables bool m_need_modify=false; bool m_OnTradeTransaction=false; long m_last_closed_position_type=-1; double m_last_closed_position_volume=0.0; double m_last_closed_position_profit=0.0; bool InpAllMagic = false; int bands_shift = 0; // Bollinger Bands shift double deviation= 2; // Standard deviation int MAshift=0; // Ma shift double usedlot; double usedlot2; int BolBandsHandle; // Bolinger Bands handle int rsiHandle; int MAHandle; double BBUp[],BBLow[],BBMidle[]; // dynamic arrays for numerical values of Bollinger Bands ulong orderTicket; //+------------------------------------------------------------------+ //| Expert initialization function | //+------------------------------------------------------------------+ int OnInit() { //--- Do we have sufficient bars to work if(Bars(_Symbol,_Period)<60) // total number of bars is less than 60? { Alert("We have less than 60 bars on the chart, an Expert Advisor terminated!!"); return(-1); } //-------------------------------------------- last closed position //--- get handle of the Bollinger Bands and RSI indicators BolBandsHandle=iBands(NULL,PERIOD_CURRENT,bands_period,bands_shift,deviation,PRICE_CLOSE); rsiHandle=iRSI(NULL,0,rsi_period,PRICE_CLOSE); MAHandle=iMA(NULL,PERIOD_D1,MAperiod,MAshift,MODE_EMA,PRICE_CLOSE); if ( MAHandle == INVALID_HANDLE ) { Print("Creating MA failed. Error #", GetLastError()); return(-1); } if ( rsiHandle == INVALID_HANDLE ) { Print("Creating RSI failed. Error #", GetLastError()); return(-1); } //--- Check for Invalid Handle if((BolBandsHandle<0)) { Alert("Error in creation of indicators - error: ",GetLastError(),"!!"); return(-1); } return(0); } //+------------------------------------------------------------------+ //| Expert deinitialization function | //+------------------------------------------------------------------+ void OnDeinit(const int reason) { //--- release indicator handles IndicatorRelease(BolBandsHandle); IndicatorRelease(rsiHandle); IndicatorRelease(MAHandle); } //-------------------------------------------------------------------------------------------------- double RsiValue() { //--- double rsi[2]; ResetLastError(); if ( CopyBuffer(rsiHandle, 0, 0, 2, rsi) == 2 ) { return(rsi[0]); } else { Print(__FUNCTION__, ": getting RSI data failed. Error #", GetLastError()); } //--- return(-1.0); } //---------------------------------------------------------------------------------------- double MAvalue() { //--- double MA[2]; ResetLastError(); if ( CopyBuffer(MAHandle, 0, 0, 2, MA) == 2 ) { return(MA[0]); } else { Print(__FUNCTION__, ": getting MA data failed. Error #", GetLastError()); } //--- return(-1.0); } //----------------------------------------------------------- double Autolot() { double balance=AccountInfoDouble(ACCOUNT_BALANCE); double pertem=balance*risk; double perte=SL*SymbolInfoDouble(_Symbol,SYMBOL_BID); double maxvol=SymbolInfoDouble(Symbol(),SYMBOL_VOLUME_MAX); double minvol=SymbolInfoDouble(Symbol(),SYMBOL_VOLUME_MIN); double lotsize=SymbolInfoDouble(Symbol(),SYMBOL_TRADE_CONTRACT_SIZE); if(autolot==true) { usedlot=(pertem/perte)/lotsize; usedlot2 = NormalizeDouble(usedlot,2); if(usedlot2<minvol) { usedlot2=minvol; } if(usedlot2>maxvol) { usedlot2=maxvol; } } else usedlot2=Lot; if(usedlot2<minvol) { usedlot2=minvol; } if(usedlot2>maxvol) { usedlot2=maxvol; } return(0.01); } //------------------------------------------------------------ //+------------------------------------------------------------------+ //| Expert tick function | //+------------------------------------------------------------------+ void OnTick() { //--- we will use the static Old_Time variable to serve the bar time. //--- at each OnTick execution we will check the current bar time with the saved one. //--- if the bar time isn't equal to the saved time, it indicates that we have a new tick. static datetime Old_Time; datetime New_Time[1]; bool IsNewBar=false; Autolot(); double rsi_value = RsiValue(); double MA_value = MAvalue(); bool Ismoney=CheckMoneyForTrade(_Symbol,usedlot2,0); //--- copying the last bar time to the element New_Time[0] int copied=CopyTime(_Symbol,_Period,0,1,New_Time); if(copied>0) // ok, the data has been copied successfully { if(Old_Time!=New_Time[0]) // if old time isn't equal to new bar time { IsNewBar=true; // if it isn't a first call, the new bar has appeared if(MQL5InfoInteger(MQL5_DEBUGGING)) Print("We have new bar here ",New_Time[0]," old time was ",Old_Time); Old_Time=New_Time[0]; // saving bar time } } else { Alert("Error in copying historical times data, error =",GetLastError()); ResetLastError(); return; } //--- EA should only check for new trade if we have a new bar if(IsNewBar==false) { return; } //--- do we have enough bars to work with int Mybars=Bars(_Symbol,_Period); if(Mybars<60) // if total bars is less than 60 bars { Alert("We have less than 60 bars, EA will now exit!!"); return; } MqlRates mrate[]; // To be used to store the prices, volumes and spread of each bar /* Let's make sure our arrays values for the Rates and Indicators is stored serially similar to the timeseries array */ // the rates arrays ArraySetAsSeries(mrate,true); // the indicator arrays ArraySetAsSeries(BBUp,true); ArraySetAsSeries(BBLow,true); ArraySetAsSeries(BBMidle,true); //--- Get the details of the latest 3 bars if(CopyRates(_Symbol,_Period,0,3,mrate)<0) { Alert("Error copying rates/history data - error:",GetLastError(),"!!"); return; } //--- Copy the new values of our indicators to buffers (arrays) using the handle if(CopyBuffer(BolBandsHandle,0,0,3,BBMidle)<0 || CopyBuffer(BolBandsHandle,1,0,3,BBUp)<0 || CopyBuffer(BolBandsHandle,2,0,3,BBLow)<0) { Alert("Error copying Bollinger Bands indicator Buffers - error:",GetLastError(),"!!"); return; } double Ask = SymbolInfoDouble(_Symbol,SYMBOL_ASK); // Ask price double Bid = SymbolInfoDouble(_Symbol,SYMBOL_BID); // Bid price //--- Declare bool type variables to hold our Buy and Sell Conditions bool Buy_Condition =(mrate[1].close < BBLow[1] && //closing candle under lowest BB rsi_value<rsi_down && // rsi value lower than oversold limit mrate[1].close>MA_value); // closing candle above MA bool Sell_Condition = (mrate[1].close > BBUp[1] && //closing candle above Highest BB rsi_value>rsi_up && // rsi value higher than overbought limit mrate[1].close<MA_value); // closing candle under MA if(Buy_Condition && !PositionSelect(_Symbol) && Ismoney==true) // Open long position { // DEÌÀ is growing up LongPositionOpen(); // and white candle crossed the Lower Band from below to above } if(Sell_Condition && !PositionSelect(_Symbol)&& Ismoney==true) // Open short position { // DEÌÀ is falling down ShortPositionOpen(); // and Black candle crossed the Upper Band from above to below } return; } //+------------------------------------------------------------------+ //| Open Long position | //+------------------------------------------------------------------+ void LongPositionOpen() { MqlTradeRequest mrequest; // Will be used for trade requests MqlTradeResult mresult; // Will be used for results of trade requests ZeroMemory(mrequest); ZeroMemory(mresult); double Ask = SymbolInfoDouble(_Symbol,SYMBOL_ASK); // Ask price double Bid = SymbolInfoDouble(_Symbol,SYMBOL_BID); // Bid price if(!PositionSelect(_Symbol)) { mrequest.action = TRADE_ACTION_DEAL; // Immediate order execution mrequest.price = NormalizeDouble(Ask,_Digits); // Lastest Ask price mrequest.sl = BBLow[1]-SL; // Stop Loss mrequest.tp = BBMidle[1]; // Take Profit mrequest.symbol = _Symbol; // Symbol mrequest.volume = usedlot2; // Number of lots to trade mrequest.magic = magic; // Magic Number mrequest.type = ORDER_TYPE_BUY; // Buy Order mrequest.type_filling = ORDER_FILLING_FOK; // Order execution type mrequest.deviation=5; // Deviation from current price OrderSend(mrequest,mresult); // Send order } } //+------------------------------------------------------------------+ //| Open Short position | //+------------------------------------------------------------------+ void ShortPositionOpen() { MqlTradeRequest mrequest; // Will be used for trade requests MqlTradeResult mresult; // Will be used for results of trade requests ZeroMemory(mrequest); ZeroMemory(mresult); double Ask = SymbolInfoDouble(_Symbol,SYMBOL_ASK); // Ask price double Bid = SymbolInfoDouble(_Symbol,SYMBOL_BID); // Bid price if(!PositionSelect(_Symbol)) { mrequest.action = TRADE_ACTION_DEAL; // Immediate order execution mrequest.price = NormalizeDouble(Bid,_Digits); // Lastest Bid price mrequest.sl = BBUp[1]+SL; // Stop Loss mrequest.tp = BBMidle[1]; // Take Profit mrequest.symbol = _Symbol; // Symbol mrequest.volume = usedlot2; // Number of lots to trade mrequest.magic = magic; // Magic Number mrequest.type= ORDER_TYPE_SELL; // Sell order mrequest.type_filling = ORDER_FILLING_FOK; // Order execution type mrequest.deviation=5; // Deviation from current price OrderSend(mrequest,mresult); // Send order } } //----------------------------------------------------- double LotCheck(double lots) { //--- calculate maximum volume double volume=NormalizeDouble(lots,2); double stepvol=m_symbol.LotsStep(); if(stepvol>0.0) volume=stepvol*MathFloor(volume/stepvol); //--- double minvol=m_symbol.LotsMin(); if(volume<minvol) volume=0.0; //--- double maxvol=m_symbol.LotsMax(); if(volume>maxvol) volume=maxvol; return(volume); } //--------------------------------------------------------- //+------------------------------------------------------------------+ //| TradeTransaction function | //+------------------------------------------------------------------+ void OnTradeTransaction(const MqlTradeTransaction &trans, const MqlTradeRequest &request, const MqlTradeResult &result) { //--- get transaction type as enumeration value ENUM_TRADE_TRANSACTION_TYPE type=trans.type; //--- if transaction is result of addition of the transaction in history if(type==TRADE_TRANSACTION_DEAL_ADD) { long deal_entry =0; string deal_symbol =""; long deal_magic =0; double deal_profit=0; if(HistoryDealSelect(trans.deal)) { deal_entry=HistoryDealGetInteger(trans.deal,DEAL_ENTRY); deal_symbol=HistoryDealGetString(trans.deal,DEAL_SYMBOL); deal_magic=HistoryDealGetInteger(trans.deal,DEAL_MAGIC); deal_profit=HistoryDealGetDouble(trans.deal,DEAL_PROFIT); } else return; if(deal_symbol==Symbol() && deal_magic==magic) if(deal_entry==DEAL_ENTRY_OUT) { if(deal_profit>0) { Print("profit > 0.0"); } else { Print("profit < 0.0"); } } } } //---------------------------------- bool CheckMoneyForTrade(string symb,double lots,ENUM_ORDER_TYPE type) { //--- Getting the opening price MqlTick mqltick; SymbolInfoTick(symb,mqltick); double price=mqltick.ask; if(type==ORDER_TYPE_SELL) price=mqltick.bid; //--- values of the required and free margin double margin,free_margin=AccountInfoDouble(ACCOUNT_MARGIN_FREE); //--- call of the checking function if(!OrderCalcMargin(type,symb,lots,price,margin)) { //--- something went wrong, report and return false Print("Error in ",__FUNCTION__," code=",GetLastError()); return(false); } //--- if there are insufficient funds to perform the operation if(margin>free_margin) { //--- report the error and return false Print("Not enough money for ",EnumToString(type)," ",lots," ",symb," Error code=",GetLastError()); return(false); } //--- checking successful return(true); }
Responded
1
Rating
Projects
209
28%
Arbitration
0
Overdue
3
1%
Free
2
Rating
Projects
33
55%
Arbitration
5
80%
/
20%
Overdue
3
9%
Free
3
Rating
Projects
207
80%
Arbitration
18
33%
/
44%
Overdue
10
5%
Working
4
Rating
Projects
175
43%
Arbitration
6
0%
/
67%
Overdue
8
5%
Free
Similar orders
Mobile robot
50 - 100 USD
I want a profitable scalping EA robot for mt5 and mobile phones (licence key should be provided).the video link attached below indicates how the EA robot should operate it.it analyses the market before taking trades and it trades candle to candle .also coding samples are provided on the video .it should be applicable to all timeframes.it should trade indices(Nas100,US30,S&p500,GER30,)
Cyclical indicator for mt5
50 - 100 USD
I use the translator I hope to make myself understood. I'm looking for a cyclical indicator. mt5. I attach videos to understand how it works. to be inserted at any point of the graph. It is possible to change the color and thickness of the line
This EA must have the following functions together: BE: place BE when the price reach a certain gain in PIPS and you can choose the offset too, so, for example it activates after 10 pips with 1 pip of offset so you can have profit with BE too Auto SL and TP Can manage the trades made by phone when MT5 is open in the PC or VPS Trailing stop (step by step): I can decide at what number of pips the trailing stop get
This is a strategy based on crossing two trend indicators on the second timeframe (1s, for example). We work not only with the market but with the limit orders as well (robot must "read" an order book). Read the whole instruction please for more details. Speak Russian, English
Martingale EA for MT5
30 - 100 USD
Criteria: Only one trade at a time. Cannot open another trade if one is running Trade on EURUSD only, once job is completed I will be happy to schedule more for other pairs You choose entry strategy and criteria win rate must be above 50% in long term backtest of EURUSD Every trade has got TP and SL Trades to last about a day, few trades a week, at least 10 pips gain per trade, so that it can be launched on normal
EA based on supply and demand.
30 - 45 USD
I would like to create an EA based on the Shved Supply and Demand indicator. you can find the Shved Supply and Demand v1.7 indicator in the following link https://www.mql5.com/en/code/29395 NB: Checks the trading robot must pass before publication in the Market ( https://www.mql5.com/en/articles/2555 ) MQ5 file to be provided
MT5 EA for trading Indicator signals
30 - 40 USD
Im looking for an coder to code an EA: Trade management 1. opening trades according to the indicator 2. trades settings to choose from like: open all trades according to the signal open only trade 1,2,3 or 4 % per trade ( example 50/30/20 of the lot settings, with 4 trades it would be for example 50/30/10/10) 3. SL/Trailing settings: Move SL to entry after hitting TP1/TP2 or TP3 moving SL by % keep the original SL
Hi I'm looking to have 2 of my pinescript strategies converted to MQL5 and was wondering if you could first give me a quote for the more simple strategy and then for both the simple and complex strategy together. The simple strategy is a MACD crossover type thing that uses a special EMA script that filters out some ranging price action and also fractal candles for the stop loss. The second strategy is market
I want grate robot for making profits
30 - 200 USD
I want grate robot for making profits that know when to start a good trade and close a trade and must be active all time to avoid lost of money
MT5 code matches your TradingView strategy.
30 - 40 USD
I have developed a very strong TradingView strategy in Pine Script but unfortunately, a third-party connector is requiired and in my opinion, I want a more direct connection. I am not brilliant at coding, but I have coded the majority of the MT5 code and I would like you to make sure that the MT5 code matches my TradingView script and executes the same way as the TradingView script that I will provide if you are
Project information
Budget
30+ USD
For the developer
27
USD